From patchwork Fri Feb 14 15:09:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nemesa Garg X-Patchwork-Id: 13975088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 760FCC02198 for ; Fri, 14 Feb 2025 15:13:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D1C210ECC2; Fri, 14 Feb 2025 15:13:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="N5TzC1rM"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1256610ECD5 for ; Fri, 14 Feb 2025 15:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739546013; x=1771082013; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gCVJji8leIROlY7ozX7yTfhZGvFGHGdRzNucA3PHeZU=; b=N5TzC1rMjepGLx/spEq/cm48v20FGCYwOwDhpkANYt8i4TNqed2GV77a 3OBlHiUEgyo1zX4sVTZ+F5MeWXCC/6yT/gTZaL6QPemlu5RamSfSbxuBy BD+4wpHaGhOw/vTxo26Tc9CXibhzcgXID+PU1ElOLpLVirh+avPrtcKT9 c47HUKOf1HFY324nmtflvsLeA4ee8JcAfHMx05BVhIYOxtB8uW+1+0Xqg iGCWFhnT7EzzAvT/OO8dId+tPbKQHIBhbM9//336l735xauWm0mtlKihQ bzzAYa7TLF9JYmbSFxTgV4y52ftXMEiWYfpeSzIQpC1I1KkgMKBJY8Pjf w==; X-CSE-ConnectionGUID: X/1AhAufQcK7B371vxig8A== X-CSE-MsgGUID: poPcEv5ZTdiFlEYfYzd9pw== X-IronPort-AV: E=McAfee;i="6700,10204,11345"; a="39482248" X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="39482248" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 07:13:33 -0800 X-CSE-ConnectionGUID: bt5yuF3CRv6cotxz2x2RvA== X-CSE-MsgGUID: AaonJzHPSraM1EdElLRm8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="113675755" Received: from nemesa.iind.intel.com ([10.190.239.22]) by fmviesa008.fm.intel.com with ESMTP; 14 Feb 2025 07:13:31 -0800 From: Nemesa Garg To: intel-gfx@lists.freedesktop.org Cc: Nemesa Garg Subject: [PATCH 0/6] Introduce drm sharpness property Date: Fri, 14 Feb 2025 20:39:18 +0530 Message-Id: <20250214150924.1811372-1-nemesa.garg@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural details. Intel has come up with Display Engine based adaptive sharpening filter with minimal power and performance impact. From LNL onwards, the Display hardware can use one of the pipe scaler for adaptive sharpness filter. This can be used for both gaming and non-gaming use cases like photos, image viewing. It works on a region of pixels depending on the tap size. This is an attempt to introduce an adaptive sharpness solution which helps in improving the image quality. For this new CRTC property is added. The user can set this property with desired sharpness strength value with 0-255. A value of 1 representing minimum sharpening strength and 255 representing maximum sharpness strength. A strength value of 0 means no sharpening or sharpening feature disabled. It works on a region of pixels depending on the tap size. The coefficients are used to generate an alpha value which is used to blend the sharpened image to original image. Middleware MR link: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3665 IGT patchwork link: https://patchwork.freedesktop.org/series/130218/ Continuing discussions from: https://patchwork.freedesktop.org/series/129888/ Nemesa Garg (6): drm: Introduce sharpness strength property drm/i915/display: Compute the scaler filter coefficients drm/i915/display: Enable the second scaler drm/i915/display: Configure the second scaler for sharpness drm/i915/display: Add registers and compute the strength drm/i915/display: Load the lut values and enable sharpness drivers/gpu/drm/drm_atomic_uapi.c | 4 + drivers/gpu/drm/drm_crtc.c | 35 +++ drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_casf.c | 272 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_casf.h | 24 ++ .../gpu/drm/i915/display/intel_casf_regs.h | 41 +++ drivers/gpu/drm/i915/display/intel_crtc.c | 3 + .../drm/i915/display/intel_crtc_state_dump.c | 5 + drivers/gpu/drm/i915/display/intel_display.c | 44 ++- .../drm/i915/display/intel_display_device.h | 1 + .../drm/i915/display/intel_display_types.h | 16 ++ drivers/gpu/drm/i915/display/intel_pfit.c | 8 + drivers/gpu/drm/i915/display/skl_scaler.c | 105 ++++++- drivers/gpu/drm/i915/display/skl_scaler.h | 1 + drivers/gpu/drm/xe/Makefile | 1 + include/drm/drm_crtc.h | 17 ++ 16 files changed, 562 insertions(+), 16 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_casf.c create mode 100644 drivers/gpu/drm/i915/display/intel_casf.h create mode 100644 drivers/gpu/drm/i915/display/intel_casf_regs.h