mbox series

[0/6] drm/i915/pps: pass dev_priv explicitly to PPS regs

Message ID cover.1716806471.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915/pps: pass dev_priv explicitly to PPS regs | expand

Message

Jani Nikula May 27, 2024, 10:41 a.m. UTC
Continue avoiding the implicit dev_priv local variable.

Jani Nikula (6):
  drm/i915: pass dev_priv explicitly to _MMIO_PPS
  drm/i915: pass dev_priv explicitly to PP_STATUS
  drm/i915: pass dev_priv explicitly to PP_CONTROL
  drm/i915: pass dev_priv explicitly to PP_ON_DELAYS
  drm/i915: pass dev_priv explicitly to PP_OFF_DELAYS
  drm/i915: pass dev_priv explicitly to PP_DIVISOR

 .../drm/i915/display/intel_display_power.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c  |  4 +--
 drivers/gpu/drm/i915/display/intel_lvds.c     | 29 +++++++++---------
 drivers/gpu/drm/i915/display/intel_pps.c      | 30 +++++++++----------
 drivers/gpu/drm/i915/display/intel_pps_regs.h | 16 +++++-----
 5 files changed, 41 insertions(+), 40 deletions(-)

Comments

Borah, Chaitanya Kumar May 28, 2024, 5:55 a.m. UTC | #1
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Monday, May 27, 2024 4:12 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com
> Subject: [PATCH 0/6] drm/i915/pps: pass dev_priv explicitly to PPS regs
> 
> Continue avoiding the implicit dev_priv local variable.
> 

LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>



> Jani Nikula (6):
>   drm/i915: pass dev_priv explicitly to _MMIO_PPS
>   drm/i915: pass dev_priv explicitly to PP_STATUS
>   drm/i915: pass dev_priv explicitly to PP_CONTROL
>   drm/i915: pass dev_priv explicitly to PP_ON_DELAYS
>   drm/i915: pass dev_priv explicitly to PP_OFF_DELAYS
>   drm/i915: pass dev_priv explicitly to PP_DIVISOR
> 
>  .../drm/i915/display/intel_display_power.c    |  2 +-
>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c  |  4 +--
>  drivers/gpu/drm/i915/display/intel_lvds.c     | 29 +++++++++---------
>  drivers/gpu/drm/i915/display/intel_pps.c      | 30 +++++++++----------
>  drivers/gpu/drm/i915/display/intel_pps_regs.h | 16 +++++-----
>  5 files changed, 41 insertions(+), 40 deletions(-)
> 
> --
> 2.39.2
Jani Nikula May 28, 2024, 8:11 a.m. UTC | #2
On Tue, 28 May 2024, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Monday, May 27, 2024 4:12 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com
>> Subject: [PATCH 0/6] drm/i915/pps: pass dev_priv explicitly to PPS regs
>>
>> Continue avoiding the implicit dev_priv local variable.
>>
>
> LGTM
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

Thanks for the review, pushed to din.

BR,
Jani.