mbox series

[0/3] drm: add drm_printer based hex dumper and use it

Message ID cover.1733392101.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm: add drm_printer based hex dumper and use it | expand

Message

Jani Nikula Dec. 5, 2024, 9:49 a.m. UTC 
Add a hex dumper for drm_printer, and use it to simplify hex dumping in
i915.

Jani Nikula (3):
  drm/print: add drm_print_hex_dump()
  drm/i915/display: use drm_print_hex_dump() for crtc state dump
  drm/i915/display: use drm_print_hex_dump() for buffer mismatch dumps

 drivers/gpu/drm/drm_print.c                   | 23 +++++++++++++++++++
 .../drm/i915/display/intel_crtc_state_dump.c  | 14 ++---------
 drivers/gpu/drm/i915/display/intel_display.c  | 17 ++------------
 include/drm/drm_print.h                       |  2 ++
 4 files changed, 29 insertions(+), 27 deletions(-)

Comments

Andi Shyti Dec. 5, 2024, 1:16 p.m. UTC | #1 
Hi Jani,

On Thu, Dec 05, 2024 at 11:49:34AM +0200, Jani Nikula wrote:
> Use the drm_printer based printer to get the device specific printing of
> the hex dump.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

...

> -static void
> -intel_dump_buffer(const char *prefix, const u8 *buf, size_t len)
> -{
> -	if (!drm_debug_enabled(DRM_UT_KMS))
> -		return;

We lose this check now, anyway,

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi
Jani Nikula Dec. 5, 2024, 1:32 p.m. UTC | #2 
On Thu, 05 Dec 2024, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Jani,
>
> On Thu, Dec 05, 2024 at 11:49:34AM +0200, Jani Nikula wrote:
>> Use the drm_printer based printer to get the device specific printing of
>> the hex dump.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ...
>
>> -static void
>> -intel_dump_buffer(const char *prefix, const u8 *buf, size_t len)
>> -{
>> -	if (!drm_debug_enabled(DRM_UT_KMS))
>> -		return;
>
> We lose this check now, anyway,

That now depends on the drm_printer, as it should.

Moreover, intel_crtc_state_dump() already has that check, so this is
completely redundant.

> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Jani.

>
> Thanks,
> Andi