From patchwork Thu Nov 19 04:26:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: sonika.jindal@intel.com X-Patchwork-Id: 7654971 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7285BBF90C for ; Thu, 19 Nov 2015 04:26:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A9A022049D for ; Thu, 19 Nov 2015 04:26:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9887220256 for ; Thu, 19 Nov 2015 04:26:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 219B46E895; Wed, 18 Nov 2015 20:26:33 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 358F06E895 for ; Wed, 18 Nov 2015 20:26:31 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 18 Nov 2015 20:26:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,316,1444719600"; d="scan'208";a="854256062" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 18 Nov 2015 20:26:31 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Nov 2015 20:26:30 -0800 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Nov 2015 20:26:30 -0800 Received: from bgsmsx104.gar.corp.intel.com ([169.254.5.225]) by BGSMSX102.gar.corp.intel.com ([169.254.2.166]) with mapi id 14.03.0248.002; Thu, 19 Nov 2015 09:56:26 +0530 From: "Jindal, Sonika" To: "Vivi, Rodrigo" , "intel-gfx@lists.freedesktop.org" Thread-Topic: [PATCH 3/3] drm/i915: Also disable PSR on Sink when disabling it on Source. Thread-Index: AQHRImLNkgl0Hoa7/02uknEyy0Qcyp6ivs4w Date: Thu, 19 Nov 2015 04:26:25 +0000 Message-ID: <000C66961D35964B9714611E548C10AD0C319A17@BGSMSX104.gar.corp.intel.com> References: <1447893575-25369-1-git-send-email-rodrigo.vivi@intel.com> <1447893575-25369-4-git-send-email-rodrigo.vivi@intel.com> In-Reply-To: <1447893575-25369-4-git-send-email-rodrigo.vivi@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Also disable PSR on Sink when disabling it on Source. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Why not move it inside the mutex_lock/unlock on psr.lock ? Regards, Sonika -----Original Message----- From: Vivi, Rodrigo Sent: Thursday, November 19, 2015 6:10 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo; Jindal, Sonika Subject: [PATCH 3/3] drm/i915: Also disable PSR on Sink when disabling it on Source. It is not a bad idea to disable the PSR feature on Sink when we are disabling on the Source. Cc: Sonika Jindal Suggested-by: Sonika Jindal Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_psr.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.4.3 diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 38ea4d0..de31162 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -527,6 +527,9 @@ void intel_psr_disable(struct intel_dp *intel_dp) mutex_unlock(&dev_priv->psr.lock); cancel_delayed_work_sync(&dev_priv->psr.work); + + /* Disable PSR on Sink */ + drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0); } static void intel_psr_work(struct work_struct *work)