From patchwork Wed Sep 2 07:00:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Xiang, Haihao" X-Patchwork-Id: 45147 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8271jbm008922 for ; Wed, 2 Sep 2009 07:01:45 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D32099E88E; Wed, 2 Sep 2009 00:01:44 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E2F5E9E81E for ; Wed, 2 Sep 2009 00:01:42 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 01 Sep 2009 23:48:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,316,1249282800"; d="scan'208";a="444822504" Received: from xhh-945g.sh.intel.com (HELO [10.239.36.160]) ([10.239.36.160]) by orsmga002.jf.intel.com with ESMTP; 02 Sep 2009 00:07:57 -0700 From: "Xiang, Haihao" To: =?ISO-8859-1?Q?R=E9mi?= Cardona In-Reply-To: <1251877870.4839.0.camel@localhost.localdomain> References: <1251868296-6595-1-git-send-email-haihao.xiang@intel.com> <1251877870.4839.0.camel@localhost.localdomain> Date: Wed, 02 Sep 2009 15:00:48 +0800 Message-Id: <1251874848.9743.48.camel@xhh-945g> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 Cc: "intel-gfx@lists.freedesktop.org" Subject: Re: [Intel-gfx] [PATCH] intel_gpu_dump: Fix the length of CONSTANT_BUFFER X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org On Wed, 2009-09-02 at 15:51 +0800, Rémi Cardona wrote: > Le mercredi 02 septembre 2009 à 13:11 +0800, Xiang, Haihao a écrit : > > diff --git a/tools/intel_gpu_dump.c b/tools/intel_gpu_dump.c > > index bb2637d..2ab418c 100644 > > --- a/tools/intel_gpu_dump.c > > +++ b/tools/intel_gpu_dump.c > > @@ -1521,6 +1521,7 @@ decode_3d_965(uint32_t *data, int count, uint32_t hw_offset, int *failures) > > (data[1] >> 4) & 0x1f, data[1] & 0x7); > > return len; > > case 0x6002: > > + len = (data[0] & 0x000000ff) + 2; > > instr_out(data, hw_offset, 0, "CONSTANT_BUFFER: %s\n", > > (data[0] >> 8) & 1 ? "valid" : "invalid"); > ^^^^ weird indentation Fixed, Thanks --- tools/intel_gpu_dump.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/intel_gpu_dump.c b/tools/intel_gpu_dump.c index bb2637d..ae74cf4 100644 --- a/tools/intel_gpu_dump.c +++ b/tools/intel_gpu_dump.c @@ -1521,6 +1521,7 @@ decode_3d_965(uint32_t *data, int count, uint32_t hw_offset, int *failures) (data[1] >> 4) & 0x1f, data[1] & 0x7); return len; case 0x6002: + len = (data[0] & 0x000000ff) + 2; instr_out(data, hw_offset, 0, "CONSTANT_BUFFER: %s\n", (data[0] >> 8) & 1 ? "valid" : "invalid"); instr_out(data, hw_offset, 1, "offset: 0x%08x, length: 0x%08x\n",