From patchwork Wed Jan 20 09:41:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhao, Yakui" X-Patchwork-Id: 74029 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o0K9gpM9013911 for ; Wed, 20 Jan 2010 09:42:51 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31BED9EF72; Wed, 20 Jan 2010 01:42:51 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 509F89EF59 for ; Wed, 20 Jan 2010 01:42:42 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 20 Jan 2010 01:42:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.49,309,1262592000"; d="scan'208";a="765729761" Received: from yakui_zhao.sh.intel.com (HELO localhost.localdomain) ([10.239.13.83]) by fmsmga001.fm.intel.com with ESMTP; 20 Jan 2010 01:42:40 -0800 From: yakui.zhao@intel.com To: eric@anholt.net Date: Wed, 20 Jan 2010 17:41:18 +0800 Message-Id: <1263980478-18338-10-git-send-email-yakui.zhao@intel.com> X-Mailer: git-send-email 1.5.4.5 In-Reply-To: <1263980478-18338-9-git-send-email-yakui.zhao@intel.com> References: <1263980478-18338-1-git-send-email-yakui.zhao@intel.com> <1263980478-18338-2-git-send-email-yakui.zhao@intel.com> <1263980478-18338-3-git-send-email-yakui.zhao@intel.com> <1263980478-18338-4-git-send-email-yakui.zhao@intel.com> <1263980478-18338-5-git-send-email-yakui.zhao@intel.com> <1263980478-18338-6-git-send-email-yakui.zhao@intel.com> <1263980478-18338-7-git-send-email-yakui.zhao@intel.com> <1263980478-18338-8-git-send-email-yakui.zhao@intel.com> <1263980478-18338-9-git-send-email-yakui.zhao@intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v2 9/9] drm/i915: Don't use too small watermark X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 13689b8..a97c63e 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -2191,7 +2191,7 @@ static struct intel_watermark_params pineview_cursor_hplloff_wm = { static struct intel_watermark_params g4x_wm_info = { G4X_FIFO_SIZE, G4X_MAX_WM, - G4X_MAX_WM, + 8, 2, G4X_FIFO_LINE_SIZE, WM_USE_ENTRY_COUNT, @@ -2236,7 +2236,7 @@ static struct intel_watermark_params gm965_self_cursor_info = { static struct intel_watermark_params i945_wm_info = { I945_FIFO_SIZE, I915_MAX_WM, - 1, + 8, 2, I915_FIFO_LINE_SIZE, WM_USE_OFFSET, @@ -2244,7 +2244,7 @@ static struct intel_watermark_params i945_wm_info = { static struct intel_watermark_params i915_wm_info = { I915_FIFO_SIZE, I915_MAX_WM, - 1, + 8, 2, I915_FIFO_LINE_SIZE, WM_USE_OFFSET, @@ -2252,7 +2252,7 @@ static struct intel_watermark_params i915_wm_info = { static struct intel_watermark_params i855_wm_info = { I855GM_FIFO_SIZE, I915_MAX_WM, - 1, + 8, 2, I830_FIFO_LINE_SIZE, WM_USE_OFFSET, @@ -2260,7 +2260,7 @@ static struct intel_watermark_params i855_wm_info = { static struct intel_watermark_params i830_wm_info = { I830_FIFO_SIZE, I915_MAX_WM, - 1, + 8, 2, I830_FIFO_LINE_SIZE, WM_USE_OFFSET, @@ -2356,7 +2356,7 @@ static unsigned long intel_calculate_wm(struct intel_watermark_params *wm, /* Don't promote wm_size to unsigned... */ if (wm_size > (long)wm->max_wm) wm_size = wm->max_wm; - if (wm_size <= 0) + if (wm_size < (int)wm->default_wm) wm_size = wm->default_wm; return wm_size; }