From patchwork Thu Jun 16 14:12:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Mickler X-Patchwork-Id: 887592 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5GEDXKm017681 for ; Thu, 16 Jun 2011 14:13:54 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5317FA094C for ; Thu, 16 Jun 2011 07:13:33 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mx01.d-labs.de (ist.d-labs.de [213.239.218.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 814ED9E738 for ; Thu, 16 Jun 2011 07:13:16 -0700 (PDT) Received: from schatten.dmk.lab (f053214171.adsl.alicedsl.de [78.53.214.171]) by mx01.d-labs.de (Postfix) with ESMTPSA id E02C07F807; Thu, 16 Jun 2011 16:13:10 +0200 (CEST) Received: by schatten.dmk.lab (Postfix, from userid 1000) id 57945A6C454; Thu, 16 Jun 2011 16:12:22 +0200 (CEST) From: Florian Mickler To: intel-gfx@lists.freedesktop.org Date: Thu, 16 Jun 2011 16:12:17 +0200 Message-Id: <1308233537-26489-1-git-send-email-florian@mickler.org> X-Mailer: git-send-email 1.7.5.3 Subject: [Intel-gfx] [PATCH] fix typo in 915_read_blc_pwm_ctl X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 16 Jun 2011 14:13:54 +0000 (UTC) The taken action if saveBLC_PWM_CTL2 != 0 is surprising looking only at this single function. Out of the general habit of having a 1:1 mapping between registers and save* variables, I suspect this is a typo. So here is a fix. (Don't know if this is a user-visible bug though.) Signed-off-by: Florian Mickler --- drivers/gpu/drm/i915/intel_panel.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a06ff07..459ab82 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -137,8 +137,8 @@ static u32 i915_read_blc_pwm_ctl(struct drm_i915_private *dev_priv) dev_priv->saveBLC_PWM_CTL2 = val; } else if (val == 0) { I915_WRITE(BLC_PWM_PCH_CTL2, - dev_priv->saveBLC_PWM_CTL); - val = dev_priv->saveBLC_PWM_CTL; + dev_priv->saveBLC_PWM_CTL2); + val = dev_priv->saveBLC_PWM_CTL2; } } else { val = I915_READ(BLC_PWM_CTL);