diff mbox

drm/i915: fix color order for BGR formats on IVB

Message ID 1345616234-26337-1-git-send-email-vijay.a.purushothaman@intel.com (mailing list archive)
State Rejected
Headers show

Commit Message

Vijay Purushothaman Aug. 22, 2012, 6:17 a.m. UTC 
This is already fixed for ILK and SNB but somehow IVB is missed.

Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
Signed-off-by: Ben Lin <ben.y.lin@intel.com>
---
 drivers/gpu/drm/i915/intel_sprite.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Paul Menzel Aug. 22, 2012, 7:49 a.m. UTC | #1 
Dear Vijay,


Am Mittwoch, den 22.08.2012, 11:47 +0530 schrieb Vijay Purushothaman:
> This is already fixed for ILK and SNB

… in what commits?

> but somehow IVB is missed.
> 
> Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
> Signed-off-by: Ben Lin <ben.y.lin@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_sprite.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

[…]

Please resend as [PATCH v2] with the updated commit message [1].


Thanks,

Paul


[1] http://wireless.kernel.org/en/developers/Documentation/git-guide#Annotating_new_revision
Vijay Purushothaman Aug. 22, 2012, 9:17 a.m. UTC | #2 
On 8/22/2012 1:19 PM, Paul Menzel wrote:
> Dear Vijay,
>
>
> Am Mittwoch, den 22.08.2012, 11:47 +0530 schrieb Vijay Purushothaman:
>> This is already fixed for ILK and SNB
> … in what commits?
Added the previous commit number which solved this problem on 
Sandybridge and description in the second version of the patch.

Thanks much for the review.

Thanks,
Vijay

>> but somehow IVB is missed.
>>
>> Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
>> Signed-off-by: Ben Lin <ben.y.lin@intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_sprite.c |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
> […]
>
> Please resend as [PATCH v2] with the updated commit message [1].
>
>
> Thanks,
>
> Paul
>
>
> [1] http://wireless.kernel.org/en/developers/Documentation/git-guide#Annotating_new_revision
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index cc8df4d..6045a01 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -54,17 +54,17 @@  ivb_update_plane(struct drm_plane *plane, struct drm_framebuffer *fb,
 
 	/* Mask out pixel format bits in case we change it */
 	sprctl &= ~SPRITE_PIXFORMAT_MASK;
-	sprctl &= ~SPRITE_RGB_ORDER_RGBX;
+	sprctl &= ~SPRITE_RGB_ORDER_XBGR;
 	sprctl &= ~SPRITE_YUV_BYTE_ORDER_MASK;
 	sprctl &= ~SPRITE_TILED;
 
 	switch (fb->pixel_format) {
 	case DRM_FORMAT_XBGR8888:
-		sprctl |= SPRITE_FORMAT_RGBX888;
+		sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
 		pixel_size = 4;
 		break;
 	case DRM_FORMAT_XRGB8888:
-		sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
+		sprctl |= SPRITE_FORMAT_RGBX888;
 		pixel_size = 4;
 		break;
 	case DRM_FORMAT_YUYV: