From patchwork Thu Sep 6 20:15:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 1417991 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 9221D3FC71 for ; Thu, 6 Sep 2012 21:26:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DA14A0DA2 for ; Thu, 6 Sep 2012 14:26:17 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 91F74A0D8B for ; Thu, 6 Sep 2012 14:23:11 -0700 (PDT) Received: by mail-wg0-f43.google.com with SMTP id dr1so1452538wgb.12 for ; Thu, 06 Sep 2012 14:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=OTKjZouSgE8sx9vUyNwdFgIaLCyYm+lfCUbu5nPLaoE=; b=YwFAD6NeZHpj4jw1itRHpLabrIt/TKKCILsN7pqe2ciANlI3CM8japhFDBPh8jAURo ajZ6dw99Vt4DF/yegg/erno/MSL0Fe5zH2rWOPo3elf1T9tBnnB+Rj2K+08hd0dqjc/G 4SLK4ah4hlUpVQFlpcYNhkxgPdOLZC/B3AKPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=OTKjZouSgE8sx9vUyNwdFgIaLCyYm+lfCUbu5nPLaoE=; b=Rac7mB2HAOX2TY7LCgRfyr9oz+qV65T5KtrF2AIZPrhKZ3cV6+adn3EvKLSN9RzArQ fEzMijsR0OydfUzzDYpLcDD2ElFmW48pzEy7A8bvZxDN3HcJmL7gqhHuFIlj9aJqIVeW /fY+366ePzkNqzdExD+HdXpRk11rbzJ62tg5JhWxApEspIqHur+YBdtLY0fGSM9Ej4Vw EGJHOvZ+aJE6Il9lMxZyREXegukhirhPHvmzN+oVQLgkMDRB0+aYucWuwkx8IHRebhvo IGqy14IucxnPUtYf14DGb0AqLerU6PnXyE9tVfG50ASjVJfN1tASUURsVqa9789d1opt qkMA== Received: by 10.180.84.169 with SMTP id a9mr7490032wiz.8.1346966591222; Thu, 06 Sep 2012 14:23:11 -0700 (PDT) Received: from wespe.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPS id l5sm8618787wix.5.2012.09.06.14.23.09 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 14:23:10 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Thu, 6 Sep 2012 22:15:43 +0200 Message-Id: <1346962544-7439-5-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.7.11.2 In-Reply-To: <1346962544-7439-1-git-send-email-daniel.vetter@ffwll.ch> References: <1346962544-7439-1-git-send-email-daniel.vetter@ffwll.ch> X-Gm-Message-State: ALoCoQmlQg5rRvBlplKfk1vnoxTKNjgoSic9/pnEUkW2g7jWH9hvKiKSMwj+8zcGPKt4ZJAmG4Cy Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 4/5] drm/i915: rip out dp port enabling cludges^Wchecks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org These have been added because dp links are fiddle things and don't like it when we try to re-train an enabled output (or disable a disabled output harder). And because the crtc helper code is ridiculously bad add tracking the modeset state. But with the new code in place it is simply a bug to disable a disabled encoder or to enable an enabled encoder again. Hence convert these to WARNs (and bail out for safety), but flatten all conditionals in the code itself. Signed-Off-by: Daniel Vetter Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_dp.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 7c746d1..07f9521 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -1333,15 +1333,15 @@ static void intel_enable_dp(struct intel_encoder *encoder) struct drm_i915_private *dev_priv = dev->dev_private; uint32_t dp_reg = I915_READ(intel_dp->output_reg); + if (WARN_ON(dp_reg & DP_PORT_EN)) + return; + ironlake_edp_panel_vdd_on(intel_dp); intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); - if (!(dp_reg & DP_PORT_EN)) { - intel_dp_start_link_train(intel_dp); - ironlake_edp_panel_on(intel_dp); - ironlake_edp_panel_vdd_off(intel_dp, true); - intel_dp_complete_link_train(intel_dp); - } else - ironlake_edp_panel_vdd_off(intel_dp, false); + intel_dp_start_link_train(intel_dp); + ironlake_edp_panel_on(intel_dp); + ironlake_edp_panel_vdd_off(intel_dp, true); + intel_dp_complete_link_train(intel_dp); ironlake_edp_backlight_on(intel_dp); } @@ -1913,7 +1913,7 @@ intel_dp_link_down(struct intel_dp *intel_dp) struct drm_i915_private *dev_priv = dev->dev_private; uint32_t DP = intel_dp->DP; - if ((I915_READ(intel_dp->output_reg) & DP_PORT_EN) == 0) + if (WARN_ON((I915_READ(intel_dp->output_reg) & DP_PORT_EN) == 0)) return; DRM_DEBUG_KMS("\n");