From patchwork Wed Oct 10 13:04:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Imre Deak X-Patchwork-Id: 1573581 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 68C2640135 for ; Wed, 10 Oct 2012 13:06:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EFF29E8FD for ; Wed, 10 Oct 2012 06:06:50 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id F2C849E949 for ; Wed, 10 Oct 2012 06:04:51 -0700 (PDT) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 10 Oct 2012 06:04:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,564,1344236400"; d="scan'208";a="202780210" Received: from ideak-desk.fi.intel.com (HELO localhost) ([10.237.72.98]) by azsmga001.ch.intel.com with ESMTP; 10 Oct 2012 06:04:50 -0700 From: Imre Deak To: intel-gfx@lists.freedesktop.org Date: Wed, 10 Oct 2012 16:04:39 +0300 Message-Id: <1349874285-31536-3-git-send-email-imre.deak@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1349874285-31536-1-git-send-email-imre.deak@intel.com> References: <1349874285-31536-1-git-send-email-imre.deak@intel.com> Subject: [Intel-gfx] [PATCH 2/8] fix warn in intel_error_decode: ignoring return value of 'asprintf' X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Signed-off-by: Imre Deak --- tools/intel_error_decode.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/intel_error_decode.c b/tools/intel_error_decode.c index e0ec8f6..ca03c83 100644 --- a/tools/intel_error_decode.c +++ b/tools/intel_error_decode.c @@ -49,6 +49,7 @@ #include #include #include +#include #include #include "intel_chipset.h" @@ -479,13 +480,18 @@ main (int argc, char *argv[]) } if (S_ISDIR (st.st_mode)) { - asprintf (&filename, "%s/i915_error_state", path); + int ret; + + ret = asprintf (&filename, "%s/i915_error_state", path); + assert(ret > 0); file = fopen(filename, "r"); if (!file) { int minor; for (minor = 0; minor < 64; minor++) { free(filename); - asprintf(&filename, "%s/%d/i915_error_state", path, minor); + ret = asprintf(&filename, "%s/%d/i915_error_state", path, minor); + assert(ret > 0); + file = fopen(filename, "r"); if (file) break;