diff mbox

drm/i915: do not set redundant DP dpms mode

Message ID 1351023526-28825-1-git-send-email-sque@chromium.org (mailing list archive)
State New, archived
Headers show

Commit Message

Simon Que Oct. 23, 2012, 8:18 p.m. UTC 
Add a check to intel_dp_dpms() to skip setting the DP's DPMS mode if
the current mode is the same as the new one.

Signed-off-by: Simon Que <sque@chromium.org>
---
 drivers/gpu/drm/i915/intel_dp.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Comments

Daniel Vetter Oct. 23, 2012, 8:35 p.m. UTC | #1 
On Tue, Oct 23, 2012 at 01:18:46PM -0700, Simon Que wrote:
> Add a check to intel_dp_dpms() to skip setting the DP's DPMS mode if
> the current mode is the same as the new one.
> 
> Signed-off-by: Simon Que <sque@chromium.org>

The modeset rework, merged into 3.7 solves this entire disaster rather
neatly ... We won't ever touch the hw if it's already in the desired
state.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_dp.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index c71e0f0..ba86b4f 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1311,8 +1311,13 @@ intel_dp_dpms(struct drm_encoder *encoder, int mode)
>  	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
>  	struct drm_device *dev = encoder->dev;
>  	struct drm_i915_private *dev_priv = dev->dev_private;
> +	struct drm_connector *connector;
>  	uint32_t dp_reg = I915_READ(intel_dp->output_reg);
>  
> +	list_for_each_entry(connector, &dev->mode_config.connector_list, head)
> +		if (connector->encoder == encoder && connector->dpms == mode)
> +			return;
> +
>  	if (mode != DRM_MODE_DPMS_ON) {
>  		ironlake_edp_backlight_off(intel_dp);
>  		ironlake_edp_panel_off(intel_dp);
> -- 
> 1.7.8.6
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index c71e0f0..ba86b4f 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1311,8 +1311,13 @@  intel_dp_dpms(struct drm_encoder *encoder, int mode)
 	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
 	struct drm_device *dev = encoder->dev;
 	struct drm_i915_private *dev_priv = dev->dev_private;
+	struct drm_connector *connector;
 	uint32_t dp_reg = I915_READ(intel_dp->output_reg);
 
+	list_for_each_entry(connector, &dev->mode_config.connector_list, head)
+		if (connector->encoder == encoder && connector->dpms == mode)
+			return;
+
 	if (mode != DRM_MODE_DPMS_ON) {
 		ironlake_edp_backlight_off(intel_dp);
 		ironlake_edp_panel_off(intel_dp);