From patchwork Fri Oct 26 08:58:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 1650721 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 579D8DF2F6 for ; Fri, 26 Oct 2012 09:52:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31A9F9ED8A for ; Fri, 26 Oct 2012 02:52:32 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id EAC209E831 for ; Fri, 26 Oct 2012 01:58:30 -0700 (PDT) Received: by mail-we0-f177.google.com with SMTP id u50so1276805wey.36 for ; Fri, 26 Oct 2012 01:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=mKVsmE8gCc348qSgTHrWFV4vGLErrSPlKPoMN28QsOE=; b=AFTr8IsRZ/8lB71TO4lWtpZuebdFtJo3Fk3sKQglJd3Tq98xzptvF0SIi/40BLwejV 5pFFStsxt/MYGkUQ9p+1cB6j5FQlpCuP46DgDqbSH8SZP72P+lVpgY3muTuAw/Hb1rR0 JxpO3uAJ4xvnySC431/uYv3JI5K134Rph9xC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=mKVsmE8gCc348qSgTHrWFV4vGLErrSPlKPoMN28QsOE=; b=XNW3N0afLQetHMRF1G8u2uHAJx0dikdINm4n/vehqRt6vcIHhhNddL8DVFoFsWoskE rRht0KAaThvHJIu6L7fL14+4ucfqPsJHsJIDim+WJksof0qqAZcBLtzR87dRvj8XBq7/ jrmsN3TL/ApG7N+HTfnBkFl9A/FWOhV13K4T0llGDbjiLckZ8J4+9HasqTXqfnAW53Gn V+IjskenwBm4iWFhiuesJS4rMv3MueKezx5fzK+oCGn+6D5/v4QYziCxOBmyvmrSHCKn Nh5aXvU5tnEWYZTUEtXvQcJoIJ4sNffixZwIjFX9ltj2Twf2tFFG35D2h+rqIgMUawdE VZRg== Received: by 10.216.197.133 with SMTP id t5mr12123050wen.176.1351241910032; Fri, 26 Oct 2012 01:58:30 -0700 (PDT) Received: from bremse.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPS id k20sm14217364wiv.11.2012.10.26.01.58.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Oct 2012 01:58:29 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Fri, 26 Oct 2012 10:58:16 +0200 Message-Id: <1351241899-7870-7-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1351241899-7870-1-git-send-email-daniel.vetter@ffwll.ch> References: <1351241899-7870-1-git-send-email-daniel.vetter@ffwll.ch> X-Gm-Message-State: ALoCoQkx7+82pu9huKO2BGErrxA7gX/IvXgnLqOp38WY/nxfOTW2vN/8m6qbutJqWO04f91EWKGR Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 6/9] drm/i915: BUG on impossible pch dp port X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Since it is one. We need to move this code to encoder specific callbacks eventually, to kill all that inversion of control ... Signed-off-by: Daniel Vetter Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_display.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8ab0fa5..991adc1 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -3092,9 +3092,7 @@ static void ironlake_pch_enable(struct drm_crtc *crtc) temp |= TRANS_DP_PORT_SEL_D; break; default: - DRM_DEBUG_KMS("Wrong PCH DP port return. Guess port B\n"); - temp |= TRANS_DP_PORT_SEL_B; - break; + BUG(); } I915_WRITE(reg, temp);