diff mbox

intel/aub: Actually run BLT batches on the blit ring.

Message ID 1358039004-4090-1-git-send-email-kenneth@whitecape.org (mailing list archive)
State New, archived
Headers show

Commit Message

Kenneth Graunke Jan. 13, 2013, 1:03 a.m. UTC 
We didn't set the ring flag for BLT batches, so they got run on the
render ring.  Shenanigans ensued, especially when we sent commands that
were only valid on the BLT ring.

Cc: Paul Berry <stereotype441@gmail.com>
Cc: Eric Anholt <eric@anholt.net>
---
 intel/intel_bufmgr_gem.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Eric Anholt Jan. 14, 2013, 12:49 a.m. UTC | #1 
Kenneth Graunke <kenneth@whitecape.org> writes:

> We didn't set the ring flag for BLT batches, so they got run on the
> render ring.  Shenanigans ensued, especially when we sent commands that
> were only valid on the BLT ring.

How did we get much anything to run in fulsim without this?  Are there
more commands available in the BLT ring than we thought, or have we just
not been testing apps that use blits?

Reviewed-by: Eric Anholt <eric@anholt.net>
diff mbox

Patch

diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 512bc6f..32afd73 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -2010,6 +2010,8 @@  aub_build_dump_ringbuffer(drm_intel_bufmgr_gem *bufmgr_gem,
 
 	if (ring_flag == I915_EXEC_BSD)
 		ring = AUB_TRACE_TYPE_RING_PRB1;
+	else if (ring_flag == I915_EXEC_BLT)
+		ring = AUB_TRACE_TYPE_RING_PRB2;
 
 	/* Make a ring buffer to execute our batchbuffer. */
 	memset(ringbuffer, 0, sizeof(ringbuffer));