| Message ID | 1362670228-19494-6-git-send-email-damien.lespiau@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi 2013/3/7 Damien Lespiau <damien.lespiau@intel.com>: > The port number should always be correctly set. Do the same thing as the > switch above and use BUG() to signal that branch is not supposed to be > taken. > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 3921d87..a998c3c 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -2837,8 +2837,7 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, > name = "DPDDC-D"; > break; > default: > - WARN(1, "Invalid port %c\n", port_name(port)); > - break; > + BUG(); > } > > if (is_edp(intel_dp)) > -- > 1.7.7.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Mar 22, 2013 at 06:43:40PM -0300, Paulo Zanoni wrote: > Hi > > 2013/3/7 Damien Lespiau <damien.lespiau@intel.com>: > > The port number should always be correctly set. Do the same thing as the > > switch above and use BUG() to signal that branch is not supposed to be > > taken. > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Last two patches of this series are merged to dinq, thanks. -Daniel
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3921d87..a998c3c 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -2837,8 +2837,7 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, name = "DPDDC-D"; break; default: - WARN(1, "Invalid port %c\n", port_name(port)); - break; + BUG(); } if (is_edp(intel_dp))
The port number should always be correctly set. Do the same thing as the switch above and use BUG() to signal that branch is not supposed to be taken. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)