@@ -1926,10 +1926,6 @@ static void i915_capture_error_state(struct drm_device *dev)
i915_gem_record_fences(dev, error);
i915_gem_record_rings(dev, error);
- /* Record buffers on the active and pinned lists. */
- error->active_bo = NULL;
- error->pinned_bo = NULL;
-
i = 0;
list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list)
i++;
@@ -1939,8 +1935,6 @@ static void i915_capture_error_state(struct drm_device *dev)
i++;
error->pinned_bo_count = i - error->active_bo_count;
- error->active_bo = NULL;
- error->pinned_bo = NULL;
if (i) {
error->active_bo = kmalloc(sizeof(*error->active_bo)*i,
GFP_ATOMIC);
Not only was there an extra, but since we now kzalloc the error state, we don't need either. Signed-off-by: Ben Widawsky <ben@bwidawsk.net> --- drivers/gpu/drm/i915/i915_irq.c | 6 ------ 1 file changed, 6 deletions(-)