diff mbox

CHROMIUM: enable i915 power-saving render C-state 6 by default.

Message ID 1376613069-15790-13-git-send-email-james.ausmus@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

James Ausmus Aug. 16, 2013, 12:30 a.m. UTC 
From: Todd Broch <tbroch@chromium.org>

BUG=chrome-os-partner:6768
TEST=manual,
- boot kernel
1. cat /sys/module/i915/parameters/i915_enable_rc6
  - should equal 1
2. start powertop, goto 'Idle Stats' tab
  - make sure that the Package c-states (C6, C7) are entered at some
    non-trivial percentage when system is idle

Signed-off-by: Todd Broch <tbroch@chromium.org>
Change-Id: Ib557a14e3cf20b55a6670808e681ef21b1e0ed1b
Reviewed-on: https://gerrit.chromium.org/gerrit/12280
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
---
 drivers/gpu/drm/i915/i915_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chris Wilson Aug. 16, 2013, 7:57 a.m. UTC | #1 
On Thu, Aug 15, 2013 at 05:30:37PM -0700, james.ausmus@intel.com wrote:
> From: Todd Broch <tbroch@chromium.org>
> 
> BUG=chrome-os-partner:6768
> TEST=manual,
> - boot kernel
> 1. cat /sys/module/i915/parameters/i915_enable_rc6
>   - should equal 1
> 2. start powertop, goto 'Idle Stats' tab
>   - make sure that the Package c-states (C6, C7) are entered at some
>     non-trivial percentage when system is idle
> 
> Signed-off-by: Todd Broch <tbroch@chromium.org>
> Change-Id: Ib557a14e3cf20b55a6670808e681ef21b1e0ed1b
> Reviewed-on: https://gerrit.chromium.org/gerrit/12280
> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

Drop this patch. This is incorrect against upstream.
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 1172658..cdcc7c0 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -63,8 +63,8 @@  module_param_named(semaphores, i915_semaphores, int, 0600);
 MODULE_PARM_DESC(semaphores,
 		"Use semaphores for inter-ring sync (default: -1 (use per-chip defaults))");
 
-int i915_enable_rc6 __read_mostly = -1;
-module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0400);
+int i915_enable_rc6 __read_mostly = 1;
+module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600);
 MODULE_PARM_DESC(i915_enable_rc6,
 		"Enable power-saving render C-state 6. "
 		"Different stages can be selected via bitmask values "