From patchwork Fri Oct 4 19:53:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Todd Previte X-Patchwork-Id: 2990421 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1E22DBF924 for ; Fri, 4 Oct 2013 22:50:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B823202F7 for ; Fri, 4 Oct 2013 22:50:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 2C9E8202DD for ; Fri, 4 Oct 2013 22:50:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 282CBE805C for ; Fri, 4 Oct 2013 15:50:27 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 21096E6A60 for ; Fri, 4 Oct 2013 12:52:05 -0700 (PDT) Received: by mail-pb0-f41.google.com with SMTP id rp2so4458046pbb.0 for ; Fri, 04 Oct 2013 12:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aai9Vz0ZVWyTH1CBqLY7fjVijpHDi0ku9WdN6ObYF+c=; b=hiYN4al7chVK4dvW/NopERPAsqI36+5wgFOrZId/UDgDvsMeNRJNPSe97y+fiinX3I OYZAjurk0/z7afZSNWrI8N6I5B87WkoOpu6njz5eMyWsXQjpUaQ/zMFIq+L4R6jYAUwh veJHynuDi6YI68l9aW/5YKCMMjzaeG8b6brQAsBwnv3x9iW/oWYJYgRT1L6SL8AIdVRW Fp2EAatk3TtYeK7gletDuC8f+uEDyaEanYOlxto07ATqZvqstvdYj47D9nhohGBX6obn RwzuZlG9dh/0j+re7/pBrqz5WfxvVAI6quz9zBtzuJYEbSSzmf+loyw40Tv/LtkMnqtS 79pg== X-Received: by 10.67.23.227 with SMTP id id3mr17557138pad.101.1380916324860; Fri, 04 Oct 2013 12:52:04 -0700 (PDT) Received: from localhost.localdomain (udp116074uds.hawaiiantel.net. [72.235.203.227]) by mx.google.com with ESMTPSA id ef10sm20160869pac.1.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Oct 2013 12:52:03 -0700 (PDT) From: Todd Previte To: intel-gfx@lists.freedesktop.org Date: Fri, 4 Oct 2013 12:53:27 -0700 Message-Id: <1380916407-20210-1-git-send-email-tprevite@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1380882730-32207-1-git-send-email-tprevite@gmail.com> References: <1380882730-32207-1-git-send-email-tprevite@gmail.com> Subject: [Intel-gfx] [PATCH V2] drm/i915: Implement Displayport automated testing X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This initial patch adds support for automated testing of the source device to the i915 driver. Most of this patch is infrastructure for the tests; follow up patches will add support for the individual tests with updates to ACK the tests that are supported (or NAK if the test fails/is unsupported). Signed-off-by: Todd Previte --- drivers/gpu/drm/i915/intel_dp.c | 75 +++++++++++++++++++++++++++++++++++++++-- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9770160..1f97a1c 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -2730,11 +2730,80 @@ intel_dp_get_sink_irq(struct intel_dp *intel_dp, u8 *sink_irq_vector) return true; } +/* Automated test function hook - description forthcoming */ +static bool +intel_dp_autotest_link_training(struct intel_dp *intel_dp) +{ + bool test_result = false; + return test_result; +} + +/* Automated test function hook - description forthcoming */ +static bool +intel_dp_autotest_video_pattern(struct intel_dp *intel_dp) +{ + bool test_result = false; + return test_result; +} + +/* Automated test function hook - description forthcoming */ +static bool +intel_dp_autotest_edid(struct intel_dp *intel_dp) +{ + bool test_result = false; + return test_result; +} + +/* Automated test function hook - description forthcoming */ +static bool +intel_dp_autotest_phy_pattern(struct intel_dp *intel_dp) +{ + bool test_result = false; + return test_result; +} + static void intel_dp_handle_test_request(struct intel_dp *intel_dp) -{ - /* NAK by default */ - intel_dp_aux_native_write_1(intel_dp, DP_TEST_RESPONSE, DP_TEST_NAK); +{ + uint8_t response = DP_TEST_NAK; + bool result = false; + uint8_t rxdata = 0; + + printk(KERN_DEBUG "Displayport: Recvd automated test request\n"); + /* Read DP_TEST_REQUEST register to identify the requested test */ + intel_dp_aux_native_read_retry(intel_dp, DP_TEST_REQUEST, &rxdata, 1); + /* Determine which test has been requested */ + switch (rxdata) { + /* ACK/NAK response based on the success or failure of the specified + automated test function. Unimplemented tests will NAK as will those + that are unsupported. */ + case DP_TEST_LINK_TRAINING: + printk(KERN_DEBUG "Displayport: Executing LINK_TRAINING request\n"); + result = intel_dp_autotest_link_training(intel_dp); + break; + case DP_TEST_LINK_PATTERN: + printk(KERN_DEBUG "Displayport: Executing TEST_PATTERN request\n"); + result = intel_dp_autotest_video_pattern(intel_dp); + break; + case DP_TEST_LINK_EDID_READ: + printk(KERN_DEBUG "Displayport: Executing EDID request\n"); + result = intel_dp_autotest_edid(intel_dp); + break; + case DP_TEST_LINK_PHY_TEST_PATTERN: + printk(KERN_DEBUG "Displayport: Executing PHY_PATTERN request\n"); + result = intel_dp_autotest_phy_pattern(intel_dp); + break; + /* Unsupported test case or something went wrong */ + default: + /* Log error here for unhandled test request */ + printk(KERN_DEBUG "Displayport: Error - unhandled automated test type\n"); + break; + } + /* Check for a valid test execution */ + if (result == true) + response = DP_TEST_ACK; + /* Send ACK/NAK based on action taken above */ + intel_dp_aux_native_write_1(intel_dp, DP_TEST_RESPONSE, response); } /*