From patchwork Mon Nov 11 15:36:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: oscar.mateo@intel.com X-Patchwork-Id: 3168001 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4A4EAC045B for ; Mon, 11 Nov 2013 15:42:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AFA3E2017A for ; Mon, 11 Nov 2013 15:42:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 7820520164 for ; Mon, 11 Nov 2013 15:42:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87A52FAB16; Mon, 11 Nov 2013 07:42:06 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A59BFAAF0 for ; Mon, 11 Nov 2013 07:42:03 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 11 Nov 2013 07:42:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,678,1378882800"; d="scan'208";a="431385542" Received: from omateolo-haswell.isw.intel.com ([10.102.226.75]) by fmsmga002.fm.intel.com with ESMTP; 11 Nov 2013 07:41:59 -0800 From: oscar.mateo@intel.com To: intel-gfx@lists.freedesktop.org Date: Mon, 11 Nov 2013 15:36:55 +0000 Message-Id: <1384184215-19252-1-git-send-email-oscar.mateo@intel.com> X-Mailer: git-send-email 1.7.9.5 Subject: [Intel-gfx] [PATCH] tests/drv_suspend: Replace "&> /dev/null" with "> /dev/null 2>&1" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Oscar Mateo Some shells do not understand "&>". For instance, my Ubuntu 12.04 machine has /bin/sh pointing to dash, which makes a mess out of "&>" (to the point that the helper processes cannot be killed). Signed-off-by: Oscar Mateo --- tests/drv_suspend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/drv_suspend.c b/tests/drv_suspend.c index e526e2a..9b3df2b 100644 --- a/tests/drv_suspend.c +++ b/tests/drv_suspend.c @@ -106,7 +106,7 @@ test_debugfs_reader(void) static char tmp[1024]; snprintf(tmp, sizeof(tmp) - 1, - "while true; do find %s/%i/ -type f | xargs cat &> /dev/null; done", + "while true; do find %s/%i/ -type f | xargs cat > /dev/null 2>&1; done", dfs_base, drm_get_card()); assert(execl("/bin/sh", "sh", "-c", tmp, (char *) NULL) != -1); } @@ -131,7 +131,7 @@ test_sysfs_reader(void) static char tmp[1024]; snprintf(tmp, sizeof(tmp) - 1, - "while true; do find %s%i*/ -type f | xargs cat &> /dev/null; done", + "while true; do find %s%i*/ -type f | xargs cat > /dev/null 2>&1; done", dfs_base, drm_get_card()); assert(execl("/bin/sh", "sh", "-c", tmp, (char *) NULL) != -1); }