From patchwork Mon Dec 2 13:26:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 3265451 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D3B3B9F373 for ; Mon, 2 Dec 2013 13:26:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9D66020260 for ; Mon, 2 Dec 2013 13:26:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3132C20253 for ; Mon, 2 Dec 2013 13:26:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66511FAC9A; Mon, 2 Dec 2013 05:26:42 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qe0-f47.google.com (mail-qe0-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A16DFAC9A for ; Mon, 2 Dec 2013 05:26:40 -0800 (PST) Received: by mail-qe0-f47.google.com with SMTP id t7so13043967qeb.20 for ; Mon, 02 Dec 2013 05:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7HiptXuHpf3GbFuSSZp1ruh/UqNCg6e5ADpbBg8FSiA=; b=v4iHxncpGMvsJ8OV8jmCdqAIu1yO0OyWgA95daf+P/NFZqgfWbAuhZ4IXkF4rGozfr OIuNNgs82/FDCRb8KKcOY5LWxsI8tGYB3TBd95vEa69XZsb7O+TFjnoGaKN5DrF9VBn0 NuoaLAgqX6N31kNXrbYMABrCHIhYp6olC+nBhqN495WdYBHxrgNPYVk+iPOLd1tsuhF7 t05nSfWPnlDE3BIAnipuQ/O+KfMNxcHuNhKUpFlxkhZzNEUixtfHYiqlN50FLzV2PEPD 2x5vXubj0jYIhpRZRi59+pRsYNpN9anYED/yyLYOrX5xTmroB/tls12LbKTGsdemT8/4 6J5Q== X-Received: by 10.224.57.68 with SMTP id b4mr114839727qah.63.1385990799974; Mon, 02 Dec 2013 05:26:39 -0800 (PST) Received: from localhost.localdomain (200.188.217.18.dedicated.neoviatelecom.com.br. [200.188.217.18]) by mx.google.com with ESMTPSA id x10sm123248366qas.5.2013.12.02.05.26.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Dec 2013 05:26:39 -0800 (PST) From: Rodrigo Vivi To: intel-gfx@lists.freedesktop.org Date: Mon, 2 Dec 2013 11:26:08 -0200 Message-Id: <1385990771-3877-4-git-send-email-rodrigo.vivi@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1385990771-3877-1-git-send-email-rodrigo.vivi@gmail.com> References: <1385990771-3877-1-git-send-email-rodrigo.vivi@gmail.com> Subject: [Intel-gfx] [PATCH 3/6] drm/i915: Downgrade pipe state mismatches to DRM_DEBUG_KMS X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Adam Jackson This is, by far, the most common kernel retrace in i915 I'm seeing: https://retrace.fedoraproject.org/faf/problems/1346879/ There's not enough information in the backtrace to know if something actually went wrong or if this is just an assertion failure, so it's pretty useless. Downgrade this to DRM_DEBUG_KMS so we can still see it if we want it. Signed-off-by: Adam Jackson Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 035588a..a403611 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9463,7 +9463,7 @@ check_crtc_state(struct drm_device *dev) if (active && !intel_pipe_config_compare(dev, &crtc->config, &pipe_config)) { - WARN(1, "pipe state doesn't match!\n"); + DRM_DEBUG_KMS("pipe state doesn't match!\n"); intel_dump_pipe_config(crtc, &pipe_config, "[hw state]"); intel_dump_pipe_config(crtc, &crtc->config,