From patchwork Mon Dec 9 12:43:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 3310821 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 903579F37C for ; Mon, 9 Dec 2013 12:43:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7D33D2023F for ; Mon, 9 Dec 2013 12:43:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 62758201EF for ; Mon, 9 Dec 2013 12:43:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 42579FAE83; Mon, 9 Dec 2013 04:43:12 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qe0-f53.google.com (mail-qe0-f53.google.com [209.85.128.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 62F10FB2BB for ; Mon, 9 Dec 2013 04:43:10 -0800 (PST) Received: by mail-qe0-f53.google.com with SMTP id nc12so2753035qeb.12 for ; Mon, 09 Dec 2013 04:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=W0l+Y1l91yEYSLsoLu9KUJQpu0DzlhZjNMKQq92w6vc=; b=hvEwX7DHgSJe9xR1TfrwY+m0i903OXCL2u5Rj2RFJ4W9vOZhcbRQeQcvITBx+QjiNu sXTFAXWZY+5Mbinr99nuWA21BMphg07GE1p0BJhBz7lRl/wkbSgXcArIA2t2VcWgCWMM KcIhEPC2JsZdtOfbjIjGmGdDJUfBNL1X2IB/Edtjzu6ZU9x+zYAa2WDEtQRP5w3uP5nl wwZ1QRdki1NicPXt1tS52gZklZEHbs1JYBUCFzdkhhonBXVczQxkLEmiQC2EEmHVVoYL ssCSsrMcln+L0nRCgsiSmzuB5nrHTdwVS37Q6Y5Z7jNOrEQcGP67+3OWogqSr3FfKEjP dywA== X-Received: by 10.229.219.5 with SMTP id hs5mr32380892qcb.9.1386592990004; Mon, 09 Dec 2013 04:43:10 -0800 (PST) Received: from localhost.localdomain (200.188.217.18.dedicated.neoviatelecom.com.br. [200.188.217.18]) by mx.google.com with ESMTPSA id u17sm29462116qeb.4.2013.12.09.04.43.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Dec 2013 04:43:09 -0800 (PST) From: Rodrigo Vivi To: intel-gfx@lists.freedesktop.org Date: Mon, 9 Dec 2013 10:43:02 -0200 Message-Id: <1386592983-3529-8-git-send-email-rodrigo.vivi@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1386592983-3529-1-git-send-email-rodrigo.vivi@gmail.com> References: <1386592983-3529-1-git-send-email-rodrigo.vivi@gmail.com> Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 7/8] drm/i915: Only use read-back pipe config X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Vetter This way we'll catch bugs in our code where we depend upon pipe config state not (yet) read out much quicker, through a simple dpms on/off cycle. This will blow up all over the place for now, hence just a quick idea to toss out there. Signed-off-by: Daniel Vetter Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 035588a..af62fcb 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9469,6 +9469,9 @@ check_crtc_state(struct drm_device *dev) intel_dump_pipe_config(crtc, &crtc->config, "[sw state]"); } + + /* Make sure our code only depends upon stuff we read back. */ + memcpy(&pipe_config, &crtc->config, sizeof(pipe_config)); } }