From patchwork Wed Jan 15 19:07:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 3493451 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BF60B9F2E9 for ; Wed, 15 Jan 2014 19:07:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D173A20155 for ; Wed, 15 Jan 2014 19:07:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B25FE20149 for ; Wed, 15 Jan 2014 19:07:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3642B10DE4D; Wed, 15 Jan 2014 11:07:52 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qe0-f42.google.com (mail-qe0-f42.google.com [209.85.128.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 4213110DC1C for ; Wed, 15 Jan 2014 11:07:47 -0800 (PST) Received: by mail-qe0-f42.google.com with SMTP id b4so1569177qen.1 for ; Wed, 15 Jan 2014 11:07:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=brgwiILEesyLXeewFKuaTeZMf96+AzjF4waxIdmTRsM=; b=i2Vb6Tyr+kdf96b/A/ThcQJzB2Tkbz0nKjRe7AjrkoWrHpZxG0k4BJB+eTRmgf+v1a pcZvUxwix6fG1ZrdlyR3mA5SsWCZnFLnpoS4DuwWk5riH+0DOFBQ7IxnX83mP3RLvj77 OojCuhutB3FHEuC06dIswyQGiDrg6PF75kMbFieSD/LmtGMQJ8Fnq9BLabBOgrqmixdw cRQyJdqKdnW/c0OJmFjZQ0csKeBX4T4OoXKbLowh4EODxjYBcB6+zQ09a+kaKh8tdvdN qDui0NhEo/19QnIVYiwxOvQPPR5PkCXgrTibi9b4BT3FuwlI7TXkJxbXUWSItVNYveF9 b9sQ== X-Received: by 10.224.20.9 with SMTP id d9mr7653895qab.100.1389812866791; Wed, 15 Jan 2014 11:07:46 -0800 (PST) Received: from localhost.localdomain ([177.111.47.151]) by mx.google.com with ESMTPSA id r4sm8070898qeu.20.2014.01.15.11.07.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jan 2014 11:07:46 -0800 (PST) From: Rodrigo Vivi To: intel-gfx@lists.freedesktop.org Date: Wed, 15 Jan 2014 17:07:29 -0200 Message-Id: <1389812850-4913-2-git-send-email-rodrigo.vivi@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1389812850-4913-1-git-send-email-rodrigo.vivi@gmail.com> References: <1389812850-4913-1-git-send-email-rodrigo.vivi@gmail.com> Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Only use read-back pipe config X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Vetter This way we'll catch bugs in our code where we depend upon pipe config state not (yet) read out much quicker, through a simple dpms on/off cycle. This will blow up all over the place for now, hence just a quick idea to toss out there. Signed-off-by: Daniel Vetter Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e77d4b8..5c6b148 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9517,6 +9517,9 @@ check_crtc_state(struct drm_device *dev) intel_dump_pipe_config(crtc, &crtc->config, "[sw state]"); } + + /* Make sure our code only depends upon stuff we read back. */ + memcpy(&pipe_config, &crtc->config, sizeof(pipe_config)); } }