From patchwork Fri Feb 21 15:32:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Kuoppala X-Patchwork-Id: 3698011 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 18EFC9F502 for ; Fri, 21 Feb 2014 15:31:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2078620122 for ; Fri, 21 Feb 2014 15:31:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 5172520120 for ; Fri, 21 Feb 2014 15:31:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6593FB54A; Fri, 21 Feb 2014 07:31:52 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id D853EFB545 for ; Fri, 21 Feb 2014 07:31:50 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 21 Feb 2014 07:27:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,519,1389772800"; d="scan'208";a="459503343" Received: from rosetta.fi.intel.com ([10.237.72.72]) by orsmga001.jf.intel.com with ESMTP; 21 Feb 2014 07:31:49 -0800 From: mika.kuoppala@intel.com To: intel-gfx@lists.freedesktop.org Date: Fri, 21 Feb 2014 17:32:02 +0200 Message-Id: <1392996723-8886-5-git-send-email-mika.kuoppala@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1392996723-8886-1-git-send-email-mika.kuoppala@intel.com> References: <1392996723-8886-1-git-send-email-mika.kuoppala@intel.com> Cc: miku@iki.fi, Mika Kuoppala Subject: [Intel-gfx] [PATCH 4/5] drm/i915: Always set fifo count to zero in gen6_reset X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Mika Kuoppala There should not be a case where fifo count is other than zero after a successful reset. Always set count to zero, but be paranoid enough to warn. Suggested-by: Ben Widawsky Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_uncore.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 5ce8282..ae068c1 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -975,11 +975,11 @@ static int gen6_do_reset(struct drm_device *dev) else dev_priv->uncore.funcs.force_wake_put(dev_priv, FORCEWAKE_ALL); - /* Restore fifo count */ if (IS_GEN6(dev) || IS_GEN7(dev)) - dev_priv->uncore.fifo_count = - __raw_i915_read32(dev_priv, GTFIFOCTL) & - GT_FIFO_FREE_ENTRIES_MASK; + WARN_ON((__raw_i915_read32(dev_priv, GTFIFOCTL) & + GT_FIFO_FREE_ENTRIES_MASK) != 0); + + dev_priv->uncore.fifo_count = 0; spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags); return ret;