From patchwork Tue Apr 22 22:55:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 4036931 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E6DC89F319 for ; Tue, 22 Apr 2014 22:56:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 317FE20211 for ; Tue, 22 Apr 2014 22:56:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3FAFD201EF for ; Tue, 22 Apr 2014 22:56:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DAC706E974; Tue, 22 Apr 2014 15:56:13 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-yk0-f175.google.com (mail-yk0-f175.google.com [209.85.160.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 30E6D6E972 for ; Tue, 22 Apr 2014 15:56:09 -0700 (PDT) Received: by mail-yk0-f175.google.com with SMTP id 131so140072ykp.20 for ; Tue, 22 Apr 2014 15:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=X5CwzRvIR+WO7jT+7UwBBab9Q/5P1AEDjCekh6IWeCw=; b=C8dxu/m836riijgvgS/Al0nWqowJT1du8JZf8jYmuV75GTyPWgw049P71WWuH9tl+z U4wbX3HfqVXC/PNGENJ/MKtaMdGKX/pz+CjxAW+3B53aYv/LPBe+UhGC9LCSvyQDza9A hfUr/QzmtSrGm6MA8atapkmLrZmfxdLDHFfAF/5WzPjntKt9l1w0EiwANMDh6xLSURUO cwRMFer7sEqS7SC1nDohj5gju7RA/jOitaCbmUQMIREeTJsIFfgL/p2dpg3LduOFWFPB IoW5gRbtjqnsSlolwtsoPKzQ/eneMd6hwoQrCDF3N9iUlZyRylrAklHmIHOWcKr2WkaL 71Qg== X-Received: by 10.236.148.143 with SMTP id v15mr65892881yhj.58.1398207368691; Tue, 22 Apr 2014 15:56:08 -0700 (PDT) Received: from localhost.localdomain ([177.156.79.173]) by mx.google.com with ESMTPSA id 63sm81337973yhi.13.2014.04.22.15.56.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Apr 2014 15:56:08 -0700 (PDT) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Tue, 22 Apr 2014 19:55:45 -0300 Message-Id: <1398207345-1865-4-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1398207345-1865-1-git-send-email-przanoni@gmail.com> References: <20140411132123.GH9262@phenom.ffwll.local> <1398207345-1865-1-git-send-email-przanoni@gmail.com> Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH 4/4] drm/i915: remove useless runtime PM get call X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni We already call intel_dp_power_get, which will get a power domain, and every power domain should get a runtime PM reference, which will wake up the machine. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_dp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index a25f708..a0b1cda 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -3171,11 +3171,9 @@ intel_dp_detect(struct drm_connector *connector, bool force) struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); struct intel_encoder *intel_encoder = &intel_dig_port->base; struct drm_device *dev = connector->dev; - struct drm_i915_private *dev_priv = dev->dev_private; enum drm_connector_status status; struct edid *edid = NULL; - intel_runtime_pm_get(dev_priv); intel_dp_power_get(intel_encoder); DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", @@ -3209,7 +3207,6 @@ intel_dp_detect(struct drm_connector *connector, bool force) out: intel_dp_power_put(intel_encoder); - intel_runtime_pm_put(dev_priv); return status; }