| Message ID | 1401926970-1900-1-git-send-email-rodrigo.vivi@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 04, 2014 at 05:09:30PM -0700, Rodrigo Vivi wrote: > BDW uses IVB cursor offsets. > > Whithout this patch it is not possible to use multiple outputs with cursor > on BDW. > The cursor gets completely crazy because update position uses the wrong > cursor register for the second pipe. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com> Reviewed-by: Ben Widawsky <ben@bwidawsk.net> Should be cc: stable IMO [snip]
I just noticed and verified this patch fixes this bug: https://bugs.freedesktop.org/show_bug.cgi?id=79621 On Wed, Jun 4, 2014 at 5:16 PM, Ben Widawsky <ben@bwidawsk.net> wrote: > On Wed, Jun 04, 2014 at 05:09:30PM -0700, Rodrigo Vivi wrote: > > BDW uses IVB cursor offsets. > > > > Whithout this patch it is not possible to use multiple outputs with > cursor > > on BDW. > > The cursor gets completely crazy because update position uses the wrong > > cursor register for the second pipe. > > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net> > > Should be cc: stable IMO > [snip] > > -- > Ben Widawsky, Intel Open Source Technology Center >
On Wed, Jun 04, 2014 at 05:16:25PM -0700, Ben Widawsky wrote: > On Wed, Jun 04, 2014 at 05:09:30PM -0700, Rodrigo Vivi wrote: > > BDW uses IVB cursor offsets. > > > > Whithout this patch it is not possible to use multiple outputs with cursor > > on BDW. > > The cursor gets completely crazy because update position uses the wrong > > cursor register for the second pipe. > > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net> Thanks. > > Should be cc: stable IMO > [snip] Agreed. -Daniel
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index f9cd5ff..615b62f 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -315,6 +315,7 @@ static const struct intel_device_info intel_broadwell_m_info = { .has_ddi = 1, .has_fbc = 1, GEN_DEFAULT_PIPEOFFSETS, + IVB_CURSOR_OFFSETS, }; static const struct intel_device_info intel_broadwell_gt3d_info = { @@ -325,6 +326,7 @@ static const struct intel_device_info intel_broadwell_gt3d_info = { .has_ddi = 1, .has_fbc = 1, GEN_DEFAULT_PIPEOFFSETS, + IVB_CURSOR_OFFSETS, }; static const struct intel_device_info intel_broadwell_gt3m_info = {
BDW uses IVB cursor offsets. Whithout this patch it is not possible to use multiple outputs with cursor on BDW. The cursor gets completely crazy because update position uses the wrong cursor register for the second pipe. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com> --- drivers/gpu/drm/i915/i915_drv.c | 2 ++ 1 file changed, 2 insertions(+)