From patchwork Fri Jul 4 14:59:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 4481671 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3FDEA9F26C for ; Fri, 4 Jul 2014 15:00:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 511BC20260 for ; Fri, 4 Jul 2014 15:00:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 80733201F4 for ; Fri, 4 Jul 2014 15:00:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8A586E800; Fri, 4 Jul 2014 08:00:07 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-yh0-f46.google.com (mail-yh0-f46.google.com [209.85.213.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 5229B6E800 for ; Fri, 4 Jul 2014 08:00:06 -0700 (PDT) Received: by mail-yh0-f46.google.com with SMTP id c41so721352yho.5 for ; Fri, 04 Jul 2014 08:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=6PuGHdNcpi3dOj2I1kQz55lOWBcZCM8Tn8VDtf83w1w=; b=tTjEBqyXo1jpvM0zfmN0B9LC69hLePziV6f99B4JZCrrlVq9ZxYO39HO2jd+tWmTk5 LPmV7bhPWnsYPbL+Km6J1VCpDTQMGXLaIXeuTVIbbLCYvA7x14AwhoWCIOhLLhpZt7q8 ogboBW794rfOewy/8NZHRcgSi69qMUBXG8W6G1Xa0dgjRC4nqvkDTcOjw82JeYhql3IS brjv2Vn+c6TGo7JMxQMiz/tv/DyjAdp738Tn41rAA6gYeHKA75pQYQbMhtt7nDeeBqBc tV7YUVwHRvFjk8+o3L5W+mgC5r1dpl+9Z+KEGsERX8RVMCNn4uU6phLCDdZ20oeKFp7Y 399A== X-Received: by 10.236.2.165 with SMTP id 25mr3362549yhf.136.1404486005846; Fri, 04 Jul 2014 08:00:05 -0700 (PDT) Received: from localhost.localdomain ([177.16.191.220]) by mx.google.com with ESMTPSA id a66sm46790891yhe.56.2014.07.04.08.00.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Jul 2014 08:00:05 -0700 (PDT) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Fri, 4 Jul 2014 11:59:57 -0300 Message-Id: <1404485998-4580-1-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 2.0.0 Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH 1/2] drm/i915: fix hsw_write_dcomp() error message X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni That function can be used to write anything on D_COMP, not just disable it, so print a more appropriate message. Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c12a5da..6986594 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -7370,7 +7370,7 @@ static void hsw_write_dcomp(struct drm_i915_private *dev_priv, uint32_t val) mutex_lock(&dev_priv->rps.hw_lock); if (sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_D_COMP, val)) - DRM_ERROR("Failed to disable D_COMP\n"); + DRM_ERROR("Failed to write to D_COMP\n"); mutex_unlock(&dev_priv->rps.hw_lock); } else { I915_WRITE(D_COMP, val);