diff mbox

drm/i915: Fix semaphore_seqno and semaphore_mboxes sizes

Message ID 1405598446-9827-1-git-send-email-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rodrigo Vivi July 17, 2014, noon UTC
Otherwise some iteractions depending on the current number of active rings could overflow.

Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rodrigo Vivi July 17, 2014, 7:11 p.m. UTC | #1
just ignore this one..


On Thu, Jul 17, 2014 at 5:00 AM, Rodrigo Vivi <rodrigo.vivi@intel.com>
wrote:

> Otherwise some iteractions depending on the current number of active rings
> could overflow.
>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h
> index 2b8308d..190f0e5 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -342,7 +342,7 @@ struct drm_i915_error_state {
>                 u32 cpu_ring_head;
>                 u32 cpu_ring_tail;
>
> -               u32 semaphore_seqno[I915_NUM_RINGS - 1];
> +               u32 semaphore_seqno[I915_NUM_RINGS];
>
>                 /* Register state */
>                 u32 tail;
> @@ -361,7 +361,7 @@ struct drm_i915_error_state {
>                 u32 fault_reg;
>                 u64 faddr;
>                 u32 rc_psmi; /* sleep state */
> -               u32 semaphore_mboxes[I915_NUM_RINGS - 1];
> +               u32 semaphore_mboxes[I915_NUM_RINGS];
>
>                 struct drm_i915_error_object {
>                         int page_count;
> --
> 1.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 2b8308d..190f0e5 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -342,7 +342,7 @@  struct drm_i915_error_state {
 		u32 cpu_ring_head;
 		u32 cpu_ring_tail;
 
-		u32 semaphore_seqno[I915_NUM_RINGS - 1];
+		u32 semaphore_seqno[I915_NUM_RINGS];
 
 		/* Register state */
 		u32 tail;
@@ -361,7 +361,7 @@  struct drm_i915_error_state {
 		u32 fault_reg;
 		u64 faddr;
 		u32 rc_psmi; /* sleep state */
-		u32 semaphore_mboxes[I915_NUM_RINGS - 1];
+		u32 semaphore_mboxes[I915_NUM_RINGS];
 
 		struct drm_i915_error_object {
 			int page_count;