| Message ID | 1409794206-2126-5-git-send-email-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 03, 2014 at 09:29:59PM -0400, Rodrigo Vivi wrote: > Just to make life easier and be eable to easily test with > PSR disabled to know exactly what to expect when running it > for real > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > tests/kms_psr_sink_crc.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c > index 0917a7f..01521bb 100644 > --- a/tests/kms_psr_sink_crc.c > +++ b/tests/kms_psr_sink_crc.c > @@ -57,6 +57,11 @@ enum tests { > TEST_SPRITE, > }; > > +#define DEBUG_CRC 0 > + > +/* This is usefull to debug and know what should be expected */ > +#define RUNNING_WITH_PSR_DISABLED 0 > + > typedef struct { > int drm_fd; > enum tests test; > @@ -264,6 +269,9 @@ static bool psr_enabled(data_t *data) > FILE *file; > char str[4]; > > + if (RUNNING_WITH_PSR_DISABLED) > + return true; > + > file = igt_debugfs_fopen("i915_edp_psr_status", "r"); > igt_require(file); > > @@ -284,6 +292,9 @@ static bool psr_active(data_t *data) > FILE *file; > char str[4]; > > + if (RUNNING_WITH_PSR_DISABLED) > + return true; > + > file = igt_debugfs_fopen("i915_edp_psr_status", "r"); > igt_require(file); > > @@ -327,6 +338,16 @@ static void get_sink_crc(data_t *data, char *crc) { > igt_require(ret > 0); > > fclose(file); > + > + if (DEBUG_CRC) { > + fprintf(stderr, "%s\n", crc); > + sleep(1); > + } igt_debug is your friend here. Can be used with IGT_LOG_LEVEL=debug <testcase> All other tests and all the libraries use this infrastructure already. Btw if you think the crc library is missing useful debug output then please add a few igt_debug in good places there. Thanks, Daniel > + > + /* The important value was already taken. > + * Now give a time for human eyes > + */ > + usleep(300000); > } > > static void test_crc(data_t *data) > @@ -342,7 +363,6 @@ static void test_crc(data_t *data) > 1, 1) == 0); > } > > - usleep(300000); > igt_assert(wait_psr_entry(data, 10)); > get_sink_crc(data, ref_crc); > > -- > 1.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 0917a7f..01521bb 100644 --- a/tests/kms_psr_sink_crc.c +++ b/tests/kms_psr_sink_crc.c @@ -57,6 +57,11 @@ enum tests { TEST_SPRITE, }; +#define DEBUG_CRC 0 + +/* This is usefull to debug and know what should be expected */ +#define RUNNING_WITH_PSR_DISABLED 0 + typedef struct { int drm_fd; enum tests test; @@ -264,6 +269,9 @@ static bool psr_enabled(data_t *data) FILE *file; char str[4]; + if (RUNNING_WITH_PSR_DISABLED) + return true; + file = igt_debugfs_fopen("i915_edp_psr_status", "r"); igt_require(file); @@ -284,6 +292,9 @@ static bool psr_active(data_t *data) FILE *file; char str[4]; + if (RUNNING_WITH_PSR_DISABLED) + return true; + file = igt_debugfs_fopen("i915_edp_psr_status", "r"); igt_require(file); @@ -327,6 +338,16 @@ static void get_sink_crc(data_t *data, char *crc) { igt_require(ret > 0); fclose(file); + + if (DEBUG_CRC) { + fprintf(stderr, "%s\n", crc); + sleep(1); + } + + /* The important value was already taken. + * Now give a time for human eyes + */ + usleep(300000); } static void test_crc(data_t *data) @@ -342,7 +363,6 @@ static void test_crc(data_t *data) 1, 1) == 0); } - usleep(300000); igt_assert(wait_psr_entry(data, 10)); get_sink_crc(data, ref_crc);
Just to make life easier and be eable to easily test with PSR disabled to know exactly what to expect when running it for real Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- tests/kms_psr_sink_crc.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)