From patchwork Wed Sep 10 21:09:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Packard X-Patchwork-Id: 4880811 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A9BD29F3AE for ; Wed, 10 Sep 2014 21:09:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0AD2201C8 for ; Wed, 10 Sep 2014 21:09:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 16C6120173 for ; Wed, 10 Sep 2014 21:09:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 96DCF6E48D; Wed, 10 Sep 2014 14:09:18 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 9397789FC8; Wed, 10 Sep 2014 14:09:17 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by keithp.com (Postfix) with ESMTP id 4FEB576014A; Wed, 10 Sep 2014 14:09:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from keithp.com ([127.0.0.1]) by localhost (keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id h8LWvZEuJ_H0; Wed, 10 Sep 2014 14:09:14 -0700 (PDT) Received: by keithp.com (Postfix, from userid 1033) id 1683176013F; Wed, 10 Sep 2014 14:09:13 -0700 (PDT) Received: from hiro.keithp.com (localhost [127.0.0.1]) by keithp.com (Postfix) with ESMTP id DDBCF760148; Wed, 10 Sep 2014 14:09:13 -0700 (PDT) Received: by hiro.keithp.com (Postfix, from userid 1001) id 697DA7490E8; Wed, 10 Sep 2014 14:09:13 -0700 (PDT) From: Keith Packard To: xorg-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Wed, 10 Sep 2014 14:09:08 -0700 Message-Id: <1410383349-27678-2-git-send-email-keithp@keithp.com> X-Mailer: git-send-email 2.0.1 In-Reply-To: <1410383349-27678-1-git-send-email-keithp@keithp.com> References: <1410383349-27678-1-git-send-email-keithp@keithp.com> Subject: [Intel-gfx] [PATCH 1/2] Do not clear pending kernel events on mode switch X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Let the kernel send these back to us so that DIX hears about them in the usual way. Mode setting while Present has a flip active will trigger an unflip before the mode is changed. The event from that unflip will not get processed before the mode switch is executed. Clearing the driver queue at mode switch time will discard the connection between the kernel event and the present callback so that DIX will never know that the flip pixmap is idle. Signed-off-by: Keith Packard --- src/uxa/intel_display.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/uxa/intel_display.c b/src/uxa/intel_display.c index 97af76d..8c43ae9 100644 --- a/src/uxa/intel_display.c +++ b/src/uxa/intel_display.c @@ -71,9 +71,6 @@ struct intel_drm_queue { intel_drm_abort_proc abort; }; -static void -intel_drm_abort_scrn(ScrnInfoPtr scrn); - static uint32_t intel_drm_seq; static struct list intel_drm_queue; @@ -398,7 +395,6 @@ intel_crtc_apply(xf86CrtcPtr crtc) if (scrn->pScreen) xf86_reload_cursors(scrn->pScreen); - intel_drm_abort_scrn(scrn); done: free(output_ids);