| Message ID | 1410468135-14639-1-git-send-email-gustavo@padovan.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 11 Sep 2014, Gustavo Padovan <gustavo@padovan.org> wrote: > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > 7e4bf45dbd99a965c7b5d5944c6dc4246f171eb5 introduced the regression. > We fix it by doing the right assignment of crtc_y > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83747 > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Thanks for the quick fix. Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/intel_sprite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c > index 90bb45f..78044bb 100644 > --- a/drivers/gpu/drm/i915/intel_sprite.c > +++ b/drivers/gpu/drm/i915/intel_sprite.c > @@ -1080,7 +1080,7 @@ intel_commit_sprite_plane(struct drm_plane *plane, > > if (state->visible) { > crtc_x = state->dst.x1; > - crtc_y = state->dst.x2; > + crtc_y = state->dst.y1; > crtc_w = drm_rect_width(&state->dst); > crtc_h = drm_rect_height(&state->dst); > src_x = state->src.x1; > -- > 1.9.3 >
On Fri, Sep 12, 2014 at 10:12:37AM +0300, Jani Nikula wrote: > On Thu, 11 Sep 2014, Gustavo Padovan <gustavo@padovan.org> wrote: > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > > > 7e4bf45dbd99a965c7b5d5944c6dc4246f171eb5 introduced the regression. > > We fix it by doing the right assignment of crtc_y > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83747 > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > Thanks for the quick fix. > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Yeah, thanks a lot for the quick fix. Queued for -next, thanks for the patch. -Daniel
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 90bb45f..78044bb 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c @@ -1080,7 +1080,7 @@ intel_commit_sprite_plane(struct drm_plane *plane, if (state->visible) { crtc_x = state->dst.x1; - crtc_y = state->dst.x2; + crtc_y = state->dst.y1; crtc_w = drm_rect_width(&state->dst); crtc_h = drm_rect_height(&state->dst); src_x = state->src.x1;