From patchwork Thu Sep 11 20:42:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 4890431 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 29416C0338 for ; Thu, 11 Sep 2014 20:42:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4182020200 for ; Thu, 11 Sep 2014 20:42:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 5CBF7201FE for ; Thu, 11 Sep 2014 20:42:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF5916E08E; Thu, 11 Sep 2014 13:42:24 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qc0-f169.google.com (mail-qc0-f169.google.com [209.85.216.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B8036E08E; Thu, 11 Sep 2014 13:42:23 -0700 (PDT) Received: by mail-qc0-f169.google.com with SMTP id r5so2842759qcx.28 for ; Thu, 11 Sep 2014 13:42:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VtCAd1/lGfvO683+exmkh0KvQwu2Rs16DVELqOjIdWU=; b=BPoqyskuDh4jo1RpHQkf67TmgfQpzJ376LFkxLQFeM9N97OxD9wwbTojuthv+j+kIj dlDYlO7eu+62H9LYmcNmQfSzq5nwiNHsxdqNfL58Lb32mJpJZJAfk6q25/4z6Io7NiSb xG5sUVRXoOGUMi+aNSZWouzsN4zwiiiBnEk/VJWcsretqybODi2bUVaI+zm6IDq8GP23 XTKkVhlg9MGEXJsbyHGTvqONRsr8HfVBi6/vEnczo1ulfp87cVVXnnMyhCIKLrL3P6m+ lpIDwZ3+kybmC37acN8S2bXn7Qe6bwsLbUPo5plP6PuYVEEMD8DcuYx07VDNKUjWCOSg 9Pxw== X-Received: by 10.224.136.130 with SMTP id r2mr5506419qat.66.1410468141092; Thu, 11 Sep 2014 13:42:21 -0700 (PDT) Received: from localhost.localdomain ([179.110.36.133]) by mx.google.com with ESMTPSA id g52sm1452398qgg.17.2014.09.11.13.42.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Sep 2014 13:42:20 -0700 (PDT) From: Gustavo Padovan To: intel-gfx@lists.freedesktop.org Date: Thu, 11 Sep 2014 17:42:15 -0300 Message-Id: <1410468135-14639-1-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <871trikt11.fsf@intel.com> References: <871trikt11.fsf@intel.com> Cc: Gustavo Padovan , dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH] drm/i915: Fix regression in the sprite plane update split X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan 7e4bf45dbd99a965c7b5d5944c6dc4246f171eb5 introduced the regression. We fix it by doing the right assignment of crtc_y Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83747 Signed-off-by: Gustavo Padovan Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 90bb45f..78044bb 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c @@ -1080,7 +1080,7 @@ intel_commit_sprite_plane(struct drm_plane *plane, if (state->visible) { crtc_x = state->dst.x1; - crtc_y = state->dst.x2; + crtc_y = state->dst.y1; crtc_w = drm_rect_width(&state->dst); crtc_h = drm_rect_height(&state->dst); src_x = state->src.x1;