From patchwork Mon Sep 15 23:24:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 4913611 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4442FBEEA5 for ; Mon, 15 Sep 2014 23:24:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7F43E20222 for ; Mon, 15 Sep 2014 23:24:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id AF3BD2015A for ; Mon, 15 Sep 2014 23:24:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8E1589DAB; Mon, 15 Sep 2014 16:24:10 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by gabe.freedesktop.org (Postfix) with ESMTP id DE5F489DAB for ; Mon, 15 Sep 2014 16:24:09 -0700 (PDT) Received: by mail-pa0-f53.google.com with SMTP id rd3so7430235pab.12 for ; Mon, 15 Sep 2014 16:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=0i7rWTlfVhK7bAzCf7V67nGXl27oWUI80KLPBUifplw=; b=HDR7BPmVQdRcEOx/Vb0yWJLSIyORDyDJJRQOv86nfdqtQlIsg65bVo00Xexp/2Hexu Ru7P7gADTQOFoXfSeh0b6wpiX2k6gllzgc2qjzV9XroOC28FKQ6Ajr+ddtWqXVZULYH2 /IcQ5B+PNURBR7gIKOuakEGDMWCmPFKXqBDEh28DSpng0yoazXPqpjecCs/2AXi1yeL+ ScnYKjalTL2yPkxkcc9s0nY0U+3vBasJ3w06iVozYdWcebKUVmWH5seEpkwjSZ+ckbt5 7HVdGx/1ZQuI/hRwVT7oxL5sdCaEajw6ZRpZvAr6L2eOYQKMUZQLS8l/y15FgaNT2d26 v+wg== X-Received: by 10.70.45.74 with SMTP id k10mr52296270pdm.78.1410823449624; Mon, 15 Sep 2014 16:24:09 -0700 (PDT) Received: from rdvivi-bratislava.home (static-50-43-14-60.bvtn.or.frontiernet.net. [50.43.14.60]) by mx.google.com with ESMTPSA id cy7sm5832055pdb.7.2014.09.15.16.24.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Sep 2014 16:24:08 -0700 (PDT) From: Rodrigo Vivi X-Google-Original-From: Rodrigo Vivi To: intel-gfx@lists.freedesktop.org Date: Mon, 15 Sep 2014 19:24:03 -0400 Message-Id: <1410823443-5527-1-git-send-email-rodrigo.vivi@intel.com> X-Mailer: git-send-email 1.9.3 Cc: Rodrigo Vivi Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Use EIO instead of EAGAIN for sink CRC error. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If something while getting panel CRC this means that probably hw I/O error so hw is busted and try again shouldn't help much. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index fae0fae..963e956 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -3473,14 +3473,14 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc) int attempts = 6; if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_MISC, &buf) < 0) - return -EAGAIN; + return -EIO; if (!(buf & DP_TEST_CRC_SUPPORTED)) return -ENOTTY; if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK, DP_TEST_SINK_START) < 0) - return -EAGAIN; + return -EIO; drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_MISC, &buf); test_crc_count = buf & DP_TEST_COUNT_MASK; @@ -3494,7 +3494,7 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc) return -EIO; if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0) - return -EAGAIN; + return -EIO; drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK, 0); return 0;