From patchwork Thu Nov 6 01:31:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom.O'Rourke@intel.com X-Patchwork-Id: 5238701 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AFADDC11AC for ; Thu, 6 Nov 2014 01:30:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 038062015A for ; Thu, 6 Nov 2014 01:30:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 29F5F20172 for ; Thu, 6 Nov 2014 01:30:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B8FB56E8BE; Wed, 5 Nov 2014 17:30:57 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id BBB2C6E8BE for ; Wed, 5 Nov 2014 17:30:55 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 05 Nov 2014 17:24:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="412155148" Received: from torourke-desk.ra.intel.com (HELO localhost.localdomain) ([10.10.34.83]) by FMSMGA003.fm.intel.com with ESMTP; 05 Nov 2014 17:22:22 -0800 From: Tom.O'Rourke@intel.com To: intel-gfx@lists.freedesktop.org Date: Wed, 5 Nov 2014 17:31:35 -0800 Message-Id: <1415237495-89576-3-git-send-email-Tom.O'Rourke@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1415237495-89576-1-git-send-email-Tom.O'Rourke@intel.com> References: <1415237495-89576-1-git-send-email-Tom.O'Rourke@intel.com> Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Keep min freq above floor on HSW/BDW X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=APOSTROPHE_FROM,BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tom O'Rourke Set the min_freq_softlimit to max(RPe, 450MHz). Setting a floor can ensure a minimum experience level. The 450MHz value came from a power and performance study of various types of workloads (3D, Media, GPGPU, idle, etc). Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index e4347d9..1244ff8 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -4779,7 +4779,8 @@ static void gen8_enable_rps(struct drm_device *dev) if (IS_BROADWELL(dev)) { hsw_use_efficient_freq(dev_priv); - dev_priv->rps.min_freq_softlimit = dev_priv->rps.efficient_freq; + dev_priv->rps.min_freq_softlimit = + max(dev_priv->rps.efficient_freq, (u8) 9); /* 450 MHz */ } /* 2b: Program RC6 thresholds.*/ @@ -4879,7 +4880,8 @@ static void gen6_enable_rps(struct drm_device *dev) if (IS_HASWELL(dev)) { hsw_use_efficient_freq(dev_priv); - dev_priv->rps.min_freq_softlimit = dev_priv->rps.efficient_freq; + dev_priv->rps.min_freq_softlimit = + max(dev_priv->rps.efficient_freq, (u8) 9); /* 450 MHz */ } /* disable the counters and set deterministic thresholds */