| Message ID | 1415618923-24110-3-git-send-email-vandana.kannan@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 10 Nov 2014, Vandana Kannan <vandana.kannan@intel.com> wrote: > vlv_power_sequencer_pipe() calls into init PPS functions. Changing this > function to make it only return pipe and not call PPS init. > This is because PPS init calls into this function to get a pipe ID and all > other callers just need the pipe ID. > > Signed-off-by: Vandana Kannan <vandana.kannan@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 34d8105..1d4bf78 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -434,10 +434,6 @@ vlv_power_sequencer_pipe(struct intel_dp *intel_dp) > pipe_name(intel_dp->pps_pipe), > port_name(intel_dig_port->port)); > > - /* init power sequencer on this pipe and port */ > - intel_dp_init_panel_power_sequencer(dev, intel_dp); > - intel_dp_init_panel_power_sequencer_registers(dev, intel_dp); IIUC if you end up this far in the function it's a special case, in most cases it'll return with intel_dp->pps_pipe. And the special case probably means you'll need to setup the registers and everything. Ville? BR, Jani. > - > /* > * Even vdd force doesn't work until we've made > * the power sequencer lock in on the port. > -- > 2.0.1 >
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 34d8105..1d4bf78 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -434,10 +434,6 @@ vlv_power_sequencer_pipe(struct intel_dp *intel_dp) pipe_name(intel_dp->pps_pipe), port_name(intel_dig_port->port)); - /* init power sequencer on this pipe and port */ - intel_dp_init_panel_power_sequencer(dev, intel_dp); - intel_dp_init_panel_power_sequencer_registers(dev, intel_dp); - /* * Even vdd force doesn't work until we've made * the power sequencer lock in on the port.
vlv_power_sequencer_pipe() calls into init PPS functions. Changing this function to make it only return pipe and not call PPS init. This is because PPS init calls into this function to get a pipe ID and all other callers just need the pipe ID. Signed-off-by: Vandana Kannan <vandana.kannan@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 4 ---- 1 file changed, 4 deletions(-)