From patchwork Mon Dec 8 16:12:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 5457491 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 91806BEEA8 for ; Mon, 8 Dec 2014 16:13:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D736C20155 for ; Mon, 8 Dec 2014 16:13:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DB3062015A for ; Mon, 8 Dec 2014 16:13:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E2E66E7CD; Mon, 8 Dec 2014 08:13:37 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qc0-f170.google.com (mail-qc0-f170.google.com [209.85.216.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FDBF6E7D6 for ; Mon, 8 Dec 2014 08:13:36 -0800 (PST) Received: by mail-qc0-f170.google.com with SMTP id x3so3738229qcv.1 for ; Mon, 08 Dec 2014 08:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=JqH3RFHi/8TUvue6AmyPhjUuxVBMZTfkHfjmXDbkyBk=; b=jiMZXEbgtJAlxbwC9sFvGjKHe6GNpHTQCLEBYd3Wn5Ibm9NTgcBxpNGFg5k27ec9O3 tOK5MR4tfthhN0WB+YeKG36QbLPj3NyI9qo44gXgt6/QzTlbYdBUOOahQgYyO3RC/W9Z JXLQ0hKIp52Scp3VEyVNfjLCecERRJ4Vq+b06p5q4N/k/sEF+dd8eivQUaWoqfL8V7C1 Jwbn0w3v8i/5YFnbjzUhNnfhKdRM0K5hA3nSlBYYvRDxGz28eA1TKpSq2MoRF2IOwnyE gZhBXKqIn1RkW8tY/mhvSUk4PNDMD17p3U5NUmeJxoOiUs8GECFkZZAcdpj7khQ+Ahi7 EztA== X-Received: by 10.224.51.131 with SMTP id d3mr54434134qag.94.1418055215797; Mon, 08 Dec 2014 08:13:35 -0800 (PST) Received: from localhost.localdomain ([187.95.104.42]) by mx.google.com with ESMTPSA id l10sm30480245qas.25.2014.12.08.08.13.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 08 Dec 2014 08:13:35 -0800 (PST) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Mon, 8 Dec 2014 14:12:44 -0200 Message-Id: <1418055164-1536-4-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1418055164-1536-1-git-send-email-przanoni@gmail.com> References: <1418054960-1403-1-git-send-email-przanoni@gmail.com> <1418055164-1536-1-git-send-email-przanoni@gmail.com> MIME-Version: 1.0 Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH igt 4/4] tests/kms_fbc_crc: also gem_sync() on exec_nop() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni When we're doing the context subtest, at the end of prepare_test() we exec a single nop batch on the front buffer, which invalidates FBC. With the new frontbuffer tracking scheme it may take a while for FBC to be reenabled, so we end up failing the first fbc_enabled() assertion inside test_crc(). Other possible implementations: - Call gem_sync() at the specific prepare_test() point, not at every exec_nop() call. - Change the fbc_enabled() assertion to wait_for_fbc_enabled() and give it a bigger timeout value. Cc: Ville Syrjälä Signed-off-by: Paulo Zanoni --- tests/kms_fbc_crc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index 354a2b7..decb83e 100644 --- a/tests/kms_fbc_crc.c +++ b/tests/kms_fbc_crc.c @@ -155,6 +155,8 @@ static void exec_nop(data_t *data, uint32_t handle, drm_intel_context *context) intel_batchbuffer_flush_with_context(batch, context); intel_batchbuffer_free(batch); + + gem_sync(data->drm_fd, handle); } static void fill_render(data_t *data, uint32_t handle,