diff mbox

[1/2] drm/i915/skl: Fix stepping check for a couple of W/As

Message ID 1424974839-16769-2-git-send-email-damien.lespiau@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lespiau, Damien Feb. 26, 2015, 6:20 p.m. UTC 
Both WaDisableSDEUnitClockGating and WaSetGAPSunitClckGateDisable are
needed on B0 as well.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rodrigo Vivi April 7, 2015, 10:45 p.m. UTC | #1 
(ops, had forgotten to cc mailing list)

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

On Thu, Feb 26, 2015 at 10:20 AM, Damien Lespiau
<damien.lespiau@intel.com> wrote:
> Both WaDisableSDEUnitClockGating and WaSetGAPSunitClckGateDisable are
> needed on B0 as well.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 7dcb5b6..f11e487 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -67,7 +67,7 @@ static void skl_init_clock_gating(struct drm_device *dev)
>
>         gen9_init_clock_gating(dev);
>
> -       if (INTEL_REVID(dev) == SKL_REVID_A0) {
> +       if (INTEL_REVID(dev) <= SKL_REVID_B0) {
>                 /*
>                  * WaDisableSDEUnitClockGating:skl
>                  * WaSetGAPSunitClckGateDisable:skl
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter April 8, 2015, 8:15 a.m. UTC | #2 
On Tue, Apr 07, 2015 at 03:45:22PM -0700, Rodrigo Vivi wrote:
> (ops, had forgotten to cc mailing list)
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Both patches merged, thanks.
-Daniel

> 
> On Thu, Feb 26, 2015 at 10:20 AM, Damien Lespiau
> <damien.lespiau@intel.com> wrote:
> > Both WaDisableSDEUnitClockGating and WaSetGAPSunitClckGateDisable are
> > needed on B0 as well.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 7dcb5b6..f11e487 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -67,7 +67,7 @@ static void skl_init_clock_gating(struct drm_device *dev)
> >
> >         gen9_init_clock_gating(dev);
> >
> > -       if (INTEL_REVID(dev) == SKL_REVID_A0) {
> > +       if (INTEL_REVID(dev) <= SKL_REVID_B0) {
> >                 /*
> >                  * WaDisableSDEUnitClockGating:skl
> >                  * WaSetGAPSunitClckGateDisable:skl
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 
> 
> -- 
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 7dcb5b6..f11e487 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -67,7 +67,7 @@  static void skl_init_clock_gating(struct drm_device *dev)
 
 	gen9_init_clock_gating(dev);
 
-	if (INTEL_REVID(dev) == SKL_REVID_A0) {
+	if (INTEL_REVID(dev) <= SKL_REVID_B0) {
 		/*
 		 * WaDisableSDEUnitClockGating:skl
 		 * WaSetGAPSunitClckGateDisable:skl