| Message ID | 1431443602-22886-3-git-send-email-damien.lespiau@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Reviewed-by: Chandra Konduru <Chandra.konduru@intel.com> > -----Original Message----- > From: Lespiau, Damien > Sent: Tuesday, May 12, 2015 8:13 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra > Subject: [PATCH 02/10] drm/i915/skl: Add a new line before return > > We usually use a new line before those kind of return statements. Also the > various skl_plane_ctl*() functions weren't consistent. > > Cc: Chandra Konduru <chandra.konduru@intel.com> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index f533519..c6419e8 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -2999,6 +2999,7 @@ u32 skl_plane_ctl_format(uint32_t pixel_format) > default: > BUG(); > } > + > return plane_ctl_format; > } > > @@ -3021,6 +3022,7 @@ u32 skl_plane_ctl_tiling(uint64_t fb_modifier) > default: > MISSING_CASE(fb_modifier); > } > + > return plane_ctl_tiling; > } > > -- > 2.1.0
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f533519..c6419e8 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -2999,6 +2999,7 @@ u32 skl_plane_ctl_format(uint32_t pixel_format) default: BUG(); } + return plane_ctl_format; } @@ -3021,6 +3022,7 @@ u32 skl_plane_ctl_tiling(uint64_t fb_modifier) default: MISSING_CASE(fb_modifier); } + return plane_ctl_tiling; }
We usually use a new line before those kind of return statements. Also the various skl_plane_ctl*() functions weren't consistent. Cc: Chandra Konduru <chandra.konduru@intel.com> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+)