From patchwork Thu Jun 4 14:31:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 6547661 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E38E5C0020 for ; Thu, 4 Jun 2015 14:32:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 256A6207E7 for ; Thu, 4 Jun 2015 14:32:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3CEE32060A for ; Thu, 4 Jun 2015 14:32:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 798396EB6B; Thu, 4 Jun 2015 07:32:05 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qg0-f41.google.com (mail-qg0-f41.google.com [209.85.192.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 462A86EAD1 for ; Thu, 4 Jun 2015 07:32:04 -0700 (PDT) Received: by qgfa63 with SMTP id a63so17515837qgf.0 for ; Thu, 04 Jun 2015 07:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6cS0cn9Aa26o1/m+/Yn4IVn/TT3mkoGjYXbXtVs4kqI=; b=tB4tvHssmvuzOH9SQr9mt06WIotw/jKBhmi6gAE6OmSo8b8cj35XuSRvoh2QnVRvm2 1M33i7NW/xfysTOr7eJpcCFmIJMJAnVxrUfOuoEJ5Nw9K0zbwRZZidnMPksTSs7L67op 7Iw2gM1D7dsIo0OGPeAlYGfGNo5vztMSJ6+bc44SUANfM9s628PTSGDjcEGFCrbI0VAC XZ7olHXC1IfvNRhsPHjdl02GfuvI57WtDMbmwJ1tgabRPF12L/FqW5h6fGR835TCKMhg 6KdySpGjvUDVQjRcBbuLL6gLkVaq3mmfRFVR0+eI/IaiUokh9qLzEUiPN1XkP3OuQo/t R/Fw== X-Received: by 10.55.22.130 with SMTP id 2mr1882178qkw.45.1433428323864; Thu, 04 Jun 2015 07:32:03 -0700 (PDT) Received: from localhost.localdomain ([177.92.20.165]) by mx.google.com with ESMTPSA id f33sm2445470qkf.7.2015.06.04.07.32.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Jun 2015 07:32:03 -0700 (PDT) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Thu, 4 Jun 2015 11:31:05 -0300 Message-Id: <1433428266-1867-3-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1433428266-1867-1-git-send-email-przanoni@gmail.com> References: <1433428266-1867-1-git-send-email-przanoni@gmail.com> Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH igt 3/4] tests/kms_fbc_crc: run even if FBC is disabled by default X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni We may not be perfect, but if we don't even test, we will probably only get worse over time. The function called makes sure we restore whatever was the original FBC parameter when we exit the test, so this should not affect the other tests. Signed-off-by: Paulo Zanoni --- tests/kms_fbc_crc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index 37221ac..d964224 100644 --- a/tests/kms_fbc_crc.c +++ b/tests/kms_fbc_crc.c @@ -559,10 +559,10 @@ igt_main igt_assert_lt(0, fread(buf, 1, sizeof(buf), status)); fclose(status); buf[sizeof(buf) - 1] = '\0'; - igt_require_f(!strstr(buf, "unsupported on this chipset") && - !strstr(buf, "disabled per module param") && - !strstr(buf, "disabled per chip default"), - "FBC not supported/enabled\n"); + igt_require_f(!strstr(buf, "unsupported on this chipset"), + "FBC not supported\n"); + + igt_set_module_param_int("enable_fbc", 1); data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096); igt_assert(data.bufmgr);