diff mbox

[i-g-t] pm_rpm: Update the debugfs filename

Message ID 1433439126-19147-1-git-send-email-damien.lespiau@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lespiau, Damien June 4, 2015, 5:32 p.m. UTC 
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 tests/pm_rpm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paulo Zanoni June 5, 2015, 12:43 p.m. UTC | #1 
2015-06-04 14:32 GMT-03:00 Damien Lespiau <damien.lespiau@intel.com>:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  tests/pm_rpm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index a1f4013..2a83a75 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -669,9 +669,9 @@ static void setup_pc8(void)
>         if (!supports_pc8_plus_residencies())
>                 return;
>
> -       pc8_status_fd = igt_debugfs_open("i915_pc8_status", O_RDONLY);
> +       pc8_status_fd = igt_debugfs_open("i915_runtime_pm_status", O_RDONLY);

I kinda fear this can lead to a situation where we temporarily fail to
test things. OTOH, PC8 residency testing is the least important thing
of that tool, because when QA reports bugs on this we just assume
their machines are badly configured.. So if you have a lot of free
time, you could try to check for the existence of both files.
Otherwise, feel free to just push the patch.

>         igt_assert_f(pc8_status_fd >= 0,
> -                    "Can't open /sys/kernel/debug/dri/0/i915_pc8_status");
> +                    "Can't open /sys/kernel/debug/dri/0/i915_runtime_pm_status");
>
>         has_pc8 = true;
>  }
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index a1f4013..2a83a75 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -669,9 +669,9 @@  static void setup_pc8(void)
 	if (!supports_pc8_plus_residencies())
 		return;
 
-	pc8_status_fd = igt_debugfs_open("i915_pc8_status", O_RDONLY);
+	pc8_status_fd = igt_debugfs_open("i915_runtime_pm_status", O_RDONLY);
 	igt_assert_f(pc8_status_fd >= 0,
-		     "Can't open /sys/kernel/debug/dri/0/i915_pc8_status");
+		     "Can't open /sys/kernel/debug/dri/0/i915_runtime_pm_status");
 
 	has_pc8 = true;
 }