From patchwork Tue Jun 9 04:32:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Airlie X-Patchwork-Id: 6569451 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5BF409F2F4 for ; Tue, 9 Jun 2015 04:32:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9A0D82042A for ; Tue, 9 Jun 2015 04:32:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9B1492041E for ; Tue, 9 Jun 2015 04:32:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 713176E645; Mon, 8 Jun 2015 21:32:16 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 23ED66E645 for ; Mon, 8 Jun 2015 21:32:15 -0700 (PDT) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 90835BF9D4 for ; Tue, 9 Jun 2015 04:32:14 +0000 (UTC) Received: from dreadlord-bne-redhat-com.bne.redhat.com (dhcp-40-179.bne.redhat.com [10.64.40.179]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t594WCCn013673 for ; Tue, 9 Jun 2015 00:32:13 -0400 From: Dave Airlie To: intel-gfx@lists.freedesktop.org Date: Tue, 9 Jun 2015 14:32:12 +1000 Message-Id: <1433824332-25672-1-git-send-email-airlied@gmail.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: [Intel-gfx] [PATCH] [rfc] hack patch to fix dirty on offload screens X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The offload screens on an nvidia gpu show dirt on them, this is due to the stuff not being flushed fully back to the CPU side and into main memory, for the secondary GPU to pick it up from. This is the hack I used to have in UXA, which works here, however I'm sure this isn't acceptable for upstream, so let me know what else I could try. Dave. --- src/sna/sna_accel.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c index b40b99a..df8efb4 100644 --- a/src/sna/sna_accel.c +++ b/src/sna/sna_accel.c @@ -17638,7 +17638,9 @@ fallback: box, n, COPY_LAST)) goto fallback; - flush = true; + kgem_submit(&sna->kgem); + kgem_bo_map(&sna->kgem, __sna_pixmap_get_bo(dst)); + } DamageRegionProcessPending(&dirty->slave_dst->drawable);