| Message ID | 1435926637-30892-6-git-send-email-david.s.gordon@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 03, 2015 at 01:30:27PM +0100, Dave Gordon wrote: > From: Alex Dai <yu.dai@intel.com> > > This uses the common firmware loader to fetch the firmware image, > then loads it into the GuC's memory via a dedicated DMA engine. > > This patch is derived from GuC loading work originally done by > Vinit Azad and Ben Widawsky. It has been reconstructed to accord > with the common firmware loading mechanism by Dave Gordon as well > as new firmware layout etc. > > v2: > Various improvements per review comments by Chris Wilson > > v3: > Removed 'wait' parameter to intel_guc_ucode_load() as prefetch > is no longer supported in the common firmware loader, per > Daniel Vetter's request. > F/w checker callback fn now returns errno rather than bool. > > Issue: VIZ-4884 > Signed-off-by: Alex Dai <yu.dai@intel.com> > Signed-off-by: Dave Gordon <david.s.gordon@intel.com> > --- > drivers/gpu/drm/i915/Makefile | 3 + > drivers/gpu/drm/i915/i915_dma.c | 4 + > drivers/gpu/drm/i915/i915_drv.h | 11 + > drivers/gpu/drm/i915/i915_gem.c | 8 + > drivers/gpu/drm/i915/i915_reg.h | 4 +- > drivers/gpu/drm/i915/intel_guc.h | 49 ++++ > drivers/gpu/drm/i915/intel_guc_loader.c | 448 ++++++++++++++++++++++++++++++++ > 7 files changed, 526 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/i915/intel_guc.h > create mode 100644 drivers/gpu/drm/i915/intel_guc_loader.c > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index f1f80fc..62a8c83 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -42,6 +42,9 @@ i915-y += i915_cmd_parser.o \ > # generic ancilliary microcontroller support > i915-y += intel_uc_loader.o > > +# general-purpose microcontroller (GuC) support > +i915-y += intel_guc_loader.o > + > # autogenerated null render state > i915-y += intel_renderstate_gen6.o \ > intel_renderstate_gen7.o \ > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index c5349fa..730d91b 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -469,6 +469,7 @@ static int i915_load_modeset_init(struct drm_device *dev) > > cleanup_gem: > mutex_lock(&dev->struct_mutex); > + intel_guc_ucode_fini(dev); > i915_gem_cleanup_ringbuffer(dev); > i915_gem_context_fini(dev); > mutex_unlock(&dev->struct_mutex); > @@ -866,6 +867,8 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) > > intel_uncore_init(dev); > > + intel_guc_ucode_init(dev); > + > /* Load CSR Firmware for SKL */ > intel_csr_ucode_init(dev); > > @@ -1117,6 +1120,7 @@ int i915_driver_unload(struct drm_device *dev) > flush_workqueue(dev_priv->wq); > > mutex_lock(&dev->struct_mutex); > + intel_guc_ucode_fini(dev); > i915_gem_cleanup_ringbuffer(dev); > i915_gem_context_fini(dev); > mutex_unlock(&dev->struct_mutex); > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 9618f57..a7ccac5 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -50,6 +50,7 @@ > #include <linux/intel-iommu.h> > #include <linux/kref.h> > #include <linux/pm_qos.h> > +#include "intel_guc.h" > > /* General customization: > */ > @@ -1687,6 +1688,8 @@ struct drm_i915_private { > > struct i915_virtual_gpu vgpu; > > + struct intel_guc guc; > + > struct intel_csr csr; > > /* Display CSR-related protection */ > @@ -1931,6 +1934,11 @@ static inline struct drm_i915_private *dev_to_i915(struct device *dev) > return to_i915(dev_get_drvdata(dev)); > } > > +static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc) > +{ > + return container_of(guc, struct drm_i915_private, guc); > +} > + > /* Iterate over initialised rings */ > #define for_each_ring(ring__, dev_priv__, i__) \ > for ((i__) = 0; (i__) < I915_NUM_RINGS; (i__)++) \ > @@ -2539,6 +2547,9 @@ struct drm_i915_cmd_table { > > #define HAS_CSR(dev) (IS_SKYLAKE(dev)) > > +#define HAS_GUC_UCODE(dev) (IS_GEN9(dev)) > +#define HAS_GUC_SCHED(dev) (IS_GEN9(dev)) > + > #define INTEL_PCH_DEVICE_ID_MASK 0xff00 > #define INTEL_PCH_IBX_DEVICE_ID_TYPE 0x3b00 > #define INTEL_PCH_CPT_DEVICE_ID_TYPE 0x1c00 > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index aa8f4c3..80d7890 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -5076,6 +5076,14 @@ i915_gem_init_hw(struct drm_device *dev) > goto out; > } > > + /* > + * We can't enable contexts until all firmware is loaded; if this > + * fails, disable GuC submissions and fall back to execlist mode > + */ > + ret = intel_guc_ucode_load(dev); > + if (ret) > + i915.enable_guc_submission = false; I want an -EIO or similar here since runtime fallbacks to other modes really aren't great from a maintainance perspective, see my comments on the irq routing code. Yes we can make this work, but givin our stellar track record with keeping disabled features working it won't work for long. And it will impact us with additional constraints until we give up and rip it out again. Not worth it imo - if we decide to use the guc on a given platform we should imo require it and stick to that decision for at least as long as the driver is loaded. Developers can still change the option when reloading the driver, users won't have a chance to cause trouble. -Daniel > + > /* Now it is safe to go back round and do everything else: */ > for_each_ring(ring, dev_priv, i) { > struct drm_i915_gem_request *req; > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 313b1f9..eefb847 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -6837,7 +6837,9 @@ enum skl_disp_power_wells { > #define GEN9_PGCTL_SSB_EU311_ACK (1 << 14) > > #define GEN7_MISCCPCTL (0x9424) > -#define GEN7_DOP_CLOCK_GATE_ENABLE (1<<0) > +#define GEN7_DOP_CLOCK_GATE_ENABLE (1<<0) > +#define GEN8_DOP_CLOCK_GATE_CFCLK_ENABLE (1<<2) > +#define GEN8_DOP_CLOCK_GATE_GUC_ENABLE (1<<4) > > /* IVYBRIDGE DPF */ > #define GEN7_L3CDERRST1 0xB008 /* L3CD Error Status 1 */ > diff --git a/drivers/gpu/drm/i915/intel_guc.h b/drivers/gpu/drm/i915/intel_guc.h > new file mode 100644 > index 0000000..b38d2b0 > --- /dev/null > +++ b/drivers/gpu/drm/i915/intel_guc.h > @@ -0,0 +1,49 @@ > +/* > + * Copyright © 2014 Intel Corporation > + * > + * Permission is hereby granted, free of charge, to any person obtaining a > + * copy of this software and associated documentation files (the "Software"), > + * to deal in the Software without restriction, including without limitation > + * the rights to use, copy, modify, merge, publish, distribute, sublicense, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice (including the next > + * paragraph) shall be included in all copies or substantial portions of the > + * Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS > + * IN THE SOFTWARE. > + * > + */ > +#ifndef _INTEL_GUC_H_ > +#define _INTEL_GUC_H_ > + > +#include "intel_uc_loader.h" > +#include "intel_guc_fwif.h" > +#include "i915_guc_reg.h" > + > +struct intel_guc { > + /* Generic uC firmware management */ > + struct intel_uc_fw guc_fw; > + > + /* GuC-specific additions */ > + uint16_t fw_major_wanted; > + uint16_t fw_minor_wanted; > + uint16_t fw_major_found; > + uint16_t fw_minor_found; > + > + uint32_t log_flags; > +}; > + > +/* intel_guc_loader.c */ > +extern void intel_guc_ucode_init(struct drm_device *dev); > +extern int intel_guc_ucode_load(struct drm_device *dev); > +extern void intel_guc_ucode_fini(struct drm_device *dev); > + > +#endif > diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c > new file mode 100644 > index 0000000..4929838 > --- /dev/null > +++ b/drivers/gpu/drm/i915/intel_guc_loader.c > @@ -0,0 +1,448 @@ > +/* > + * Copyright © 2014 Intel Corporation > + * > + * Permission is hereby granted, free of charge, to any person obtaining a > + * copy of this software and associated documentation files (the "Software"), > + * to deal in the Software without restriction, including without limitation > + * the rights to use, copy, modify, merge, publish, distribute, sublicense, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice (including the next > + * paragraph) shall be included in all copies or substantial portions of the > + * Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS > + * IN THE SOFTWARE. > + * > + * Authors: > + * Vinit Azad <vinit.azad@intel.com> > + * Ben Widawsky <ben@bwidawsk.net> > + * Dave Gordon <david.s.gordon@intel.com> > + * Alex Dai <yu.dai@intel.com> > + */ > +#include <linux/firmware.h> > +#include "i915_drv.h" > +#include "intel_guc.h" > + > +/** > + * DOC: GuC > + * > + * intel_guc: > + * Top level structure of guc. It handles firmware loading and manages client > + * pool and doorbells. intel_guc owns a i915_guc_client to replace the legacy > + * ExecList submission. > + * > + * Firmware versioning: > + * The firmware build process will generate a version header file with major and > + * minor version defined. The versions are built into CSS header of firmware. > + * i915 kernel driver set the minimal firmware version required per platform. > + * The firmware installation package will install (symbolic link) proper version > + * of firmware. > + * > + * GuC address space: > + * GuC does not allow any gfx GGTT address that falls into range [0, WOPCM_TOP), > + * which is reserved for Boot ROM, SRAM and WOPCM. Currently this top address is > + * 512K. In order to exclude 0-512K address space from GGTT, all gfx objects > + * used by GuC is pinned with PIN_OFFSET_BIAS along with size of WOPCM. > + * > + * Firmware log: > + * Firmware log is enabled by setting i915.guc_log_level to non-negative level. > + * Log data is printed out via reading debugfs i915_guc_log_dump. Reading from > + * i915_guc_load_status will print out firmware loading status and scratch > + * registers value. > + * > + */ > + > +#define I915_SKL_GUC_UCODE "i915/skl_guc_ver3.bin" > +MODULE_FIRMWARE(I915_SKL_GUC_UCODE); > + > +static u32 get_gttype(struct drm_i915_private *dev_priv) > +{ > + /* XXX: GT type based on PCI device ID? field seems unused by fw */ > + return 0; > +} > + > +static u32 get_core_family(struct drm_i915_private *dev_priv) > +{ > + switch (INTEL_INFO(dev_priv)->gen) { > + case 8: > + return GFXCORE_FAMILY_GEN8; > + case 9: > + return GFXCORE_FAMILY_GEN9; > + default: > + DRM_ERROR("GUC: unknown gen for scheduler init\n"); > + return GFXCORE_FAMILY_FORCE_ULONG; > + } > +} > + > +static void set_guc_init_params(struct drm_i915_private *dev_priv) > +{ > + struct intel_guc *guc = &dev_priv->guc; > + u32 params[GUC_CTL_MAX_DWORDS]; > + int i; > + > + memset(¶ms, 0, sizeof(params)); > + > + params[GUC_CTL_DEVICE_INFO] |= > + (get_gttype(dev_priv) << GUC_CTL_GTTYPE_SHIFT) | > + (get_core_family(dev_priv) << GUC_CTL_COREFAMILY_SHIFT); > + > + /* GuC ARAT increment is 10 ns. GuC default scheduler quantum is one > + * second. This ARAR is calculated by: > + * Scheduler-Quantum-in-ns / ARAT-increment-in-ns = 1000000000 / 10 > + */ > + params[GUC_CTL_ARAT_HIGH] = 0; > + params[GUC_CTL_ARAT_LOW] = 100000000; > + > + params[GUC_CTL_WA] |= GUC_CTL_WA_UK_BY_DRIVER; > + > + params[GUC_CTL_FEATURE] |= GUC_CTL_DISABLE_SCHEDULER | > + GUC_CTL_VCS2_ENABLED; > + > + if (i915.guc_log_level >= 0) { > + params[GUC_CTL_LOG_PARAMS] = guc->log_flags; > + params[GUC_CTL_DEBUG] = > + i915.guc_log_level << GUC_LOG_VERBOSITY_SHIFT; > + } > + > + I915_WRITE(SOFT_SCRATCH(0), 0); > + > + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++) > + I915_WRITE(SOFT_SCRATCH(1 + i), params[i]); > +} > + > +/* > + * Read the GuC status register (GUC_STATUS) and store it in the > + * specified location; then return a boolean indicating whether > + * the value matches either of two values representing completion > + * of the GuC boot process. > + * > + * This is used for polling the GuC status in a wait_for_atomic() > + * loop below. > + */ > +static inline bool guc_ucode_response(struct drm_i915_private *dev_priv, > + u32 *status) > +{ > + u32 val = I915_READ(GUC_STATUS); > + *status = val; > + return ((val & GS_UKERNEL_MASK) == GS_UKERNEL_READY || > + (val & GS_UKERNEL_MASK) == GS_UKERNEL_LAPIC_DONE); > +} > + > +/* > + * Transfer the firmware image to RAM for execution by the microcontroller. > + * > + * GuC Firmware layout: > + * +-------------------------------+ ---- > + * | CSS header | 128B > + * | contains major/minor version | > + * +-------------------------------+ ---- > + * | uCode | > + * +-------------------------------+ ---- > + * | RSA signature | 256B > + * +-------------------------------+ ---- > + * | RSA public Key | 256B > + * +-------------------------------+ ---- > + * | Public key modulus | 4B > + * +-------------------------------+ ---- > + * > + * Architecturally, the DMA engine is bidirectional, and can potentially even > + * transfer between GTT locations. This functionality is left out of the API > + * for now as there is no need for it. > + * > + * Note that GuC needs the CSS header plus uKernel code to be copied by the > + * DMA engine in one operation, whereas the RSA signature is loaded via MMIO. > + */ > + > +#define UOS_CSS_HEADER_OFFSET 0 > +#define UOS_VER_MINOR_OFFSET 0x44 > +#define UOS_VER_MAJOR_OFFSET 0x46 > +#define UOS_CSS_HEADER_SIZE 0x80 > +#define UOS_RSA_SIG_SIZE 0x100 > +#define UOS_CSS_SIGNING_SIZE 0x204 > + > +static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv) > +{ > + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; > + struct drm_i915_gem_object *fw_obj = guc_fw->uc_fw_obj; > + unsigned long offset; > + struct sg_table *sg = fw_obj->pages; > + u32 status, ucode_size, rsa[UOS_RSA_SIG_SIZE / sizeof(u32)]; > + int i, ret = 0; > + > + /* uCode size, also is where RSA signature starts */ > + offset = ucode_size = guc_fw->uc_fw_size - UOS_CSS_SIGNING_SIZE; > + > + /* Copy RSA signature from the fw image to HW for verification */ > + sg_pcopy_to_buffer(sg->sgl, sg->nents, rsa, UOS_RSA_SIG_SIZE, offset); > + for (i = 0; i < UOS_RSA_SIG_SIZE / sizeof(u32); i++) > + I915_WRITE(UOS_RSA_SCRATCH_0 + i * sizeof(u32), rsa[i]); > + > + /* Set the source address for the new blob */ > + offset = i915_gem_obj_ggtt_offset(fw_obj); > + I915_WRITE(DMA_ADDR_0_LOW, lower_32_bits(offset)); > + I915_WRITE(DMA_ADDR_0_HIGH, upper_32_bits(offset) & 0xFFFF); > + > + /* Set the destination. Current uCode expects an 8k stack starting from > + * offset 0. */ > + I915_WRITE(DMA_ADDR_1_LOW, 0x2000); > + > + /* XXX: The image is automatically transfered to SRAM after the RSA > + * verification. This is why the address space is chosen as such. */ > + I915_WRITE(DMA_ADDR_1_HIGH, DMA_ADDRESS_SPACE_WOPCM); > + > + I915_WRITE(DMA_COPY_SIZE, ucode_size); > + > + /* Finally start the DMA */ > + I915_WRITE(DMA_CTRL, _MASKED_BIT_ENABLE(UOS_MOVE | START_DMA)); > + > + /* > + * Spin-wait for the DMA to complete & the GuC to start up. > + * NB: Docs recommend not using the interrupt for completion. > + * Measurements indicate this should take no more than 20ms, so a > + * timeout here indicates that the GuC has failed and is unusable. > + * (Higher levels of the driver will attempt to fall back to > + * execlist mode if this happens.) > + */ > + ret = wait_for_atomic(guc_ucode_response(dev_priv, &status), 100); > + > + DRM_DEBUG_DRIVER("DMA status 0x%x, GuC status 0x%x\n", > + I915_READ(DMA_CTRL), status); > + > + if ((status & GS_BOOTROM_MASK) == GS_BOOTROM_RSA_FAILED) { > + DRM_ERROR("%s firmware signature verification failed\n", > + guc_fw->uc_name); > + ret = -ENOEXEC; > + } > + > + DRM_DEBUG_DRIVER("returning %d\n", ret); > + > + return ret; > +} > + > +/* > + * Load the GuC firmware blob into the MinuteIA. > + */ > +static int guc_ucode_xfer(struct drm_i915_private *dev_priv) > +{ > + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; > + struct drm_device *dev = dev_priv->dev; > + int ret; > + > + ret = i915_gem_object_set_to_gtt_domain(guc_fw->uc_fw_obj, false); > + if (ret) { > + DRM_DEBUG_DRIVER("set-domain failed %d\n", ret); > + return ret; > + } > + > + ret = i915_gem_obj_ggtt_pin(guc_fw->uc_fw_obj, 0, 0); > + if (ret) { > + DRM_DEBUG_DRIVER("pin failed %d\n", ret); > + return ret; > + } > + > + WARN_ON(!mutex_is_locked(&dev->struct_mutex)); > + intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL); > + > + /* init WOPCM */ > + I915_WRITE(GUC_WOPCM_SIZE, GUC_WOPCM_SIZE_VALUE); > + I915_WRITE(DMA_GUC_WOPCM_OFFSET, GUC_WOPCM_OFFSET); > + > + /* Invalidate GuC TLB to let GuC take the latest updates to GTT. */ > + I915_WRITE(GEN8_GTCR, GEN8_GTCR_INVALIDATE); > + > + /* Set MMIO/WA for GuC init */ > + I915_WRITE(DRBMISC1, DOORBELL_ENABLE); > + > + /* Enable MIA caching. GuC clock gating is disabled. */ > + I915_WRITE(GUC_SHIM_CONTROL, GUC_SHIM_CONTROL_VALUE); > + > + /* WaC6DisallowByGfxPause*/ > + I915_WRITE(GEN6_GFXPAUSE, 0x30FFF); > + > + if (IS_SKYLAKE(dev)) > + I915_WRITE(GEN9_GT_PM_CONFIG, GEN8_GT_DOORBELL_ENABLE); > + else > + I915_WRITE(GEN8_GT_PM_CONFIG, GEN8_GT_DOORBELL_ENABLE); > + > + if (IS_GEN9(dev)) { > + /* DOP Clock Gating Enable for GuC clocks */ > + I915_WRITE(GEN7_MISCCPCTL, (GEN8_DOP_CLOCK_GATE_GUC_ENABLE | > + I915_READ(GEN7_MISCCPCTL))); > + > + /* allows for 5us before GT can go to RC6 */ > + I915_WRITE(GUC_ARAT_C6DIS, 0x1FF); > + } > + > + set_guc_init_params(dev_priv); > + > + ret = guc_ucode_xfer_dma(dev_priv); > + > + intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL); > + > + /* > + * We keep the object pages for reuse during resume. But we can unpin it > + * now that DMA has completed, so it doesn't continue to take up space. > + */ > + i915_gem_object_ggtt_unpin(guc_fw->uc_fw_obj); > + > + return ret; > +} > + > +/* > + * Check the firmware that was found; if it's the wrong size or the wrong > + * version, return a negative error code. If it's OK, return a positive > + * status value. Here we can just return INTEL_UC_FW_GOOD; the common loader > + * code will then save the data for later in a pageable (tmpfs-backed) GEM > + * object. > + * > + * Alternatively (for example if we wanted only part of the image) we could > + * save the required portion here and then return INTEL_UC_FW_SAVED to tell > + * the common loader that the data is good, and we've already handled saving > + * anything we need later. > + * > + * The GuC firmware image has the version number embedded at a well-known > + * offset within the firmware blob; note that major / minor version are > + * TWO bytes each (i.e. u16), although all pointers and offsets are defined > + * in terms of bytes (u8). > + */ > +static int guc_ucode_check(struct intel_uc_fw *guc_fw) > +{ > + struct intel_guc *guc = container_of(guc_fw, struct intel_guc, guc_fw); > + const u8 *css_header = guc_fw->uc_fw_blob->data + UOS_CSS_HEADER_OFFSET; > + const size_t blobsize = guc_fw->uc_fw_blob->size; > + const size_t minsize = UOS_CSS_HEADER_SIZE + UOS_CSS_SIGNING_SIZE; > + const size_t maxsize = GUC_WOPCM_SIZE_VALUE + UOS_CSS_SIGNING_SIZE > + - 0x8000; /* 32k reserved (8K stack + 24k context) */ > + > + DRM_DEBUG_DRIVER("firmware file size %zu (minimum %zu, maximum %zu)\n", > + blobsize, minsize, maxsize); > + > + /* Check the size of the blob befoe examining buffer contents */ > + if (blobsize < minsize || blobsize > maxsize) > + return -ENOEXEC; > + > + guc->fw_major_found = *(u16 *)(css_header + UOS_VER_MAJOR_OFFSET); > + guc->fw_minor_found = *(u16 *)(css_header + UOS_VER_MINOR_OFFSET); > + > + if (guc->fw_major_found != guc->fw_major_wanted || > + guc->fw_minor_found < guc->fw_minor_wanted) { > + DRM_ERROR("GuC firmware version %d.%d, required %d.%d\n", > + guc->fw_major_found, guc->fw_minor_found, > + guc->fw_major_wanted, guc->fw_minor_wanted); > + return -ENOEXEC; > + } > + > + DRM_DEBUG_DRIVER("firmware version %d.%d OK (minimum %d.%d)\n", > + guc->fw_major_found, guc->fw_minor_found, > + guc->fw_major_wanted, guc->fw_minor_wanted); > + > + return INTEL_UC_FW_GOOD; > +} > + > +/** > + * intel_guc_ucode_init() - initiate a firmware loading request > + * > + * Called early during driver load, before GEM is initialised. > + * Driver is single threaded, so no mutex is required. > + * > + * This just sets parameters for use when intel_guc_ucode_load() > + * is called later, after GEM initialisation is complete. > + */ > +void intel_guc_ucode_init(struct drm_device *dev) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + struct intel_guc *guc = &dev_priv->guc; > + struct intel_uc_fw *guc_fw = &guc->guc_fw; > + const char *path; > + > + if (!HAS_GUC_SCHED(dev)) > + i915.enable_guc_submission = false; > + > + if (!HAS_GUC_UCODE(dev)) { > + path = NULL; > + } else if (IS_SKYLAKE(dev)) { > + path = I915_SKL_GUC_UCODE; > + guc->fw_major_wanted = 3; > + guc->fw_minor_wanted = 0; > + } else { > + i915.enable_guc_submission = false; > + path = ""; /* unknown device */ > + } > + > + intel_uc_fw_init(dev, guc_fw, "GuC", path); > +} > + > +/** > + * intel_guc_ucode_load() - load GuC uCode into the device > + * > + * Called from gem_init_hw() during driver loading and also after a GPU reset. > + * > + * Calls the common loader to get the firmware registered earlier. On the first > + * call, this will actually fetch it from the filesystem; thereafter, we will > + * already either have the blob in a GEM object, or have determined that no > + * valid firmware image could be found). > + * > + * If we have a good firmware image, transfer it to the h/w. > + */ > +int intel_guc_ucode_load(struct drm_device *dev) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; > + int err; > + > + DRM_DEBUG_DRIVER("%s fw status: fetch %s, load %s\n", > + guc_fw->uc_name, > + intel_uc_fw_status_repr(guc_fw->uc_fw_fetch_status), > + intel_uc_fw_status_repr(guc_fw->uc_fw_load_status)); > + > + if (guc_fw->uc_fw_fetch_status == INTEL_UC_FIRMWARE_NONE) > + return 0; > + > + if (guc_fw->uc_fw_fetch_status == INTEL_UC_FIRMWARE_SUCCESS && > + guc_fw->uc_fw_load_status == INTEL_UC_FIRMWARE_FAIL) > + return -ENOEXEC; > + > + guc_fw->uc_fw_load_status = INTEL_UC_FIRMWARE_PENDING; > + err = intel_uc_fw_fetch(guc_fw, guc_ucode_check); > + if (err) > + goto fail; > + > + err = guc_ucode_xfer(dev_priv); > + if (err) > + goto fail; > + > + guc_fw->uc_fw_load_status = INTEL_UC_FIRMWARE_SUCCESS; > + > + DRM_DEBUG_DRIVER("%s fw status: fetch %s, load %s\n", > + guc_fw->uc_name, > + intel_uc_fw_status_repr(guc_fw->uc_fw_fetch_status), > + intel_uc_fw_status_repr(guc_fw->uc_fw_load_status)); > + > + return 0; > + > +fail: > + if (guc_fw->uc_fw_load_status == INTEL_UC_FIRMWARE_PENDING) > + guc_fw->uc_fw_load_status = INTEL_UC_FIRMWARE_FAIL; > + > + DRM_ERROR("Failed to initialize GuC, error %d\n", err); > + > + return err; > +} > + > +/** > + * intel_guc_ucode_fini() - clean up all allocated resources > + */ > +void intel_guc_ucode_fini(struct drm_device *dev) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; > + > + intel_uc_fw_fini(guc_fw); > +} > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 06/07/15 15:28, Daniel Vetter wrote: > On Fri, Jul 03, 2015 at 01:30:27PM +0100, Dave Gordon wrote: >> From: Alex Dai <yu.dai@intel.com> >> >> This uses the common firmware loader to fetch the firmware image, >> then loads it into the GuC's memory via a dedicated DMA engine. >> >> This patch is derived from GuC loading work originally done by >> Vinit Azad and Ben Widawsky. It has been reconstructed to accord >> with the common firmware loading mechanism by Dave Gordon as well >> as new firmware layout etc. >> >> v2: >> Various improvements per review comments by Chris Wilson >> >> v3: >> Removed 'wait' parameter to intel_guc_ucode_load() as prefetch >> is no longer supported in the common firmware loader, per >> Daniel Vetter's request. >> F/w checker callback fn now returns errno rather than bool. >> >> Issue: VIZ-4884 >> Signed-off-by: Alex Dai <yu.dai@intel.com> >> Signed-off-by: Dave Gordon <david.s.gordon@intel.com> >> --- >> drivers/gpu/drm/i915/Makefile | 3 + >> drivers/gpu/drm/i915/i915_dma.c | 4 + >> drivers/gpu/drm/i915/i915_drv.h | 11 + >> drivers/gpu/drm/i915/i915_gem.c | 8 + >> drivers/gpu/drm/i915/i915_reg.h | 4 +- >> drivers/gpu/drm/i915/intel_guc.h | 49 ++++ >> drivers/gpu/drm/i915/intel_guc_loader.c | 448 ++++++++++++++++++++++++++++++++ >> 7 files changed, 526 insertions(+), 1 deletion(-) >> create mode 100644 drivers/gpu/drm/i915/intel_guc.h >> create mode 100644 drivers/gpu/drm/i915/intel_guc_loader.c >> >> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile >> index f1f80fc..62a8c83 100644 >> --- a/drivers/gpu/drm/i915/Makefile >> +++ b/drivers/gpu/drm/i915/Makefile >> @@ -42,6 +42,9 @@ i915-y += i915_cmd_parser.o \ >> # generic ancilliary microcontroller support >> i915-y += intel_uc_loader.o >> >> +# general-purpose microcontroller (GuC) support >> +i915-y += intel_guc_loader.o >> + >> # autogenerated null render state >> i915-y += intel_renderstate_gen6.o \ >> intel_renderstate_gen7.o \ >> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c >> index c5349fa..730d91b 100644 >> --- a/drivers/gpu/drm/i915/i915_dma.c >> +++ b/drivers/gpu/drm/i915/i915_dma.c >> @@ -469,6 +469,7 @@ static int i915_load_modeset_init(struct drm_device *dev) >> >> cleanup_gem: >> mutex_lock(&dev->struct_mutex); >> + intel_guc_ucode_fini(dev); >> i915_gem_cleanup_ringbuffer(dev); >> i915_gem_context_fini(dev); >> mutex_unlock(&dev->struct_mutex); >> @@ -866,6 +867,8 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) >> >> intel_uncore_init(dev); >> >> + intel_guc_ucode_init(dev); >> + >> /* Load CSR Firmware for SKL */ >> intel_csr_ucode_init(dev); >> >> @@ -1117,6 +1120,7 @@ int i915_driver_unload(struct drm_device *dev) >> flush_workqueue(dev_priv->wq); >> >> mutex_lock(&dev->struct_mutex); >> + intel_guc_ucode_fini(dev); >> i915_gem_cleanup_ringbuffer(dev); >> i915_gem_context_fini(dev); >> mutex_unlock(&dev->struct_mutex); >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h >> index 9618f57..a7ccac5 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.h >> +++ b/drivers/gpu/drm/i915/i915_drv.h >> @@ -50,6 +50,7 @@ >> #include <linux/intel-iommu.h> >> #include <linux/kref.h> >> #include <linux/pm_qos.h> >> +#include "intel_guc.h" >> >> /* General customization: >> */ >> @@ -1687,6 +1688,8 @@ struct drm_i915_private { >> >> struct i915_virtual_gpu vgpu; >> >> + struct intel_guc guc; >> + >> struct intel_csr csr; >> >> /* Display CSR-related protection */ >> @@ -1931,6 +1934,11 @@ static inline struct drm_i915_private *dev_to_i915(struct device *dev) >> return to_i915(dev_get_drvdata(dev)); >> } >> >> +static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc) >> +{ >> + return container_of(guc, struct drm_i915_private, guc); >> +} >> + >> /* Iterate over initialised rings */ >> #define for_each_ring(ring__, dev_priv__, i__) \ >> for ((i__) = 0; (i__) < I915_NUM_RINGS; (i__)++) \ >> @@ -2539,6 +2547,9 @@ struct drm_i915_cmd_table { >> >> #define HAS_CSR(dev) (IS_SKYLAKE(dev)) >> >> +#define HAS_GUC_UCODE(dev) (IS_GEN9(dev)) >> +#define HAS_GUC_SCHED(dev) (IS_GEN9(dev)) >> + >> #define INTEL_PCH_DEVICE_ID_MASK 0xff00 >> #define INTEL_PCH_IBX_DEVICE_ID_TYPE 0x3b00 >> #define INTEL_PCH_CPT_DEVICE_ID_TYPE 0x1c00 >> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c >> index aa8f4c3..80d7890 100644 >> --- a/drivers/gpu/drm/i915/i915_gem.c >> +++ b/drivers/gpu/drm/i915/i915_gem.c >> @@ -5076,6 +5076,14 @@ i915_gem_init_hw(struct drm_device *dev) >> goto out; >> } >> >> + /* >> + * We can't enable contexts until all firmware is loaded; if this >> + * fails, disable GuC submissions and fall back to execlist mode >> + */ >> + ret = intel_guc_ucode_load(dev); >> + if (ret) >> + i915.enable_guc_submission = false; > > I want an -EIO or similar here since runtime fallbacks to other modes > really aren't great from a maintainance perspective, see my comments on > the irq routing code. > > Yes we can make this work, but givin our stellar track record with keeping > disabled features working it won't work for long. And it will impact us > with additional constraints until we give up and rip it out again. Not > worth it imo - if we decide to use the guc on a given platform we should > imo require it and stick to that decision for at least as long as the > driver is loaded. Developers can still change the option when reloading the > driver, users won't have a chance to cause trouble. > -Daniel Again, this isn't really "runtime" -- we're still in the driver loading stage here. This is analogous to the various "sanitize" functions where we cross-check what options have been set and decide which to override, except that here we can't determine whether we're going to respect the default or user-specified request for GuC submission mode until we know whether we have valid firmware for the GuC. At this point, we haven't submitted any batches, so the main point of use of this flag -- in the submission path, to switch between execlist and GuC modes -- has never yet been executed. So there should be no problem with changing the value before it's first used. And this is a one-way switch; you (or the default config) asked for GuC submission, but we can't support it so we disable the option. There's no way to switch it back on without reloading the driver. So this /is/ the point at which we decide to use the GuC on a given platform and then stick to that decision for at least as long as the driver is loaded. We have to support execlist mode for the foreseeable future anyway, so using it on a machine which (we think) ought to be GuC-capable doesn't add /any/ extra maintenance overhead at all. Why break the user's machine unnecessarily? With real "end-users", especially those who have never used Linux before, you only get one chance. Sometimes I've installed Linux on a (Windows-using) friend's machine, and it hasn't worked first time. Then I switch to another VT, type some magic incantations, and 10 minutes later we have a usable login screen. Will they adopt Linux? Unlikely :( No matter how good it looks thereafter, if the machine's hardware doesn't work with the distro straight out of the box, they're just not going to believe it's something they can use. So it's very important that everything essential to the first-time experience works even when misconfigured -- and nothing is more essential than the display driver (networking and wi-fi are the next things that will put the user off if they don't work -- and they're also drivers that commonly rely on firmware blobs). .Dave.
On Mon, Jul 06, 2015 at 05:37:57PM +0100, Dave Gordon wrote: > On 06/07/15 15:28, Daniel Vetter wrote: > >On Fri, Jul 03, 2015 at 01:30:27PM +0100, Dave Gordon wrote: > >>From: Alex Dai <yu.dai@intel.com> > >> > >>This uses the common firmware loader to fetch the firmware image, > >>then loads it into the GuC's memory via a dedicated DMA engine. > >> > >>This patch is derived from GuC loading work originally done by > >>Vinit Azad and Ben Widawsky. It has been reconstructed to accord > >>with the common firmware loading mechanism by Dave Gordon as well > >>as new firmware layout etc. > >> > >>v2: > >> Various improvements per review comments by Chris Wilson > >> > >>v3: > >> Removed 'wait' parameter to intel_guc_ucode_load() as prefetch > >> is no longer supported in the common firmware loader, per > >> Daniel Vetter's request. > >> F/w checker callback fn now returns errno rather than bool. > >> > >>Issue: VIZ-4884 > >>Signed-off-by: Alex Dai <yu.dai@intel.com> > >>Signed-off-by: Dave Gordon <david.s.gordon@intel.com> > >>--- > >> drivers/gpu/drm/i915/Makefile | 3 + > >> drivers/gpu/drm/i915/i915_dma.c | 4 + > >> drivers/gpu/drm/i915/i915_drv.h | 11 + > >> drivers/gpu/drm/i915/i915_gem.c | 8 + > >> drivers/gpu/drm/i915/i915_reg.h | 4 +- > >> drivers/gpu/drm/i915/intel_guc.h | 49 ++++ > >> drivers/gpu/drm/i915/intel_guc_loader.c | 448 ++++++++++++++++++++++++++++++++ > >> 7 files changed, 526 insertions(+), 1 deletion(-) > >> create mode 100644 drivers/gpu/drm/i915/intel_guc.h > >> create mode 100644 drivers/gpu/drm/i915/intel_guc_loader.c > >> > >>diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > >>index f1f80fc..62a8c83 100644 > >>--- a/drivers/gpu/drm/i915/Makefile > >>+++ b/drivers/gpu/drm/i915/Makefile > >>@@ -42,6 +42,9 @@ i915-y += i915_cmd_parser.o \ > >> # generic ancilliary microcontroller support > >> i915-y += intel_uc_loader.o > >> > >>+# general-purpose microcontroller (GuC) support > >>+i915-y += intel_guc_loader.o > >>+ > >> # autogenerated null render state > >> i915-y += intel_renderstate_gen6.o \ > >> intel_renderstate_gen7.o \ > >>diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > >>index c5349fa..730d91b 100644 > >>--- a/drivers/gpu/drm/i915/i915_dma.c > >>+++ b/drivers/gpu/drm/i915/i915_dma.c > >>@@ -469,6 +469,7 @@ static int i915_load_modeset_init(struct drm_device *dev) > >> > >> cleanup_gem: > >> mutex_lock(&dev->struct_mutex); > >>+ intel_guc_ucode_fini(dev); > >> i915_gem_cleanup_ringbuffer(dev); > >> i915_gem_context_fini(dev); > >> mutex_unlock(&dev->struct_mutex); > >>@@ -866,6 +867,8 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) > >> > >> intel_uncore_init(dev); > >> > >>+ intel_guc_ucode_init(dev); > >>+ > >> /* Load CSR Firmware for SKL */ > >> intel_csr_ucode_init(dev); > >> > >>@@ -1117,6 +1120,7 @@ int i915_driver_unload(struct drm_device *dev) > >> flush_workqueue(dev_priv->wq); > >> > >> mutex_lock(&dev->struct_mutex); > >>+ intel_guc_ucode_fini(dev); > >> i915_gem_cleanup_ringbuffer(dev); > >> i915_gem_context_fini(dev); > >> mutex_unlock(&dev->struct_mutex); > >>diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > >>index 9618f57..a7ccac5 100644 > >>--- a/drivers/gpu/drm/i915/i915_drv.h > >>+++ b/drivers/gpu/drm/i915/i915_drv.h > >>@@ -50,6 +50,7 @@ > >> #include <linux/intel-iommu.h> > >> #include <linux/kref.h> > >> #include <linux/pm_qos.h> > >>+#include "intel_guc.h" > >> > >> /* General customization: > >> */ > >>@@ -1687,6 +1688,8 @@ struct drm_i915_private { > >> > >> struct i915_virtual_gpu vgpu; > >> > >>+ struct intel_guc guc; > >>+ > >> struct intel_csr csr; > >> > >> /* Display CSR-related protection */ > >>@@ -1931,6 +1934,11 @@ static inline struct drm_i915_private *dev_to_i915(struct device *dev) > >> return to_i915(dev_get_drvdata(dev)); > >> } > >> > >>+static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc) > >>+{ > >>+ return container_of(guc, struct drm_i915_private, guc); > >>+} > >>+ > >> /* Iterate over initialised rings */ > >> #define for_each_ring(ring__, dev_priv__, i__) \ > >> for ((i__) = 0; (i__) < I915_NUM_RINGS; (i__)++) \ > >>@@ -2539,6 +2547,9 @@ struct drm_i915_cmd_table { > >> > >> #define HAS_CSR(dev) (IS_SKYLAKE(dev)) > >> > >>+#define HAS_GUC_UCODE(dev) (IS_GEN9(dev)) > >>+#define HAS_GUC_SCHED(dev) (IS_GEN9(dev)) > >>+ > >> #define INTEL_PCH_DEVICE_ID_MASK 0xff00 > >> #define INTEL_PCH_IBX_DEVICE_ID_TYPE 0x3b00 > >> #define INTEL_PCH_CPT_DEVICE_ID_TYPE 0x1c00 > >>diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > >>index aa8f4c3..80d7890 100644 > >>--- a/drivers/gpu/drm/i915/i915_gem.c > >>+++ b/drivers/gpu/drm/i915/i915_gem.c > >>@@ -5076,6 +5076,14 @@ i915_gem_init_hw(struct drm_device *dev) > >> goto out; > >> } > >> > >>+ /* > >>+ * We can't enable contexts until all firmware is loaded; if this > >>+ * fails, disable GuC submissions and fall back to execlist mode > >>+ */ > >>+ ret = intel_guc_ucode_load(dev); > >>+ if (ret) > >>+ i915.enable_guc_submission = false; > > > >I want an -EIO or similar here since runtime fallbacks to other modes > >really aren't great from a maintainance perspective, see my comments on > >the irq routing code. > > > >Yes we can make this work, but givin our stellar track record with keeping > >disabled features working it won't work for long. And it will impact us > >with additional constraints until we give up and rip it out again. Not > >worth it imo - if we decide to use the guc on a given platform we should > >imo require it and stick to that decision for at least as long as the > >driver is loaded. Developers can still change the option when reloading the > >driver, users won't have a chance to cause trouble. > >-Daniel > > Again, this isn't really "runtime" -- we're still in the driver loading > stage here. This is analogous to the various "sanitize" functions where we > cross-check what options have been set and decide which to override, except > that here we can't determine whether we're going to respect the default or > user-specified request for GuC submission mode until we know whether we have > valid firmware for the GuC. The problem is that a pile of code has run already (specifically irq setup). Not a problem from the correctness pov it can all be made to work, but from a longer-term maintainance pov. It'll just bitrot until it's ripped out. But until that happens everyone has to keep it in mind and try not to break this fallback. Too much trouble imo for no real benefit. > At this point, we haven't submitted any batches, so the main point of use of > this flag -- in the submission path, to switch between execlist and GuC > modes -- has never yet been executed. So there should be no problem with > changing the value before it's first used. > > And this is a one-way switch; you (or the default config) asked for GuC > submission, but we can't support it so we disable the option. There's no way > to switch it back on without reloading the driver. So this /is/ the point at > which we decide to use the GuC on a given platform and then stick to that > decision for at least as long as the driver is loaded. > > We have to support execlist mode for the foreseeable future anyway, so using > it on a machine which (we think) ought to be GuC-capable doesn't add /any/ > extra maintenance overhead at all. > > Why break the user's machine unnecessarily? With real "end-users", > especially those who have never used Linux before, you only get one chance. > Sometimes I've installed Linux on a (Windows-using) friend's machine, and it > hasn't worked first time. Then I switch to another VT, type some magic > incantations, and 10 minutes later we have a usable login screen. Will they > adopt Linux? Unlikely :( No matter how good it looks thereafter, if the > machine's hardware doesn't work with the distro straight out of the box, > they're just not going to believe it's something they can use. So it's very > important that everything essential to the first-time experience works even > when misconfigured -- and nothing is more essential than the display driver > (networking and wi-fi are the next things that will put the user off if they > don't work -- and they're also drivers that commonly rely on firmware > blobs). Those end-users install fedora or ubuntu which get the firmware blob loading just right. None of the big other drivers bother with falling back to some other mode if the firmware they need isn't there: radeon just outright bails out, nouveau just disables accel or runtime pm if the firmware blob is only needed for these features. The only user I can see are people allergic to firmware blobs (they can use execlist and we don't care) or developers (can change mod options too). Misconfigured systems from newbies is not a target market, neither for intel nor for upstream (yes we WONTFIX bugs of people with funky configs if the problem doesn't exist on a properly configured distro). -Daniel
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index f1f80fc..62a8c83 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -42,6 +42,9 @@ i915-y += i915_cmd_parser.o \ # generic ancilliary microcontroller support i915-y += intel_uc_loader.o +# general-purpose microcontroller (GuC) support +i915-y += intel_guc_loader.o + # autogenerated null render state i915-y += intel_renderstate_gen6.o \ intel_renderstate_gen7.o \ diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index c5349fa..730d91b 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -469,6 +469,7 @@ static int i915_load_modeset_init(struct drm_device *dev) cleanup_gem: mutex_lock(&dev->struct_mutex); + intel_guc_ucode_fini(dev); i915_gem_cleanup_ringbuffer(dev); i915_gem_context_fini(dev); mutex_unlock(&dev->struct_mutex); @@ -866,6 +867,8 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) intel_uncore_init(dev); + intel_guc_ucode_init(dev); + /* Load CSR Firmware for SKL */ intel_csr_ucode_init(dev); @@ -1117,6 +1120,7 @@ int i915_driver_unload(struct drm_device *dev) flush_workqueue(dev_priv->wq); mutex_lock(&dev->struct_mutex); + intel_guc_ucode_fini(dev); i915_gem_cleanup_ringbuffer(dev); i915_gem_context_fini(dev); mutex_unlock(&dev->struct_mutex); diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 9618f57..a7ccac5 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -50,6 +50,7 @@ #include <linux/intel-iommu.h> #include <linux/kref.h> #include <linux/pm_qos.h> +#include "intel_guc.h" /* General customization: */ @@ -1687,6 +1688,8 @@ struct drm_i915_private { struct i915_virtual_gpu vgpu; + struct intel_guc guc; + struct intel_csr csr; /* Display CSR-related protection */ @@ -1931,6 +1934,11 @@ static inline struct drm_i915_private *dev_to_i915(struct device *dev) return to_i915(dev_get_drvdata(dev)); } +static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc) +{ + return container_of(guc, struct drm_i915_private, guc); +} + /* Iterate over initialised rings */ #define for_each_ring(ring__, dev_priv__, i__) \ for ((i__) = 0; (i__) < I915_NUM_RINGS; (i__)++) \ @@ -2539,6 +2547,9 @@ struct drm_i915_cmd_table { #define HAS_CSR(dev) (IS_SKYLAKE(dev)) +#define HAS_GUC_UCODE(dev) (IS_GEN9(dev)) +#define HAS_GUC_SCHED(dev) (IS_GEN9(dev)) + #define INTEL_PCH_DEVICE_ID_MASK 0xff00 #define INTEL_PCH_IBX_DEVICE_ID_TYPE 0x3b00 #define INTEL_PCH_CPT_DEVICE_ID_TYPE 0x1c00 diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index aa8f4c3..80d7890 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -5076,6 +5076,14 @@ i915_gem_init_hw(struct drm_device *dev) goto out; } + /* + * We can't enable contexts until all firmware is loaded; if this + * fails, disable GuC submissions and fall back to execlist mode + */ + ret = intel_guc_ucode_load(dev); + if (ret) + i915.enable_guc_submission = false; + /* Now it is safe to go back round and do everything else: */ for_each_ring(ring, dev_priv, i) { struct drm_i915_gem_request *req; diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 313b1f9..eefb847 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -6837,7 +6837,9 @@ enum skl_disp_power_wells { #define GEN9_PGCTL_SSB_EU311_ACK (1 << 14) #define GEN7_MISCCPCTL (0x9424) -#define GEN7_DOP_CLOCK_GATE_ENABLE (1<<0) +#define GEN7_DOP_CLOCK_GATE_ENABLE (1<<0) +#define GEN8_DOP_CLOCK_GATE_CFCLK_ENABLE (1<<2) +#define GEN8_DOP_CLOCK_GATE_GUC_ENABLE (1<<4) /* IVYBRIDGE DPF */ #define GEN7_L3CDERRST1 0xB008 /* L3CD Error Status 1 */ diff --git a/drivers/gpu/drm/i915/intel_guc.h b/drivers/gpu/drm/i915/intel_guc.h new file mode 100644 index 0000000..b38d2b0 --- /dev/null +++ b/drivers/gpu/drm/i915/intel_guc.h @@ -0,0 +1,49 @@ +/* + * Copyright © 2014 Intel Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + */ +#ifndef _INTEL_GUC_H_ +#define _INTEL_GUC_H_ + +#include "intel_uc_loader.h" +#include "intel_guc_fwif.h" +#include "i915_guc_reg.h" + +struct intel_guc { + /* Generic uC firmware management */ + struct intel_uc_fw guc_fw; + + /* GuC-specific additions */ + uint16_t fw_major_wanted; + uint16_t fw_minor_wanted; + uint16_t fw_major_found; + uint16_t fw_minor_found; + + uint32_t log_flags; +}; + +/* intel_guc_loader.c */ +extern void intel_guc_ucode_init(struct drm_device *dev); +extern int intel_guc_ucode_load(struct drm_device *dev); +extern void intel_guc_ucode_fini(struct drm_device *dev); + +#endif diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c new file mode 100644 index 0000000..4929838 --- /dev/null +++ b/drivers/gpu/drm/i915/intel_guc_loader.c @@ -0,0 +1,448 @@ +/* + * Copyright © 2014 Intel Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Authors: + * Vinit Azad <vinit.azad@intel.com> + * Ben Widawsky <ben@bwidawsk.net> + * Dave Gordon <david.s.gordon@intel.com> + * Alex Dai <yu.dai@intel.com> + */ +#include <linux/firmware.h> +#include "i915_drv.h" +#include "intel_guc.h" + +/** + * DOC: GuC + * + * intel_guc: + * Top level structure of guc. It handles firmware loading and manages client + * pool and doorbells. intel_guc owns a i915_guc_client to replace the legacy + * ExecList submission. + * + * Firmware versioning: + * The firmware build process will generate a version header file with major and + * minor version defined. The versions are built into CSS header of firmware. + * i915 kernel driver set the minimal firmware version required per platform. + * The firmware installation package will install (symbolic link) proper version + * of firmware. + * + * GuC address space: + * GuC does not allow any gfx GGTT address that falls into range [0, WOPCM_TOP), + * which is reserved for Boot ROM, SRAM and WOPCM. Currently this top address is + * 512K. In order to exclude 0-512K address space from GGTT, all gfx objects + * used by GuC is pinned with PIN_OFFSET_BIAS along with size of WOPCM. + * + * Firmware log: + * Firmware log is enabled by setting i915.guc_log_level to non-negative level. + * Log data is printed out via reading debugfs i915_guc_log_dump. Reading from + * i915_guc_load_status will print out firmware loading status and scratch + * registers value. + * + */ + +#define I915_SKL_GUC_UCODE "i915/skl_guc_ver3.bin" +MODULE_FIRMWARE(I915_SKL_GUC_UCODE); + +static u32 get_gttype(struct drm_i915_private *dev_priv) +{ + /* XXX: GT type based on PCI device ID? field seems unused by fw */ + return 0; +} + +static u32 get_core_family(struct drm_i915_private *dev_priv) +{ + switch (INTEL_INFO(dev_priv)->gen) { + case 8: + return GFXCORE_FAMILY_GEN8; + case 9: + return GFXCORE_FAMILY_GEN9; + default: + DRM_ERROR("GUC: unknown gen for scheduler init\n"); + return GFXCORE_FAMILY_FORCE_ULONG; + } +} + +static void set_guc_init_params(struct drm_i915_private *dev_priv) +{ + struct intel_guc *guc = &dev_priv->guc; + u32 params[GUC_CTL_MAX_DWORDS]; + int i; + + memset(¶ms, 0, sizeof(params)); + + params[GUC_CTL_DEVICE_INFO] |= + (get_gttype(dev_priv) << GUC_CTL_GTTYPE_SHIFT) | + (get_core_family(dev_priv) << GUC_CTL_COREFAMILY_SHIFT); + + /* GuC ARAT increment is 10 ns. GuC default scheduler quantum is one + * second. This ARAR is calculated by: + * Scheduler-Quantum-in-ns / ARAT-increment-in-ns = 1000000000 / 10 + */ + params[GUC_CTL_ARAT_HIGH] = 0; + params[GUC_CTL_ARAT_LOW] = 100000000; + + params[GUC_CTL_WA] |= GUC_CTL_WA_UK_BY_DRIVER; + + params[GUC_CTL_FEATURE] |= GUC_CTL_DISABLE_SCHEDULER | + GUC_CTL_VCS2_ENABLED; + + if (i915.guc_log_level >= 0) { + params[GUC_CTL_LOG_PARAMS] = guc->log_flags; + params[GUC_CTL_DEBUG] = + i915.guc_log_level << GUC_LOG_VERBOSITY_SHIFT; + } + + I915_WRITE(SOFT_SCRATCH(0), 0); + + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++) + I915_WRITE(SOFT_SCRATCH(1 + i), params[i]); +} + +/* + * Read the GuC status register (GUC_STATUS) and store it in the + * specified location; then return a boolean indicating whether + * the value matches either of two values representing completion + * of the GuC boot process. + * + * This is used for polling the GuC status in a wait_for_atomic() + * loop below. + */ +static inline bool guc_ucode_response(struct drm_i915_private *dev_priv, + u32 *status) +{ + u32 val = I915_READ(GUC_STATUS); + *status = val; + return ((val & GS_UKERNEL_MASK) == GS_UKERNEL_READY || + (val & GS_UKERNEL_MASK) == GS_UKERNEL_LAPIC_DONE); +} + +/* + * Transfer the firmware image to RAM for execution by the microcontroller. + * + * GuC Firmware layout: + * +-------------------------------+ ---- + * | CSS header | 128B + * | contains major/minor version | + * +-------------------------------+ ---- + * | uCode | + * +-------------------------------+ ---- + * | RSA signature | 256B + * +-------------------------------+ ---- + * | RSA public Key | 256B + * +-------------------------------+ ---- + * | Public key modulus | 4B + * +-------------------------------+ ---- + * + * Architecturally, the DMA engine is bidirectional, and can potentially even + * transfer between GTT locations. This functionality is left out of the API + * for now as there is no need for it. + * + * Note that GuC needs the CSS header plus uKernel code to be copied by the + * DMA engine in one operation, whereas the RSA signature is loaded via MMIO. + */ + +#define UOS_CSS_HEADER_OFFSET 0 +#define UOS_VER_MINOR_OFFSET 0x44 +#define UOS_VER_MAJOR_OFFSET 0x46 +#define UOS_CSS_HEADER_SIZE 0x80 +#define UOS_RSA_SIG_SIZE 0x100 +#define UOS_CSS_SIGNING_SIZE 0x204 + +static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv) +{ + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; + struct drm_i915_gem_object *fw_obj = guc_fw->uc_fw_obj; + unsigned long offset; + struct sg_table *sg = fw_obj->pages; + u32 status, ucode_size, rsa[UOS_RSA_SIG_SIZE / sizeof(u32)]; + int i, ret = 0; + + /* uCode size, also is where RSA signature starts */ + offset = ucode_size = guc_fw->uc_fw_size - UOS_CSS_SIGNING_SIZE; + + /* Copy RSA signature from the fw image to HW for verification */ + sg_pcopy_to_buffer(sg->sgl, sg->nents, rsa, UOS_RSA_SIG_SIZE, offset); + for (i = 0; i < UOS_RSA_SIG_SIZE / sizeof(u32); i++) + I915_WRITE(UOS_RSA_SCRATCH_0 + i * sizeof(u32), rsa[i]); + + /* Set the source address for the new blob */ + offset = i915_gem_obj_ggtt_offset(fw_obj); + I915_WRITE(DMA_ADDR_0_LOW, lower_32_bits(offset)); + I915_WRITE(DMA_ADDR_0_HIGH, upper_32_bits(offset) & 0xFFFF); + + /* Set the destination. Current uCode expects an 8k stack starting from + * offset 0. */ + I915_WRITE(DMA_ADDR_1_LOW, 0x2000); + + /* XXX: The image is automatically transfered to SRAM after the RSA + * verification. This is why the address space is chosen as such. */ + I915_WRITE(DMA_ADDR_1_HIGH, DMA_ADDRESS_SPACE_WOPCM); + + I915_WRITE(DMA_COPY_SIZE, ucode_size); + + /* Finally start the DMA */ + I915_WRITE(DMA_CTRL, _MASKED_BIT_ENABLE(UOS_MOVE | START_DMA)); + + /* + * Spin-wait for the DMA to complete & the GuC to start up. + * NB: Docs recommend not using the interrupt for completion. + * Measurements indicate this should take no more than 20ms, so a + * timeout here indicates that the GuC has failed and is unusable. + * (Higher levels of the driver will attempt to fall back to + * execlist mode if this happens.) + */ + ret = wait_for_atomic(guc_ucode_response(dev_priv, &status), 100); + + DRM_DEBUG_DRIVER("DMA status 0x%x, GuC status 0x%x\n", + I915_READ(DMA_CTRL), status); + + if ((status & GS_BOOTROM_MASK) == GS_BOOTROM_RSA_FAILED) { + DRM_ERROR("%s firmware signature verification failed\n", + guc_fw->uc_name); + ret = -ENOEXEC; + } + + DRM_DEBUG_DRIVER("returning %d\n", ret); + + return ret; +} + +/* + * Load the GuC firmware blob into the MinuteIA. + */ +static int guc_ucode_xfer(struct drm_i915_private *dev_priv) +{ + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; + struct drm_device *dev = dev_priv->dev; + int ret; + + ret = i915_gem_object_set_to_gtt_domain(guc_fw->uc_fw_obj, false); + if (ret) { + DRM_DEBUG_DRIVER("set-domain failed %d\n", ret); + return ret; + } + + ret = i915_gem_obj_ggtt_pin(guc_fw->uc_fw_obj, 0, 0); + if (ret) { + DRM_DEBUG_DRIVER("pin failed %d\n", ret); + return ret; + } + + WARN_ON(!mutex_is_locked(&dev->struct_mutex)); + intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL); + + /* init WOPCM */ + I915_WRITE(GUC_WOPCM_SIZE, GUC_WOPCM_SIZE_VALUE); + I915_WRITE(DMA_GUC_WOPCM_OFFSET, GUC_WOPCM_OFFSET); + + /* Invalidate GuC TLB to let GuC take the latest updates to GTT. */ + I915_WRITE(GEN8_GTCR, GEN8_GTCR_INVALIDATE); + + /* Set MMIO/WA for GuC init */ + I915_WRITE(DRBMISC1, DOORBELL_ENABLE); + + /* Enable MIA caching. GuC clock gating is disabled. */ + I915_WRITE(GUC_SHIM_CONTROL, GUC_SHIM_CONTROL_VALUE); + + /* WaC6DisallowByGfxPause*/ + I915_WRITE(GEN6_GFXPAUSE, 0x30FFF); + + if (IS_SKYLAKE(dev)) + I915_WRITE(GEN9_GT_PM_CONFIG, GEN8_GT_DOORBELL_ENABLE); + else + I915_WRITE(GEN8_GT_PM_CONFIG, GEN8_GT_DOORBELL_ENABLE); + + if (IS_GEN9(dev)) { + /* DOP Clock Gating Enable for GuC clocks */ + I915_WRITE(GEN7_MISCCPCTL, (GEN8_DOP_CLOCK_GATE_GUC_ENABLE | + I915_READ(GEN7_MISCCPCTL))); + + /* allows for 5us before GT can go to RC6 */ + I915_WRITE(GUC_ARAT_C6DIS, 0x1FF); + } + + set_guc_init_params(dev_priv); + + ret = guc_ucode_xfer_dma(dev_priv); + + intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL); + + /* + * We keep the object pages for reuse during resume. But we can unpin it + * now that DMA has completed, so it doesn't continue to take up space. + */ + i915_gem_object_ggtt_unpin(guc_fw->uc_fw_obj); + + return ret; +} + +/* + * Check the firmware that was found; if it's the wrong size or the wrong + * version, return a negative error code. If it's OK, return a positive + * status value. Here we can just return INTEL_UC_FW_GOOD; the common loader + * code will then save the data for later in a pageable (tmpfs-backed) GEM + * object. + * + * Alternatively (for example if we wanted only part of the image) we could + * save the required portion here and then return INTEL_UC_FW_SAVED to tell + * the common loader that the data is good, and we've already handled saving + * anything we need later. + * + * The GuC firmware image has the version number embedded at a well-known + * offset within the firmware blob; note that major / minor version are + * TWO bytes each (i.e. u16), although all pointers and offsets are defined + * in terms of bytes (u8). + */ +static int guc_ucode_check(struct intel_uc_fw *guc_fw) +{ + struct intel_guc *guc = container_of(guc_fw, struct intel_guc, guc_fw); + const u8 *css_header = guc_fw->uc_fw_blob->data + UOS_CSS_HEADER_OFFSET; + const size_t blobsize = guc_fw->uc_fw_blob->size; + const size_t minsize = UOS_CSS_HEADER_SIZE + UOS_CSS_SIGNING_SIZE; + const size_t maxsize = GUC_WOPCM_SIZE_VALUE + UOS_CSS_SIGNING_SIZE + - 0x8000; /* 32k reserved (8K stack + 24k context) */ + + DRM_DEBUG_DRIVER("firmware file size %zu (minimum %zu, maximum %zu)\n", + blobsize, minsize, maxsize); + + /* Check the size of the blob befoe examining buffer contents */ + if (blobsize < minsize || blobsize > maxsize) + return -ENOEXEC; + + guc->fw_major_found = *(u16 *)(css_header + UOS_VER_MAJOR_OFFSET); + guc->fw_minor_found = *(u16 *)(css_header + UOS_VER_MINOR_OFFSET); + + if (guc->fw_major_found != guc->fw_major_wanted || + guc->fw_minor_found < guc->fw_minor_wanted) { + DRM_ERROR("GuC firmware version %d.%d, required %d.%d\n", + guc->fw_major_found, guc->fw_minor_found, + guc->fw_major_wanted, guc->fw_minor_wanted); + return -ENOEXEC; + } + + DRM_DEBUG_DRIVER("firmware version %d.%d OK (minimum %d.%d)\n", + guc->fw_major_found, guc->fw_minor_found, + guc->fw_major_wanted, guc->fw_minor_wanted); + + return INTEL_UC_FW_GOOD; +} + +/** + * intel_guc_ucode_init() - initiate a firmware loading request + * + * Called early during driver load, before GEM is initialised. + * Driver is single threaded, so no mutex is required. + * + * This just sets parameters for use when intel_guc_ucode_load() + * is called later, after GEM initialisation is complete. + */ +void intel_guc_ucode_init(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + struct intel_guc *guc = &dev_priv->guc; + struct intel_uc_fw *guc_fw = &guc->guc_fw; + const char *path; + + if (!HAS_GUC_SCHED(dev)) + i915.enable_guc_submission = false; + + if (!HAS_GUC_UCODE(dev)) { + path = NULL; + } else if (IS_SKYLAKE(dev)) { + path = I915_SKL_GUC_UCODE; + guc->fw_major_wanted = 3; + guc->fw_minor_wanted = 0; + } else { + i915.enable_guc_submission = false; + path = ""; /* unknown device */ + } + + intel_uc_fw_init(dev, guc_fw, "GuC", path); +} + +/** + * intel_guc_ucode_load() - load GuC uCode into the device + * + * Called from gem_init_hw() during driver loading and also after a GPU reset. + * + * Calls the common loader to get the firmware registered earlier. On the first + * call, this will actually fetch it from the filesystem; thereafter, we will + * already either have the blob in a GEM object, or have determined that no + * valid firmware image could be found). + * + * If we have a good firmware image, transfer it to the h/w. + */ +int intel_guc_ucode_load(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; + int err; + + DRM_DEBUG_DRIVER("%s fw status: fetch %s, load %s\n", + guc_fw->uc_name, + intel_uc_fw_status_repr(guc_fw->uc_fw_fetch_status), + intel_uc_fw_status_repr(guc_fw->uc_fw_load_status)); + + if (guc_fw->uc_fw_fetch_status == INTEL_UC_FIRMWARE_NONE) + return 0; + + if (guc_fw->uc_fw_fetch_status == INTEL_UC_FIRMWARE_SUCCESS && + guc_fw->uc_fw_load_status == INTEL_UC_FIRMWARE_FAIL) + return -ENOEXEC; + + guc_fw->uc_fw_load_status = INTEL_UC_FIRMWARE_PENDING; + err = intel_uc_fw_fetch(guc_fw, guc_ucode_check); + if (err) + goto fail; + + err = guc_ucode_xfer(dev_priv); + if (err) + goto fail; + + guc_fw->uc_fw_load_status = INTEL_UC_FIRMWARE_SUCCESS; + + DRM_DEBUG_DRIVER("%s fw status: fetch %s, load %s\n", + guc_fw->uc_name, + intel_uc_fw_status_repr(guc_fw->uc_fw_fetch_status), + intel_uc_fw_status_repr(guc_fw->uc_fw_load_status)); + + return 0; + +fail: + if (guc_fw->uc_fw_load_status == INTEL_UC_FIRMWARE_PENDING) + guc_fw->uc_fw_load_status = INTEL_UC_FIRMWARE_FAIL; + + DRM_ERROR("Failed to initialize GuC, error %d\n", err); + + return err; +} + +/** + * intel_guc_ucode_fini() - clean up all allocated resources + */ +void intel_guc_ucode_fini(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw; + + intel_uc_fw_fini(guc_fw); +}