diff mbox

[06/12] drm/i915/bxt: Add WaStoreMultiplePTEenable name

Message ID 1443188026-1222-7-git-send-email-arun.siluvery@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

arun.siluvery@linux.intel.com Sept. 25, 2015, 1:33 p.m. UTC
Updated WA with the name.

Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Ville Syrjälä Sept. 25, 2015, 5:34 p.m. UTC | #1
On Fri, Sep 25, 2015 at 02:33:40PM +0100, Arun Siluvery wrote:
> Updated WA with the name.
> 
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index c73d37d..9151a2b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -136,13 +136,10 @@ static void bxt_init_clock_gating(struct drm_device *dev)
>  					  GEN8_HDCUNIT_CLOCK_GATE_DISABLE_HDCREQ));
>  	}
>  
> -	if (INTEL_REVID(dev) == BXT_REVID_A0) {
> -		/*
> -		 * Hardware specification requires this bit to be
> -		 * set to 1 for A0
> -		 */
> +	/* WaStoreMultiplePTEenable:bxt */
> +	/* This is a requirement according to Hardware specification */
> +	if (INTEL_REVID(dev) == BXT_REVID_A0)
>  		I915_WRITE(TILECTL, I915_READ(TILECTL) | TILECTL_TLBPF);
> -	}
>  
>  	/* WaSetClckGatingDisableMedia:bxt */
>  	if (INTEL_REVID(dev) == BXT_REVID_A0) {
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter Sept. 28, 2015, 1:57 p.m. UTC | #2
On Fri, Sep 25, 2015 at 08:34:19PM +0300, Ville Syrjälä wrote:
> On Fri, Sep 25, 2015 at 02:33:40PM +0100, Arun Siluvery wrote:
> > Updated WA with the name.
> > 
> > Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index c73d37d..9151a2b 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -136,13 +136,10 @@  static void bxt_init_clock_gating(struct drm_device *dev)
 					  GEN8_HDCUNIT_CLOCK_GATE_DISABLE_HDCREQ));
 	}
 
-	if (INTEL_REVID(dev) == BXT_REVID_A0) {
-		/*
-		 * Hardware specification requires this bit to be
-		 * set to 1 for A0
-		 */
+	/* WaStoreMultiplePTEenable:bxt */
+	/* This is a requirement according to Hardware specification */
+	if (INTEL_REVID(dev) == BXT_REVID_A0)
 		I915_WRITE(TILECTL, I915_READ(TILECTL) | TILECTL_TLBPF);
-	}
 
 	/* WaSetClckGatingDisableMedia:bxt */
 	if (INTEL_REVID(dev) == BXT_REVID_A0) {