drm/i915/skl: Update DDI translation tables for SKL

Message ID	1446852654-883-1-git-send-email-jim.bride@linux.intel.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <intel-gfx-bounces@lists.freedesktop.org> From: Jim Bride <jim.bride@linux.intel.com> To: intel-gfx@lists.freedesktop.org Date: Fri, 6 Nov 2015 15:30:54 -0800 Message-Id: <1446852654-883-1-git-send-email-jim.bride@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Subject: [Intel-gfx] [PATCH] drm/i915/skl: Update DDI translation tables for SKL Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>

Message ID

1446852654-883-1-git-send-email-jim.bride@linux.intel.com (mailing list archive)

State

New, archived

Headers

From: Jim Bride <jim.bride@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Date: Fri,  6 Nov 2015 15:30:54 -0800
Message-Id: <1446852654-883-1-git-send-email-jim.bride@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [Intel-gfx] [PATCH] drm/i915/skl: Update DDI translation tables for
	SKL
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>

Commit Message

jim.bride@linux.intel.com Nov. 6, 2015, 11:30 p.m. UTC

While comparing the B-Spec with the code I noticed that several
values in these tables have been updated in the spec, so I
changed the code to match..

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Jim Bride <jim.bride@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

Comments

Ander Conselvan de Oliveira Nov. 11, 2015, 1:02 p.m. UTC | #1

On Fri, 2015-11-06 at 15:30 -0800, Jim Bride wrote:
> While comparing the B-Spec with the code I noticed that several
> values in these tables have been updated in the spec, so I
> changed the code to match..
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Jim Bride <jim.bride@linux.intel.com>

Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 036ff9b..d0062ad 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -133,12 +133,12 @@ static const struct ddi_buf_trans
> skl_ddi_translations_dp[] = {
>  	{ 0x00002016, 0x000000A0, 0x0 },
>  	{ 0x00005012, 0x0000009B, 0x0 },
>  	{ 0x00007011, 0x00000088, 0x0 },
> -	{ 0x00009010, 0x000000C7, 0x0 },
> +	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
>  	{ 0x00002016, 0x0000009B, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
> -	{ 0x00007011, 0x000000C7, 0x0 },
> +	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
>  	{ 0x00002016, 0x000000DF, 0x0 },
> -	{ 0x00005012, 0x000000C7, 0x0 },
> +	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
>  };
>  
>  /* Skylake U */
> @@ -146,12 +146,12 @@ static const struct ddi_buf_trans
> skl_u_ddi_translations_dp[] = {
>  	{ 0x0000201B, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
>  	{ 0x00007011, 0x00000087, 0x0 },
> -	{ 0x80009010, 0x000000C7, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
>  	{ 0x0000201B, 0x0000009D, 0x0 },
> -	{ 0x00005012, 0x000000C7, 0x0 },
> -	{ 0x00007011, 0x000000C7, 0x0 },
> +	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
>  	{ 0x00002016, 0x00000088, 0x0 },
> -	{ 0x00005012, 0x000000C7, 0x0 },
> +	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
>  };
>  
>  /* Skylake Y */
> @@ -159,12 +159,12 @@ static const struct ddi_buf_trans
> skl_y_ddi_translations_dp[] = {
>  	{ 0x00000018, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
>  	{ 0x00007011, 0x00000087, 0x0 },
> -	{ 0x80009010, 0x000000C7, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80009010, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
>  	{ 0x00000018, 0x0000009D, 0x0 },
> -	{ 0x00005012, 0x000000C7, 0x0 },
> -	{ 0x00007011, 0x000000C7, 0x0 },
> +	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80007011, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
>  	{ 0x00000018, 0x00000088, 0x0 },
> -	{ 0x00005012, 0x000000C7, 0x0 },
> +	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
>  };
>  
>  /*

Ander Conselvan de Oliveira Nov. 13, 2015, 12:39 p.m. UTC | #2

On Wed, 2015-11-11 at 15:02 +0200, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-11-06 at 15:30 -0800, Jim Bride wrote:
> > While comparing the B-Spec with the code I noticed that several
> > values in these tables have been updated in the spec, so I
> > changed the code to match..
> > 
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Jim Bride <jim.bride@linux.intel.com>
> 
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

Pushed to dinq. Thanks for the patch.

Ander

> 
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
> >  1 file changed, 11 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index 036ff9b..d0062ad 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -133,12 +133,12 @@ static const struct ddi_buf_trans
> > skl_ddi_translations_dp[] = {
> >  	{ 0x00002016, 0x000000A0, 0x0 },
> >  	{ 0x00005012, 0x0000009B, 0x0 },
> >  	{ 0x00007011, 0x00000088, 0x0 },
> > -	{ 0x00009010, 0x000000C7, 0x0 },
> > +	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1
> > */
> >  	{ 0x00002016, 0x0000009B, 0x0 },
> >  	{ 0x00005012, 0x00000088, 0x0 },
> > -	{ 0x00007011, 0x000000C7, 0x0 },
> > +	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1
> > */
> >  	{ 0x00002016, 0x000000DF, 0x0 },
> > -	{ 0x00005012, 0x000000C7, 0x0 },
> > +	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1
> > */
> >  };
> >  
> >  /* Skylake U */
> > @@ -146,12 +146,12 @@ static const struct ddi_buf_trans
> > skl_u_ddi_translations_dp[] = {
> >  	{ 0x0000201B, 0x000000A2, 0x0 },
> >  	{ 0x00005012, 0x00000088, 0x0 },
> >  	{ 0x00007011, 0x00000087, 0x0 },
> > -	{ 0x80009010, 0x000000C7, 0x1 },	/* Uses I_boost level 0x1
> > */
> > +	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1
> > */
> >  	{ 0x0000201B, 0x0000009D, 0x0 },
> > -	{ 0x00005012, 0x000000C7, 0x0 },
> > -	{ 0x00007011, 0x000000C7, 0x0 },
> > +	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1
> > */
> > +	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1
> > */
> >  	{ 0x00002016, 0x00000088, 0x0 },
> > -	{ 0x00005012, 0x000000C7, 0x0 },
> > +	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1
> > */
> >  };
> >  
> >  /* Skylake Y */
> > @@ -159,12 +159,12 @@ static const struct ddi_buf_trans
> > skl_y_ddi_translations_dp[] = {
> >  	{ 0x00000018, 0x000000A2, 0x0 },
> >  	{ 0x00005012, 0x00000088, 0x0 },
> >  	{ 0x00007011, 0x00000087, 0x0 },
> > -	{ 0x80009010, 0x000000C7, 0x3 },	/* Uses I_boost level 0x3
> > */
> > +	{ 0x80009010, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3
> > */
> >  	{ 0x00000018, 0x0000009D, 0x0 },
> > -	{ 0x00005012, 0x000000C7, 0x0 },
> > -	{ 0x00007011, 0x000000C7, 0x0 },
> > +	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3
> > */
> > +	{ 0x80007011, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3
> > */
> >  	{ 0x00000018, 0x00000088, 0x0 },
> > -	{ 0x00005012, 0x000000C7, 0x0 },
> > +	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3
> > */
> >  };
> >  
> >  /*

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 036ff9b..d0062ad 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -133,12 +133,12 @@  static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
 	{ 0x00002016, 0x000000A0, 0x0 },
 	{ 0x00005012, 0x0000009B, 0x0 },
 	{ 0x00007011, 0x00000088, 0x0 },
-	{ 0x00009010, 0x000000C7, 0x0 },
+	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
 	{ 0x00002016, 0x0000009B, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
-	{ 0x00007011, 0x000000C7, 0x0 },
+	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
 	{ 0x00002016, 0x000000DF, 0x0 },
-	{ 0x00005012, 0x000000C7, 0x0 },
+	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
 };
 
 /* Skylake U */
@@ -146,12 +146,12 @@  static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
 	{ 0x0000201B, 0x000000A2, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
 	{ 0x00007011, 0x00000087, 0x0 },
-	{ 0x80009010, 0x000000C7, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
 	{ 0x0000201B, 0x0000009D, 0x0 },
-	{ 0x00005012, 0x000000C7, 0x0 },
-	{ 0x00007011, 0x000000C7, 0x0 },
+	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
 	{ 0x00002016, 0x00000088, 0x0 },
-	{ 0x00005012, 0x000000C7, 0x0 },
+	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
 };
 
 /* Skylake Y */
@@ -159,12 +159,12 @@  static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
 	{ 0x00000018, 0x000000A2, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
 	{ 0x00007011, 0x00000087, 0x0 },
-	{ 0x80009010, 0x000000C7, 0x3 },	/* Uses I_boost level 0x3 */
+	{ 0x80009010, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
 	{ 0x00000018, 0x0000009D, 0x0 },
-	{ 0x00005012, 0x000000C7, 0x0 },
-	{ 0x00007011, 0x000000C7, 0x0 },
+	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
+	{ 0x80007011, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
 	{ 0x00000018, 0x00000088, 0x0 },
-	{ 0x00005012, 0x000000C7, 0x0 },
+	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
 };
 
 /*

drm/i915/skl: Update DDI translation tables for SKL

Commit Message

Comments

Patch