diff mbox

drm/i915/skl: Add missing SKL GT3 id

Message ID 1454062346-22778-1-git-send-email-michal.winiarski@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

MichaƂ Winiarski Jan. 29, 2016, 10:12 a.m. UTC
Mesa uses it as Intel(R) Iris Graphics 550 (Skylake GT3e)

Signed-off-by: Micha? Winiarski <michal.winiarski@intel.com>
---
 include/drm/i915_pciids.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Mika Kuoppala Jan. 29, 2016, 4:31 p.m. UTC | #1
Micha? Winiarski <michal.winiarski@intel.com> writes:

> Mesa uses it as Intel(R) Iris Graphics 550 (Skylake GT3e)
>

Apparently this is not only we are missing:

0x1923
0x1902
0x1906

Could you please add these also.

Thanks,
-Mika


> Signed-off-by: Micha? Winiarski <michal.winiarski@intel.com>
> ---
>  include/drm/i915_pciids.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index f970209..eb198d0 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -278,6 +278,7 @@
>  
>  #define INTEL_SKL_GT3_IDS(info) \
>  	INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \
> +	INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
>  	INTEL_VGA_DEVICE(0x192A, info)  /* SRV GT3 */
>  
> -- 
> 2.5.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Mika Kuoppala Feb. 1, 2016, 11:23 a.m. UTC | #2
Patchwork <patchwork@annarchy.freedesktop.org> writes:

> == Summary ==
>
> Series 2919v2 drm/i915/skl: Add missing SKL GT3 id
> http://patchwork.freedesktop.org/api/1.0/series/2919/revisions/2/mbox/
>
> Test kms_pipe_crc_basic:
>         Subgroup suspend-read-crc-pipe-a:
>                 incomplete -> PASS       (hsw-gt2)
>         Subgroup suspend-read-crc-pipe-c:
>                 dmesg-warn -> PASS       (bsw-nuc-2)
>
> bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9  
> bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12 
> bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30 
> byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23 
> hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13 
> hsw-gt2          total:159  pass:149  dwarn:0   dfail:0   fail:0   skip:10 
> ilk-hp8440p      total:159  pass:111  dwarn:0   dfail:0   fail:0   skip:48 
> ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14 
> snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22 
>
> HANGED skl-i5k-2 in igt@gem_sync@basic-blt
>
This seems to be the Nightly base which has hanged, not with the patch
applied. Still the run was failure. Tomi whats up with this?

-Mika


> Results at /archive/results/CI_IGT_test/Patchwork_1328/
>
> 6b1049b84dcd979f631d15b2ada325d8e5b2c4e1 drm-intel-nightly: 2016y-01m-29d-22h-50m-57s UTC integration manifest
> 4e52a4b9960b2761c6daef4374b8a2695212413a drm/i915/skl: Add missing SKL ids
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Sarvela, Tomi P Feb. 1, 2016, 11:35 a.m. UTC | #3
> From: Mika Kuoppala [mailto:mika.kuoppala@linux.intel.com]

>

> Patchwork <patchwork@annarchy.freedesktop.org> writes:

> 

> > Series 2919v2 drm/i915/skl: Add missing SKL GT3 id

> > http://patchwork.freedesktop.org/api/1.0/series/2919/revisions/2/mbox/

> >

> > Test kms_pipe_crc_basic:

> >         Subgroup suspend-read-crc-pipe-a:

> >                 incomplete -> PASS       (hsw-gt2)

> >         Subgroup suspend-read-crc-pipe-c:

> >                 dmesg-warn -> PASS       (bsw-nuc-2)

> >

> > bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9

> > bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12

> > bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30

> > byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23

> > hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13

> > hsw-gt2          total:159  pass:149  dwarn:0   dfail:0   fail:0   skip:10

> > ilk-hp8440p      total:159  pass:111  dwarn:0   dfail:0   fail:0   skip:48

> > ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14

> > snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22

> >

> > HANGED skl-i5k-2 in igt@gem_sync@basic-blt

> >

> This seems to be the Nightly base which has hanged, not with the patch

> applied. Still the run was failure. Tomi whats up with this?


No, the hang is with patch applied. Might be unrelated to patch, but hang
nonetheless. From igt/piglit log

Linux skl-i5k-2 4.5.0-rc1-gfxbench+ #1 SMP PREEMPT Mon Feb 1 10:06:18 EET 2016 x86_64 x86_64 x86_64 GNU/Linux
Nightly_445 Patchwork_1328

[...]

[053/159] skip: 7, pass: 45, dmesg-warn: 1 /
skip: igt/gem_storedw_loop/basic-bsd2       

[054/159] skip: 8, pass: 45, dmesg-warn: 1 /
running: igt/gem_sync/basic-blt             

[054/159] skip: 8, pass: 45, dmesg-warn: 1 -
Build timed out (after 10 minutes). Marking the build as aborted.
ERROR: remote file operation failed: /opt/jenkins/workspace/CI_IGT_test at hudson.remoting.Channel@5906ab1e:igt-skl-i5k-2: hudson.remoting.ChannelClosedException: channel is already closed
Build was aborted

> > Results at /archive/results/CI_IGT_test/Patchwork_1328/

> >

> > 6b1049b84dcd979f631d15b2ada325d8e5b2c4e1 drm-intel-nightly: 2016y-

> 01m-29d-22h-50m-57s UTC integration manifest

> > 4e52a4b9960b2761c6daef4374b8a2695212413a drm/i915/skl: Add missing

> SKL ids


Here you can see the relevant commit ids.

Tomi
Mika Kuoppala Feb. 1, 2016, 12:16 p.m. UTC | #4
"Sarvela, Tomi P" <tomi.p.sarvela@intel.com> writes:

>> From: Mika Kuoppala [mailto:mika.kuoppala@linux.intel.com]
>>
>> Patchwork <patchwork@annarchy.freedesktop.org> writes:
>> 
>> > Series 2919v2 drm/i915/skl: Add missing SKL GT3 id
>> > http://patchwork.freedesktop.org/api/1.0/series/2919/revisions/2/mbox/
>> >
>> > Test kms_pipe_crc_basic:
>> >         Subgroup suspend-read-crc-pipe-a:
>> >                 incomplete -> PASS       (hsw-gt2)
>> >         Subgroup suspend-read-crc-pipe-c:
>> >                 dmesg-warn -> PASS       (bsw-nuc-2)
>> >
>> > bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9
>> > bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12
>> > bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30
>> > byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23
>> > hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13
>> > hsw-gt2          total:159  pass:149  dwarn:0   dfail:0   fail:0   skip:10
>> > ilk-hp8440p      total:159  pass:111  dwarn:0   dfail:0   fail:0   skip:48
>> > ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14
>> > snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22
>> >
>> > HANGED skl-i5k-2 in igt@gem_sync@basic-blt
>> >
>> This seems to be the Nightly base which has hanged, not with the patch
>> applied. Still the run was failure. Tomi whats up with this?
>
> No, the hang is with patch applied. Might be unrelated to patch, but hang
> nonetheless. From igt/piglit log
>

Ok. Then the rendering of the Patchwork_1328 report is somehow wrong as
in that picture the HANG box is in the nightly base column.

-Mika

> Linux skl-i5k-2 4.5.0-rc1-gfxbench+ #1 SMP PREEMPT Mon Feb 1 10:06:18 EET 2016 x86_64 x86_64 x86_64 GNU/Linux
> Nightly_445 Patchwork_1328
>
> [...]
>
> [053/159] skip: 7, pass: 45, dmesg-warn: 1 /
> skip: igt/gem_storedw_loop/basic-bsd2       
>
> [054/159] skip: 8, pass: 45, dmesg-warn: 1 /
> running: igt/gem_sync/basic-blt             
>
> [054/159] skip: 8, pass: 45, dmesg-warn: 1 -
> Build timed out (after 10 minutes). Marking the build as aborted.
> ERROR: remote file operation failed: /opt/jenkins/workspace/CI_IGT_test at hudson.remoting.Channel@5906ab1e:igt-skl-i5k-2: hudson.remoting.ChannelClosedException: channel is already closed
> Build was aborted
>
>> > Results at /archive/results/CI_IGT_test/Patchwork_1328/
>> >
>> > 6b1049b84dcd979f631d15b2ada325d8e5b2c4e1 drm-intel-nightly: 2016y-
>> 01m-29d-22h-50m-57s UTC integration manifest
>> > 4e52a4b9960b2761c6daef4374b8a2695212413a drm/i915/skl: Add missing
>> SKL ids
>
> Here you can see the relevant commit ids.
>
> Tomi
Sarvela, Tomi P Feb. 1, 2016, 12:20 p.m. UTC | #5
> From: Mika Kuoppala [mailto:mika.kuoppala@linux.intel.com]

> 

> Ok. Then the rendering of the Patchwork_1328 report is somehow wrong as

> in that picture the HANG box is in the nightly base column.


In the result box there is no SKL-I5K column at all. You're looking at HSW-GT2?

Tomi
Mika Kuoppala Feb. 1, 2016, 12:23 p.m. UTC | #6
"Sarvela, Tomi P" <tomi.p.sarvela@intel.com> writes:

>> From: Mika Kuoppala [mailto:mika.kuoppala@linux.intel.com]
>> 
>> Ok. Then the rendering of the Patchwork_1328 report is somehow wrong as
>> in that picture the HANG box is in the nightly base column.
>
> In the result box there is no SKL-I5K column at all. You're looking at HSW-GT2?
>

Yes I was looking at wrong column. My bad.

-Mika

> Tomi
Sarvela, Tomi P Feb. 1, 2016, 12:53 p.m. UTC | #7
> From: Mika Kuoppala [mailto:mika.kuoppala@linux.intel.com]

> 

> "Sarvela, Tomi P" <tomi.p.sarvela@intel.com> writes:

> >

> > In the result box there is no SKL-I5K column at all. You're looking at HSW-

> GT2?

> >

> 

> Yes I was looking at wrong column. My bad.


I can see that this might be confusing.  Reason why it looks like this
is that there is workaround for IGT results.json on CI_IGT side which
has not yet been applied to CI_Patchwork side. This makes the
visualization and comparison logic slightly different.

Tomi
diff mbox

Patch

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index f970209..eb198d0 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -278,6 +278,7 @@ 
 
 #define INTEL_SKL_GT3_IDS(info) \
 	INTEL_VGA_DEVICE(0x1926, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x1927, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x192B, info), /* Halo GT3 */ \
 	INTEL_VGA_DEVICE(0x192A, info)  /* SRV GT3 */