| Message ID | 1454933309-7452-1-git-send-email-damien.lespiau@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Oops, sorry for the error. Thanks for fixing it. Sameer > -----Original Message----- > From: Lespiau, Damien > Sent: Monday, February 08, 2016 4:08 AM > To: intel-gfx@lists.freedesktop.org > Cc: Kibey, Sameer; Dylan Baker > Subject: [PATCH i-g-t] list-workarounds: Fix python 2 print statement > > That script is a python 3 script, so we can't use the python 2 print statement, > it's a function now. > > I missed it in the review because reviewing a diff without additional context > gives you a partial story. > > Cc: Sameer Kibey <sameer.kibey@intel.com> > Cc: Dylan Baker <baker.dylan.c@gmail.com> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > --- > scripts/list-workarounds | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/list-workarounds b/scripts/list-workarounds index > 8b41ae5..70c026d 100755 > --- a/scripts/list-workarounds > +++ b/scripts/list-workarounds > @@ -96,7 +96,7 @@ def print_workarounds(project_root, driver_dir, > project): > sys.exit(1) > > parse(work_arounds) > - print "\nList of workarounds found in %s:" % project > + print("\nList of workarounds found in %s:" % project) > for wa in sorted(workarounds.keys()): > if not options.platform: > print("%s: %s" % (wa, ', '.join(workarounds[wa]))) > -- > 2.4.3
Looks good to me. Reviewed-by: Dylan Baker <dylanx.c.baker@intel.com> Quoting Damien Lespiau (2016-02-08 04:08:29) > That script is a python 3 script, so we can't use the python 2 print > statement, it's a function now. > > I missed it in the review because reviewing a diff without additional > context gives you a partial story. > > Cc: Sameer Kibey <sameer.kibey@intel.com> > Cc: Dylan Baker <baker.dylan.c@gmail.com> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > --- > scripts/list-workarounds | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/list-workarounds b/scripts/list-workarounds > index 8b41ae5..70c026d 100755 > --- a/scripts/list-workarounds > +++ b/scripts/list-workarounds > @@ -96,7 +96,7 @@ def print_workarounds(project_root, driver_dir, project): > sys.exit(1) > > parse(work_arounds) > - print "\nList of workarounds found in %s:" % project > + print("\nList of workarounds found in %s:" % project) > for wa in sorted(workarounds.keys()): > if not options.platform: > print("%s: %s" % (wa, ', '.join(workarounds[wa]))) > -- > 2.4.3 >
diff --git a/scripts/list-workarounds b/scripts/list-workarounds index 8b41ae5..70c026d 100755 --- a/scripts/list-workarounds +++ b/scripts/list-workarounds @@ -96,7 +96,7 @@ def print_workarounds(project_root, driver_dir, project): sys.exit(1) parse(work_arounds) - print "\nList of workarounds found in %s:" % project + print("\nList of workarounds found in %s:" % project) for wa in sorted(workarounds.keys()): if not options.platform: print("%s: %s" % (wa, ', '.join(workarounds[wa])))
That script is a python 3 script, so we can't use the python 2 print statement, it's a function now. I missed it in the review because reviewing a diff without additional context gives you a partial story. Cc: Sameer Kibey <sameer.kibey@intel.com> Cc: Dylan Baker <baker.dylan.c@gmail.com> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- scripts/list-workarounds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)