| Message ID | 1459272427-6201-1-git-send-email-ramalingam.c@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 29, 2016 at 10:57:07PM +0530, Ramalingam C wrote:
> Parameter to IS_BROXTON() is supposed to be dev not dev_priv
You have that backwards. dev_priv is the native pointer that dev is
automagically converted to. INTEL_INFO() takes *drm_i915_private*.
-Chris
On Wednesday 30 March 2016 01:20 AM, Chris Wilson wrote: > On Tue, Mar 29, 2016 at 10:57:07PM +0530, Ramalingam C wrote: >> Parameter to IS_BROXTON() is supposed to be dev not dev_priv > You have that backwards. dev_priv is the native pointer that dev is > automagically converted to. INTEL_INFO() takes *drm_i915_private*. > -Chris Oops. Sorry for unwanted noise. >
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c0627d6..c5c9406 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9988,7 +9988,7 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, active = hsw_get_transcoder_state(crtc, pipe_config, &power_domain_mask); - if (IS_BROXTON(dev_priv)) { + if (IS_BROXTON(dev)) { bxt_get_dsi_transcoder_state(crtc, pipe_config, &power_domain_mask); WARN_ON(active && pipe_config->has_dsi_encoder);
Parameter to IS_BROXTON() is supposed to be dev not dev_priv If needed this could be squashed to the source of the bug. 'commit 4d1de9756832 ("drm/i915/bxt: add dsi transcoders")' Date: Fri Mar 18 17:05:42 2016 +0200 Signed-off-by: Ramalingam C <ramalingam.c@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)