From patchwork Thu Apr 14 19:17:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris BREZILLON X-Patchwork-Id: 8841501 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E2962C0553 for ; Thu, 14 Apr 2016 19:19:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D2EEC2012D for ; Thu, 14 Apr 2016 19:19:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 754242037E for ; Thu, 14 Apr 2016 19:19:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D37F66EAD9; Thu, 14 Apr 2016 19:19:15 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 439FB6EAA1 for ; Thu, 14 Apr 2016 19:18:58 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 348F220DC; Thu, 14 Apr 2016 21:18:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost.localdomain (LFbn-1-2159-240.w90-76.abo.wanadoo.fr [90.76.216.240]) by mail.free-electrons.com (Postfix) with ESMTPSA id 3AF38B2B; Thu, 14 Apr 2016 21:18:37 +0200 (CEST) From: Boris Brezillon To: Thierry Reding , linux-pwm@vger.kernel.org Date: Thu, 14 Apr 2016 21:17:43 +0200 Message-Id: <1460661464-11216-24-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1460661464-11216-1-git-send-email-boris.brezillon@free-electrons.com> References: <1460661464-11216-1-git-send-email-boris.brezillon@free-electrons.com> Cc: Milo Kim , Kamil Debski , Heiko Stuebner , linux-doc@vger.kernel.org, Mike Turquette , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Alexandre Belloni , Daniel Vetter , Stephen Barber , Lee Jones , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, Boris Brezillon , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Alexander Shiyan , Jonathan Corbet , Robert Jarzmik , lm-sensors@lm-sensors.org, linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Tomi Valkeinen , linux-input@vger.kernel.org, Jean-Christophe Plagniol-Villard , intel-gfx@lists.freedesktop.org, Guenter Roeck , Caesar Wang , Jean Delvare , Joachim Eastwood , Bryan Wu , Doug Anderson , Mark Brown , Jacek Anaszewski , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Ryan Mallon , Jingoo Han , Dmitry Torokhov , Stephen Boyd , Liam Girdwood , Hartley Sweeten , Richard Purdie , Kukjin Kim , Maxime Ripard Subject: [Intel-gfx] [PATCH v5 23/24] pwm: switch to the atomic API X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Replace legacy pwm_get/set_xxx() and pwm_config/enable/disable() calls by pwm_get/apply_state(). Signed-off-by: Boris Brezillon --- drivers/pwm/core.c | 5 ++++- drivers/pwm/sysfs.c | 61 +++++++++++++++++++++++++++++++---------------------- 2 files changed, 40 insertions(+), 26 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 112a696..aefffcf 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -947,13 +947,16 @@ static void pwm_dbg_show(struct pwm_chip *chip, struct seq_file *s) for (i = 0; i < chip->npwm; i++) { struct pwm_device *pwm = &chip->pwms[i]; + struct pwm_state state; + + pwm_get_state(pwm, &state); seq_printf(s, " pwm-%-3d (%-20.20s):", i, pwm->label); if (test_bit(PWMF_REQUESTED, &pwm->flags)) seq_puts(s, " requested"); - if (pwm_is_enabled(pwm)) + if (state.enabled) seq_puts(s, " enabled"); seq_puts(s, "\n"); diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c index ab28c89..40daf1c 100644 --- a/drivers/pwm/sysfs.c +++ b/drivers/pwm/sysfs.c @@ -47,13 +47,13 @@ static ssize_t period_show(struct device *child, { struct pwm_export *export = child_to_pwm_export(child); const struct pwm_device *pwm = export->pwm; - unsigned int period; + struct pwm_state state; mutex_lock(&export->lock); - period = pwm_get_period(pwm); + pwm_get_state(pwm, &state); mutex_unlock(&export->lock); - return sprintf(buf, "%u\n", period); + return sprintf(buf, "%u\n", state.period); } static ssize_t period_store(struct device *child, @@ -62,6 +62,7 @@ static ssize_t period_store(struct device *child, { struct pwm_export *export = child_to_pwm_export(child); struct pwm_device *pwm = export->pwm; + struct pwm_state state; unsigned int val; int ret; @@ -70,7 +71,9 @@ static ssize_t period_store(struct device *child, return ret; mutex_lock(&export->lock); - ret = pwm_config(pwm, pwm_get_duty_cycle(pwm), val); + pwm_get_state(pwm, &state); + state.period = val; + ret = pwm_apply_state(pwm, &state); mutex_unlock(&export->lock); return ret ? : size; @@ -82,13 +85,13 @@ static ssize_t duty_cycle_show(struct device *child, { struct pwm_export *export = child_to_pwm_export(child); const struct pwm_device *pwm = export->pwm; - unsigned int duty; + struct pwm_state state; mutex_lock(&export->lock); - duty = pwm_get_duty_cycle(pwm); + pwm_get_state(pwm, &state); mutex_unlock(&export->lock); - return sprintf(buf, "%u\n", duty); + return sprintf(buf, "%u\n", state.duty_cycle); } static ssize_t duty_cycle_store(struct device *child, @@ -97,6 +100,7 @@ static ssize_t duty_cycle_store(struct device *child, { struct pwm_export *export = child_to_pwm_export(child); struct pwm_device *pwm = export->pwm; + struct pwm_state state; unsigned int val; int ret; @@ -105,7 +109,9 @@ static ssize_t duty_cycle_store(struct device *child, return ret; mutex_lock(&export->lock); - ret = pwm_config(pwm, val, pwm_get_period(pwm)); + pwm_get_state(pwm, &state); + state.duty_cycle = val; + ret = pwm_apply_state(pwm, &state); mutex_unlock(&export->lock); return ret ? : size; @@ -117,13 +123,13 @@ static ssize_t enable_show(struct device *child, { struct pwm_export *export = child_to_pwm_export(child); const struct pwm_device *pwm = export->pwm; - bool enabled; + struct pwm_state state; mutex_lock(&export->lock); - enabled = pwm_is_enabled(pwm); + pwm_get_state(pwm, &state); mutex_unlock(&export->lock); - return sprintf(buf, "%d\n", enabled); + return sprintf(buf, "%d\n", state.enabled); } static ssize_t enable_store(struct device *child, @@ -132,24 +138,20 @@ static ssize_t enable_store(struct device *child, { struct pwm_export *export = child_to_pwm_export(child); struct pwm_device *pwm = export->pwm; + struct pwm_state state; int val, ret; ret = kstrtoint(buf, 0, &val); if (ret) return ret; + if (val != 0 && val != 1) + return -EINVAL; + mutex_lock(&export->lock); - switch (val) { - case 0: - pwm_disable(pwm); - break; - case 1: - ret = pwm_enable(pwm); - break; - default: - ret = -EINVAL; - break; - } + pwm_get_state(pwm, &state); + state.enabled = val; + ret = pwm_apply_state(pwm, &state); mutex_unlock(&export->lock); return ret ? : size; @@ -162,9 +164,13 @@ static ssize_t polarity_show(struct device *child, struct pwm_export *export = child_to_pwm_export(child); const struct pwm_device *pwm = export->pwm; const char *polarity = "unknown"; + struct pwm_state state; mutex_lock(&export->lock); - switch (pwm_get_polarity(pwm)) { + pwm_get_state(pwm, &state); + mutex_unlock(&export->lock); + + switch (state.polarity) { case PWM_POLARITY_NORMAL: polarity = "normal"; break; @@ -173,7 +179,6 @@ static ssize_t polarity_show(struct device *child, polarity = "inversed"; break; } - mutex_unlock(&export->lock); return sprintf(buf, "%s\n", polarity); } @@ -185,6 +190,7 @@ static ssize_t polarity_store(struct device *child, struct pwm_export *export = child_to_pwm_export(child); struct pwm_device *pwm = export->pwm; enum pwm_polarity polarity; + struct pwm_state state; int ret; if (sysfs_streq(buf, "normal")) @@ -195,7 +201,12 @@ static ssize_t polarity_store(struct device *child, return -EINVAL; mutex_lock(&export->lock); - ret = pwm_set_polarity(pwm, polarity); + pwm_get_state(pwm, &state); + state.polarity = polarity; + if (state.enabled) + ret = -EBUSY; + else + ret = pwm_apply_state(pwm, &state); mutex_unlock(&export->lock); return ret ? : size;