| Message ID | 1461594951-27706-7-git-send-email-robert.foss@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 25, 2016 at 10:35:51AM -0400, robert.foss@collabora.com wrote: > From: Robert Foss <robert.foss@collabora.com> > > Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI > connectors. > > Signed-off-by: Robert Foss <robert.foss@collabora.com> > --- > tests/kms_panel_fitting.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c > index 272a531..f59d042 100644 > --- a/tests/kms_panel_fitting.c > +++ b/tests/kms_panel_fitting.c > @@ -140,9 +140,16 @@ static void test_panel_fitting(data_t *d) > for_each_connected_output(display, output) { > drmModeModeInfo *mode, native_mode; > > - if (output->config.connector->connector_type != > - DRM_MODE_CONNECTOR_eDP) > - continue; > + /* Ignore over incompatible connectors. */ > + switch (output->config.connector->connector_type) > + { > + case DRM_MODE_CONNECTOR_LVDS: > + case DRM_MODE_CONNECTOR_eDP: > + case DRM_MODE_CONNECTOR_DSI: > + break; > + default: > + continue; > + } What happened to looking for the property? > > pipe = output->config.pipe; > igt_output_set_pipe(output, pipe); > -- > 2.5.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 04/25/2016 11:10 AM, Ville Syrjälä wrote: > On Mon, Apr 25, 2016 at 10:35:51AM -0400, robert.foss@collabora.com wrote: >> From: Robert Foss <robert.foss@collabora.com> >> >> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI >> connectors. >> >> Signed-off-by: Robert Foss <robert.foss@collabora.com> >> --- >> tests/kms_panel_fitting.c | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c >> index 272a531..f59d042 100644 >> --- a/tests/kms_panel_fitting.c >> +++ b/tests/kms_panel_fitting.c >> @@ -140,9 +140,16 @@ static void test_panel_fitting(data_t *d) >> for_each_connected_output(display, output) { >> drmModeModeInfo *mode, native_mode; >> >> - if (output->config.connector->connector_type != >> - DRM_MODE_CONNECTOR_eDP) >> - continue; >> + /* Ignore over incompatible connectors. */ >> + switch (output->config.connector->connector_type) >> + { >> + case DRM_MODE_CONNECTOR_LVDS: >> + case DRM_MODE_CONNECTOR_eDP: >> + case DRM_MODE_CONNECTOR_DSI: >> + break; >> + default: >> + continue; >> + } > What happened to looking for the property? The "scaling mode" property? I was intentionally leaving it out. If desired, I could look into adding that too. I've looked for and not found the "scaling mode" property id, but I still haven't found it. Do you know what it is? > >> >> pipe = output->config.pipe; >> igt_output_set_pipe(output, pipe); >> -- >> 2.5.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, Apr 25, 2016 at 11:38:06AM -0400, Robert Foss wrote: > > > On 04/25/2016 11:10 AM, Ville Syrjälä wrote: > > On Mon, Apr 25, 2016 at 10:35:51AM -0400, robert.foss@collabora.com wrote: > >> From: Robert Foss <robert.foss@collabora.com> > >> > >> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI > >> connectors. > >> > >> Signed-off-by: Robert Foss <robert.foss@collabora.com> > >> --- > >> tests/kms_panel_fitting.c | 13 ++++++++++--- > >> 1 file changed, 10 insertions(+), 3 deletions(-) > >> > >> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c > >> index 272a531..f59d042 100644 > >> --- a/tests/kms_panel_fitting.c > >> +++ b/tests/kms_panel_fitting.c > >> @@ -140,9 +140,16 @@ static void test_panel_fitting(data_t *d) > >> for_each_connected_output(display, output) { > >> drmModeModeInfo *mode, native_mode; > >> > >> - if (output->config.connector->connector_type != > >> - DRM_MODE_CONNECTOR_eDP) > >> - continue; > >> + /* Ignore over incompatible connectors. */ > >> + switch (output->config.connector->connector_type) > >> + { > >> + case DRM_MODE_CONNECTOR_LVDS: > >> + case DRM_MODE_CONNECTOR_eDP: > >> + case DRM_MODE_CONNECTOR_DSI: > >> + break; > >> + default: > >> + continue; > >> + } > > What happened to looking for the property? > The "scaling mode" property? I was intentionally leaving it out. > If desired, I could look into adding that too. > > I've looked for and not found the "scaling mode" property id, but I > still haven't found it. > Do you know what it is? drm object ids are assigned at runtime, so they're not something you can hardcode anywhere. Instead you'll need to do the lookup based on the property name. > > > >> > >> pipe = output->config.pipe; > >> igt_output_set_pipe(output, pipe); > >> -- > >> 2.5.0 > >> > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c index 272a531..f59d042 100644 --- a/tests/kms_panel_fitting.c +++ b/tests/kms_panel_fitting.c @@ -140,9 +140,16 @@ static void test_panel_fitting(data_t *d) for_each_connected_output(display, output) { drmModeModeInfo *mode, native_mode; - if (output->config.connector->connector_type != - DRM_MODE_CONNECTOR_eDP) - continue; + /* Ignore over incompatible connectors. */ + switch (output->config.connector->connector_type) + { + case DRM_MODE_CONNECTOR_LVDS: + case DRM_MODE_CONNECTOR_eDP: + case DRM_MODE_CONNECTOR_DSI: + break; + default: + continue; + } pipe = output->config.pipe; igt_output_set_pipe(output, pipe);