From patchwork Mon Apr 25 15:05:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 8929551 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E10B79F1C1 for ; Mon, 25 Apr 2016 15:05:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B7B74201EC for ; Mon, 25 Apr 2016 15:05:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 74E2B20115 for ; Mon, 25 Apr 2016 15:05:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E14296E63A; Mon, 25 Apr 2016 15:05:31 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E9E96E63B for ; Mon, 25 Apr 2016 15:05:28 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: robertfoss) with ESMTPSA id 87976260AEE From: robert.foss@collabora.com To: marius.c.vlad@intel.com, daniel.vetter@ffwll.ch, tomeu.vizoso@collabora.com Date: Mon, 25 Apr 2016 11:05:13 -0400 Message-Id: <1461596713-20384-5-git-send-email-robert.foss@collabora.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1461596713-20384-1-git-send-email-robert.foss@collabora.com> References: <1461596713-20384-1-git-send-email-robert.foss@collabora.com> Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH i-g-t v3 4/4] kms_vblank: Switch from using crtc0 statically to explicitly setting mode. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Robert Foss Previously crtc0 was statically used for VBLANK tests, but that assumption is not valid for the VC4 platform. Instead we're now explicitly setting the mode. Also add support for testing all connected connectors during the same test. Signed-off-by: Robert Foss --- tests/kms_vblank.c | 179 +++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 140 insertions(+), 39 deletions(-) diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index 40ab6fd..970fefe 100644 --- a/tests/kms_vblank.c +++ b/tests/kms_vblank.c @@ -44,6 +44,14 @@ IGT_TEST_DESCRIPTION("Test speed of WaitVblank."); +typedef struct { + int drm_fd; + igt_display_t display; + struct igt_fb primary_fb; + igt_output_t *output; + enum pipe pipe; +} data_t; + static double elapsed(const struct timespec *start, const struct timespec *end, int loop) @@ -51,75 +59,164 @@ static double elapsed(const struct timespec *start, return (1e6*(end->tv_sec - start->tv_sec) + (end->tv_nsec - start->tv_nsec)/1000)/loop; } -static bool crtc0_active(int fd) +static uint32_t crtc_id_to_flag(uint32_t crtc_id) { - union drm_wait_vblank vbl; + if (crtc_id == 0) + return 0; + else if (crtc_id == 1) + return 1 | _DRM_VBLANK_SECONDARY; + else + return crtc_id << 1; +} - memset(&vbl, 0, sizeof(vbl)); - vbl.request.type = DRM_VBLANK_RELATIVE; - return drmIoctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl) == 0; +static bool prepare_crtc(data_t *data, igt_output_t *output) +{ + drmModeModeInfo *mode; + igt_display_t *display = &data->display; + igt_plane_t *primary; + + /* select the pipe we want to use */ + igt_output_set_pipe(output, data->pipe); + igt_display_commit(display); + + if (!output->valid) { + igt_output_set_pipe(output, PIPE_ANY); + igt_display_commit(display); + return false; + } + + /* create and set the primary plane fb */ + mode = igt_output_get_mode(output); + igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 0.0, 0.0, 0.0, + &data->primary_fb); + + primary = igt_output_get_plane(output, IGT_PLANE_PRIMARY); + igt_plane_set_fb(primary, &data->primary_fb); + + igt_display_commit(display); + + igt_wait_for_vblank(data->drm_fd, data->pipe); + + return true; +} + +static void cleanup_crtc(data_t *data, igt_output_t *output) +{ + igt_display_t *display = &data->display; + igt_plane_t *primary; + + igt_remove_fb(data->drm_fd, &data->primary_fb); + + primary = igt_output_get_plane(output, IGT_PLANE_PRIMARY); + igt_plane_set_fb(primary, NULL); + + igt_output_set_pipe(output, PIPE_ANY); + igt_display_commit(display); } -static void accuracy(int fd) +static void run_test(data_t *data, void (*testfunc)(data_t *, bool), bool boolean) +{ + igt_display_t *display = &data->display; + igt_output_t *output; + enum pipe p; + int valid_tests = 0; + + for_each_connected_output(display, output) { + for_each_pipe(display, p) { + data->pipe = p; + + if (!prepare_crtc(data, output)) + continue; + + valid_tests++; + + igt_info("Beginning %s on pipe %s, connector %s\n", + igt_subtest_name(), + kmstest_pipe_name(data->pipe), + igt_output_name(output)); + + testfunc(data, boolean); + + igt_info("\n%s on pipe %s, connector %s: PASSED\n\n", + igt_subtest_name(), + kmstest_pipe_name(data->pipe), + igt_output_name(output)); + + /* cleanup what prepare_crtc() has done */ + cleanup_crtc(data, output); + } + } + + igt_require_f(valid_tests, "no valid crtc/connector combinations found\n"); +} + +static void accuracy(data_t *data, bool busy) { union drm_wait_vblank vbl; unsigned long target; + uint32_t crtc_id_flag; int n; memset(&vbl, 0, sizeof(vbl)); + crtc_id_flag = crtc_id_to_flag(data->pipe); - vbl.request.type = DRM_VBLANK_RELATIVE; + vbl.request.type = DRM_VBLANK_RELATIVE | crtc_id_flag; vbl.request.sequence = 1; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); target = vbl.reply.sequence + 60; for (n = 0; n < 60; n++) { - vbl.request.type = DRM_VBLANK_RELATIVE; + vbl.request.type = DRM_VBLANK_RELATIVE | crtc_id_flag; vbl.request.sequence = 1; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); - vbl.request.type = DRM_VBLANK_ABSOLUTE | DRM_VBLANK_EVENT; + vbl.request.type = DRM_VBLANK_ABSOLUTE | DRM_VBLANK_EVENT | crtc_id_flag; vbl.request.sequence = target; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); } - vbl.request.type = DRM_VBLANK_RELATIVE; + vbl.request.type = DRM_VBLANK_RELATIVE | crtc_id_flag; vbl.request.sequence = 0; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); igt_assert_eq(vbl.reply.sequence, target); for (n = 0; n < 60; n++) { struct drm_event_vblank ev; - igt_assert_eq(read(fd, &ev, sizeof(ev)), sizeof(ev)); + igt_assert_eq(read(data->drm_fd, &ev, sizeof(ev)), sizeof(ev)); igt_assert_eq(ev.sequence, target); } } -static void vblank_query(int fd, bool busy) +static void vblank_query(data_t *data, bool busy) { union drm_wait_vblank vbl; struct timespec start, end; unsigned long sq, count = 0; struct drm_event_vblank buf; + uint32_t crtc_id_flag; memset(&vbl, 0, sizeof(vbl)); + crtc_id_flag = crtc_id_to_flag(data->pipe); if (busy) { - vbl.request.type = DRM_VBLANK_RELATIVE | DRM_VBLANK_EVENT; + vbl.request.type = DRM_VBLANK_RELATIVE | DRM_VBLANK_EVENT | crtc_id_flag; vbl.request.sequence = 72; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); } - vbl.request.type = DRM_VBLANK_RELATIVE; + vbl.request.type = DRM_VBLANK_RELATIVE | crtc_id_flag; vbl.request.sequence = 0; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); sq = vbl.reply.sequence; clock_gettime(CLOCK_MONOTONIC, &start); do { - vbl.request.type = DRM_VBLANK_RELATIVE; + vbl.request.type = DRM_VBLANK_RELATIVE | crtc_id_flag; vbl.request.sequence = 0; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); count++; } while ((vbl.reply.sequence - sq) <= 60); clock_gettime(CLOCK_MONOTONIC, &end); @@ -128,35 +225,37 @@ static void vblank_query(int fd, bool busy) busy ? "busy" : "idle", elapsed(&start, &end, count)); if (busy) - igt_assert_eq(read(fd, &buf, sizeof(buf)), sizeof(buf)); + igt_assert_eq(read(data->drm_fd, &buf, sizeof(buf)), sizeof(buf)); } -static void vblank_wait(int fd, bool busy) +static void vblank_wait(data_t *data, bool busy) { union drm_wait_vblank vbl; struct timespec start, end; unsigned long sq, count = 0; struct drm_event_vblank buf; + uint32_t crtc_id_flag; memset(&vbl, 0, sizeof(vbl)); + crtc_id_flag = crtc_id_to_flag(data->pipe); if (busy) { - vbl.request.type = DRM_VBLANK_RELATIVE | DRM_VBLANK_EVENT; + vbl.request.type |= DRM_VBLANK_RELATIVE | DRM_VBLANK_EVENT | crtc_id_flag; vbl.request.sequence = 72; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); } - vbl.request.type = DRM_VBLANK_RELATIVE; + vbl.request.type |= DRM_VBLANK_RELATIVE | crtc_id_flag; vbl.request.sequence = 0; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); sq = vbl.reply.sequence; clock_gettime(CLOCK_MONOTONIC, &start); do { - vbl.request.type = DRM_VBLANK_RELATIVE; + vbl.request.type = DRM_VBLANK_RELATIVE | crtc_id_flag; vbl.request.sequence = 1; - do_ioctl(fd, DRM_IOCTL_WAIT_VBLANK, &vbl); + do_ioctl(data->drm_fd, DRM_IOCTL_WAIT_VBLANK, &vbl); count++; } while ((vbl.reply.sequence - sq) <= 60); clock_gettime(CLOCK_MONOTONIC, &end); @@ -167,32 +266,34 @@ static void vblank_wait(int fd, bool busy) elapsed(&start, &end, count)); if (busy) - igt_assert_eq(read(fd, &buf, sizeof(buf)), sizeof(buf)); + igt_assert_eq(read(data->drm_fd, &buf, sizeof(buf)), sizeof(buf)); } igt_main { - int fd; + data_t data; igt_skip_on_simulation(); igt_fixture { - fd = drm_open_driver(DRIVER_ANY); - igt_require(crtc0_active(fd)); + data.drm_fd = drm_open_driver(DRIVER_ANY); + kmstest_set_vt_graphics_mode(); + igt_display_init(&data.display, data.drm_fd); } igt_subtest("accuracy") - accuracy(fd); + run_test(&data, accuracy, false); igt_subtest("query-idle") - vblank_query(fd, false); + run_test(&data, vblank_query, false); igt_subtest("query-busy") - vblank_query(fd, true); + run_test(&data, vblank_query, true); igt_subtest("wait-idle") - vblank_wait(fd, false); + run_test(&data, vblank_wait, false); igt_subtest("wait-busy") - vblank_wait(fd, true); + run_test(&data, vblank_wait, true); } +