diff mbox

[i-g-t,v2,6/8] tests/gem_storedw_loop: Remove from BAT.

Message ID 1464366473-14046-6-git-send-email-marius.c.vlad@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Marius Vlad May 27, 2016, 4:27 p.m. UTC 
Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_storedw_loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tvrtko Ursulin May 31, 2016, 12:05 p.m. UTC | #1 
On 27/05/16 17:27, Marius Vlad wrote:
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> ---
>   tests/gem_storedw_loop.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c
> index 317b8c6..a0c5af1 100644
> --- a/tests/gem_storedw_loop.c
> +++ b/tests/gem_storedw_loop.c
> @@ -185,7 +185,7 @@ igt_main
>   	}
>
>   	for (e = intel_execution_engines; e->name; e++) {
> -		igt_subtest_f("basic-%s", e->name) {
> +		igt_subtest_f("%s", e->name) {
>   			check_test_requirements(fd, e->exec_id);
>   			store_test(fd, e->exec_id | e->flags, 16*1024);
>   		}
>

Again instead of removing make a shorter version for BAT?

Regards,

Tvrtko
Chris Wilson May 31, 2016, 12:18 p.m. UTC | #2 
On Tue, May 31, 2016 at 01:05:00PM +0100, Tvrtko Ursulin wrote:
> 
> On 27/05/16 17:27, Marius Vlad wrote:
> >Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> >---
> >  tests/gem_storedw_loop.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c
> >index 317b8c6..a0c5af1 100644
> >--- a/tests/gem_storedw_loop.c
> >+++ b/tests/gem_storedw_loop.c
> >@@ -185,7 +185,7 @@ igt_main
> >  	}
> >
> >  	for (e = intel_execution_engines; e->name; e++) {
> >-		igt_subtest_f("basic-%s", e->name) {
> >+		igt_subtest_f("%s", e->name) {
> >  			check_test_requirements(fd, e->exec_id);
> >  			store_test(fd, e->exec_id | e->flags, 16*1024);
> >  		}
> >
> 
> Again instead of removing make a shorter version for BAT?

This one can be dropped.

gem_exec_store covers the inter-ring synchronisation for writes and
gem_sync covers the missed interrupt syndrome.

(gem_exec_whisper would cover the inter-ring synchronisation for reads
and writes, but that is too slow under lockdep/memdebug + execlists.)
-Chris
diff mbox

Patch

diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c
index 317b8c6..a0c5af1 100644
--- a/tests/gem_storedw_loop.c
+++ b/tests/gem_storedw_loop.c
@@ -185,7 +185,7 @@  igt_main
 	}
 
 	for (e = intel_execution_engines; e->name; e++) {
-		igt_subtest_f("basic-%s", e->name) {
+		igt_subtest_f("%s", e->name) {
 			check_test_requirements(fd, e->exec_id);
 			store_test(fd, e->exec_id | e->flags, 16*1024);
 		}