diff mbox

[1/2] SNB (and IVB too I suppose) starts to misbehave if the GPU gets stuck in an infinite batch buffer loop. The GPU apparently hogs something critical and CPUs start to lose interrupts and whatnot. We can keep the system limping along by unmasking some

Message ID 1464633971-3559-1-git-send-email-sagar.a.kamble@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

sagar.a.kamble@intel.com May 30, 2016, 6:46 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

v2: s/gen6_rps_pm_mask/gen6_sanitize_rps_pm_mask/ (Chris)

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

sagar.a.kamble@intel.com June 1, 2016, 8:12 a.m. UTC | #1 
These warnings are too not related to the patch.
Kindly push this patch.

On 5/31/2016 4:35 PM, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/1] drm/i915: Never fully mask the the EI up rps interrupt on SNB/IVB
> URL   : https://patchwork.freedesktop.org/series/7990/
> State : warning
>
> == Summary ==
>
> Series 7990v1 Series without cover letter
> http://patchwork.freedesktop.org/api/1.0/series/7990/revisions/1/mbox
>
> Test gem_busy:
>          Subgroup basic-parallel-render:
>                  pass       -> DMESG-WARN (ro-ivb2-i7-3770)
>          Subgroup basic-render:
>                  pass       -> DMESG-WARN (ro-ivb2-i7-3770)
> Test gem_close_race:
>          Subgroup basic-process:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
> Test gem_cs_tlb:
>          Subgroup basic-default:
>                  pass       -> DMESG-WARN (ro-ivb2-i7-3770)
> Test gem_exec_basic:
>          Subgroup readonly-render:
>                  dmesg-warn -> PASS       (ro-ivb2-i7-3770)
> Test gem_exec_flush:
>          Subgroup basic-uc-prw-default:
>                  pass       -> DMESG-WARN (ro-skl-i7-6700hq)
>          Subgroup basic-uc-ro-default:
>                  pass       -> DMESG-WARN (ro-skl-i7-6700hq)
> Test gem_exec_parallel:
>          Subgroup basic:
>                  pass       -> DMESG-WARN (ro-ivb2-i7-3770)
> Test gem_exec_store:
>          Subgroup basic-all:
>                  pass       -> DMESG-WARN (ro-ivb2-i7-3770)
>          Subgroup basic-blt:
>                  dmesg-warn -> PASS       (ro-ivb2-i7-3770)
>          Subgroup basic-default:
>                  dmesg-warn -> PASS       (ro-ivb2-i7-3770)
> Test gem_flink_basic:
>          Subgroup bad-flink:
>                  pass       -> DMESG-WARN (ro-skl-i7-6700hq)
> Test gem_mmap_gtt:
>          Subgroup basic-short:
>                  pass       -> DMESG-WARN (ro-skl-i7-6700hq)
>          Subgroup basic-small-copy:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
> Test gem_storedw_loop:
>          Subgroup basic-bsd:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
> Test gem_tiled_pread_basic:
>                  pass       -> DMESG-WARN (ro-skl-i7-6700hq)
> Test kms_addfb_basic:
>          Subgroup addfb25-framebuffer-vs-set-tiling:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
>          Subgroup addfb25-x-tiled:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
>          Subgroup addfb25-y-tiled-small:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
>          Subgroup bad-pitch-1024:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
>          Subgroup bad-pitch-63:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
>          Subgroup basic-x-tiled:
>                  pass       -> DMESG-WARN (ro-skl-i7-6700hq)
>          Subgroup too-high:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
>          Subgroup too-wide:
>                  dmesg-warn -> PASS       (ro-skl-i7-6700hq)
> Test kms_force_connector_basic:
>          Subgroup force-edid:
>                  pass       -> DMESG-WARN (ro-ivb2-i7-3770)
>
> fi-bdw-i7-5557u  total:102  pass:93   dwarn:0   dfail:0   fail:0   skip:8
> fi-byt-n2820     total:209  pass:168  dwarn:0   dfail:0   fail:3   skip:38
> fi-hsw-i7-4770k  total:209  pass:190  dwarn:0   dfail:0   fail:0   skip:19
> fi-hsw-i7-4770r  total:209  pass:186  dwarn:0   dfail:0   fail:0   skip:23
> fi-skl-i7-6700k  total:209  pass:184  dwarn:0   dfail:0   fail:0   skip:25
> fi-snb-i7-2600   total:209  pass:170  dwarn:0   dfail:0   fail:0   skip:39
> ro-bdw-i5-5250u  total:102  pass:93   dwarn:0   dfail:0   fail:0   skip:8
> ro-bdw-i7-5600u  total:102  pass:75   dwarn:0   dfail:0   fail:0   skip:26
> ro-bsw-n3050     total:209  pass:168  dwarn:0   dfail:0   fail:2   skip:39
> ro-byt-n2820     total:209  pass:169  dwarn:0   dfail:0   fail:3   skip:37
> ro-hsw-i3-4010u  total:209  pass:186  dwarn:0   dfail:0   fail:0   skip:23
> ro-hsw-i7-4770r  total:102  pass:82   dwarn:0   dfail:0   fail:0   skip:19
> ro-ilk-i7-620lm  total:1    pass:0    dwarn:0   dfail:0   fail:0   skip:0
> ro-ilk1-i5-650   total:204  pass:146  dwarn:0   dfail:0   fail:1   skip:57
> ro-ivb-i7-3770   total:102  pass:75   dwarn:0   dfail:0   fail:0   skip:26
> ro-ivb2-i7-3770  total:102  pass:42   dwarn:37  dfail:0   fail:0   skip:22
> ro-skl-i7-6700hq total:204  pass:175  dwarn:8   dfail:0   fail:0   skip:21
> ro-snb-i7-2620M  total:102  pass:72   dwarn:0   dfail:0   fail:0   skip:29
> fi-bsw-n3050 failed to connect after reboot
> ro-bdw-i7-5557U failed to connect after reboot
>
> Results at /archive/results/CI_IGT_test/RO_Patchwork_1055/
>
> 031f2bb drm-intel-nightly: 2016y-05m-30d-17h-51m-33s UTC integration manifest
> 5779419 drm/i915: Never fully mask the the EI up rps interrupt on SNB/IVB
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index adb6463..aee56ae 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4715,7 +4715,7 @@  void gen6_rps_idle(struct drm_i915_private *dev_priv)
 		else
 			gen6_set_rps(dev_priv, dev_priv->rps.idle_freq);
 		dev_priv->rps.last_adj = 0;
-		I915_WRITE(GEN6_PMINTRMSK, 0xffffffff);
+		I915_WRITE(GEN6_PMINTRMSK, gen6_sanitize_rps_pm_mask(dev_priv, ~0));
 	}
 	mutex_unlock(&dev_priv->rps.hw_lock);